All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Prathamesh Deshpande <prathameshdeshpande7@gmail.com>
Cc: osdevtc@gmail.com, gregkh@linuxfoundation.org,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: wlan-ng: prism2fw.c: Fix "Possible unnecessary 'out of memory' message" checkpatch.pl warning"
Date: Wed, 2 Jan 2019 01:46:20 -0800 (PST)	[thread overview]
Message-ID: <20190102094620.GE3781@kadam> (raw)
In-Reply-To: <1545667888-38999-1-git-send-email-prathameshdeshpande7@gmail.com>

The subject is too long.

On Mon, Dec 24, 2018 at 08:11:28AM -0800, Prathamesh Deshpande wrote:
> This patch removes unnecessary out of memory warning
> message from wlan-ng prism2fw.c file.
> 
> Signed-off-by: Prathamesh Deshpande <prathameshdeshpande7@gmail.com>
> ---
>  drivers/staging/wlan-ng/prism2fw.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c
> index bb572b7..c040066 100644
> --- a/drivers/staging/wlan-ng/prism2fw.c
> +++ b/drivers/staging/wlan-ng/prism2fw.c
> @@ -557,7 +557,6 @@ static int mkimage(struct imgchunk *clist, unsigned int *ccnt)
>  	for (i = 0; i < *ccnt; i++) {
>  		clist[i].data = kzalloc(clist[i].len, GFP_KERNEL);
>  		if (!clist[i].data) {
> -			pr_err("failed to allocate image space, exiting.\n");
>  			return 1;
>  		}

Remove the curly braces.

regards,
dan carpenter


      reply	other threads:[~2019-01-02  9:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-24 16:11 [PATCH] staging: wlan-ng: prism2fw.c: Fix "Possible unnecessary 'out of memory' message" checkpatch.pl warning" Prathamesh Deshpande
2019-01-02  9:46 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190102094620.GE3781@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=osdevtc@gmail.com \
    --cc=prathameshdeshpande7@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.