From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9B29C43387 for ; Thu, 3 Jan 2019 09:39:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B813F21019 for ; Thu, 3 Jan 2019 09:39:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="E+2PRvTR"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="r75D68V+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B813F21019 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bzNepELaOHwheU22ZV32FlE0MFl78+d796+OdMxemus=; b=E+2PRvTRv5U0Jh eu9AVTGCnEsb2M4SG+eYidvfBd2NQFStPXn3E4xyGza+h75rVswqkipzpnizb5yYlW+gnmM445v1j zh/ov8mN+kh3uQ2SBCnd2VPkp9i7OeJo50CqFxp9nepdu4HjdfZKLM9lAVwVDqQ1yDDUqoCxgrQac MqcQGgmD86zNHIRlo/l1KXukwUME7eNuvw4uB9rfVey0nvqvamthx9eDYxPWmPYOZnB+IxB+UDmmo wN6jDVHBsQOsBpMCtLRtLgoAtfqKUgOWYNON7FVHigRHUQbRWAkfzWSxPq1N0dJvs0DqUkE1yb263 TXWN37pHvzDplRFTpjWA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gezSz-0007DJ-M3; Thu, 03 Jan 2019 09:39:05 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gezSw-0007CW-UY for linux-arm-kernel@lists.infradead.org; Thu, 03 Jan 2019 09:39:04 +0000 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0D8B221019; Thu, 3 Jan 2019 09:39:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546508340; bh=tIuOwBoDNPFBYczIQ+f0QpEYcT8fDPEDg7wsSAJAs6I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r75D68V+JMNpKK7qdQJyRlNEY4d3Sn/iZ9LMQQzQtTOPlGM2penXmKnJMxgiK+TtX XFBM9g7yaTwT7SAzXEt6KS6TgKliSKONEM1uzwED1ZTnPdeBq4mYp3K4uWEQLg04B5 HgSJVUysJDX3P8JCd/CAorgPyjYvPk4Peq2nz2Z0= Date: Thu, 3 Jan 2019 10:38:58 +0100 From: Greg Kroah-Hartman To: Jeremy Linton Subject: Re: [PATCH v2 1/7] sysfs/cpu: Add "Unknown" vulnerability state Message-ID: <20190103093858.GA10794@kroah.com> References: <20190103004921.1928921-1-jeremy.linton@arm.com> <20190103004921.1928921-2-jeremy.linton@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190103004921.1928921-2-jeremy.linton@arm.com> User-Agent: Mutt/1.11.1 (2018-12-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190103_013903_004274_4B6B01EC X-CRM114-Status: GOOD ( 11.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, David Woodhouse , mlangsdo@redhat.com, "Rafael J . Wysocki" , Konrad Rzeszutek Wilk , suzuki.poulose@arm.com, marc.zyngier@arm.com, catalin.marinas@arm.com, Dave Hansen , julien.thierry@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, steven.price@arm.com, Peter Zijlstra , Borislav Petkov , shankerd@codeaurora.org, ykaukab@suse.de, Thomas Gleixner , dave.martin@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 02, 2019 at 06:49:15PM -0600, Jeremy Linton wrote: > There is a lot of variation in the Arm ecosystem. Because of this, > there exist possible cases where the kernel cannot authoritatively > determine if a machine is vulnerable. Really? Why not? What keeps you from "knowing" this? Can't the developer of the chip tell you? > Rather than guess the vulnerability status in cases where > the mitigation is disabled or the firmware isn't responding > correctly, we need to display an "Unknown" state. Shouldn't "Unknown" really be the same thing as "Vulnerable"? A user should treat it the same way, "Unknown" makes it feel like "maybe I can just ignore this and hope I really am safe", which is not a good idea at all. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B84AFC43387 for ; Thu, 3 Jan 2019 09:39:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 83A0B21479 for ; Thu, 3 Jan 2019 09:39:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546508342; bh=tIuOwBoDNPFBYczIQ+f0QpEYcT8fDPEDg7wsSAJAs6I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=AFT2wIBwTkE89Y4D/A1dlvXNP4ChYCYU/J70ayti9EOJ3JrAoLMEJ1YRo8yT31tgb R3nHSsOsLkWOmag8xaJ14LWUAztz9M9booniwwD1DqQu8+LOZFT3VlTs51vtGrwxbs weO20auWfxYlLXzYglRr4eFDQYv12IfqihowSnkM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730526AbfACJjB (ORCPT ); Thu, 3 Jan 2019 04:39:01 -0500 Received: from mail.kernel.org ([198.145.29.99]:45794 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726152AbfACJjB (ORCPT ); Thu, 3 Jan 2019 04:39:01 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0D8B221019; Thu, 3 Jan 2019 09:39:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546508340; bh=tIuOwBoDNPFBYczIQ+f0QpEYcT8fDPEDg7wsSAJAs6I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r75D68V+JMNpKK7qdQJyRlNEY4d3Sn/iZ9LMQQzQtTOPlGM2penXmKnJMxgiK+TtX XFBM9g7yaTwT7SAzXEt6KS6TgKliSKONEM1uzwED1ZTnPdeBq4mYp3K4uWEQLg04B5 HgSJVUysJDX3P8JCd/CAorgPyjYvPk4Peq2nz2Z0= Date: Thu, 3 Jan 2019 10:38:58 +0100 From: Greg Kroah-Hartman To: Jeremy Linton Cc: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will.deacon@arm.com, marc.zyngier@arm.com, suzuki.poulose@arm.com, dave.martin@arm.com, shankerd@codeaurora.org, mark.rutland@arm.com, linux-kernel@vger.kernel.org, ykaukab@suse.de, julien.thierry@arm.com, mlangsdo@redhat.com, steven.price@arm.com, Thomas Gleixner , "Rafael J . Wysocki" , Konrad Rzeszutek Wilk , Peter Zijlstra , Dave Hansen , Borislav Petkov , David Woodhouse Subject: Re: [PATCH v2 1/7] sysfs/cpu: Add "Unknown" vulnerability state Message-ID: <20190103093858.GA10794@kroah.com> References: <20190103004921.1928921-1-jeremy.linton@arm.com> <20190103004921.1928921-2-jeremy.linton@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190103004921.1928921-2-jeremy.linton@arm.com> User-Agent: Mutt/1.11.1 (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 02, 2019 at 06:49:15PM -0600, Jeremy Linton wrote: > There is a lot of variation in the Arm ecosystem. Because of this, > there exist possible cases where the kernel cannot authoritatively > determine if a machine is vulnerable. Really? Why not? What keeps you from "knowing" this? Can't the developer of the chip tell you? > Rather than guess the vulnerability status in cases where > the mitigation is disabled or the firmware isn't responding > correctly, we need to display an "Unknown" state. Shouldn't "Unknown" really be the same thing as "Vulnerable"? A user should treat it the same way, "Unknown" makes it feel like "maybe I can just ignore this and hope I really am safe", which is not a good idea at all. thanks, greg k-h