From mboxrd@z Thu Jan  1 00:00:00 1970
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Subject: [09/19] usbnet: smsc95xx: Connect to phydev
From: Andrew Lunn <andrew@lunn.ch>
Message-Id: <20190103132250.GA21849@lunn.ch>
Date: Thu, 3 Jan 2019 14:22:50 +0100
To: Marek Vasut <marex@denx.de>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>, Nisar Sayed <Nisar.Sayed@microchip.com>, Woojung Huh <Woojung.Huh@microchip.com>, Florian Fainelli <f.fainelli@gmail.com>, linux-usb@vger.kernel.org
List-ID: <linux-usb.vger.kernel.org>

T24gVGh1LCBKYW4gMDMsIDIwMTkgYXQgMDI6MTA6MzBBTSArMDEwMCwgTWFyZWsgVmFzdXQgd3Jv
dGU6Cj4gQWRkIGNvZGUgdG8gZGV0ZWN0IGFuZCBjb25uZWN0IHRvIFBIWS4gVGhlIGludGVybmFs
IFBIWSBvZiB0aGUgU01TQzk1eHgKPiBpcyBhIHJlZ3VsYXIgU01TQyBMQU44NzAwIGFuZCB0aGUg
ZHJpdmVyIG9ubHkgc3VwcG9ydHMgdGhlIGludGVybmFsIFBIWSwKPiBzbyBqdXN0IHVzZSB0aGUg
U01TQyBQSFkgZHJpdmVyIHRvIGNvbmZpZ3VyZSB0aGUgUEhZLiBOb3RlIHRoYXQgdGhlCj4gZHJp
dmVyIGRvZXMgYSBsb3Qgb2YgZXh0cmEgY29uZmlndXJhdGlvbiBvZiB0aGUgUEhZLCB3aGljaCBp
cyBsZWZ0IGluCj4gdG8gYXZvaWQgYnJlYWthZ2UuIFNvbWUgb2YgdGhlIGV4dHJhIGNvbmZpZ3Vy
YXRpb24gaXMgc29ydGVkIG91dCBieQo+IGxhdGVyIHBhdGNoZXMgaW4gdGhpcyBzZXJpZXMuCgpI
aSBNYXJlawoKQSBNQUMgZHJpdmVyIGlzIG5vdCBleHBlY3RlZCB0byB0b3VjaCB0aGUgUEhZIGF0
IGFsbC4gUGxlYXNlIHRyeSB0bwpyZW1vdmUgYXMgbXVjaCBvZiB0aGUgZXh0cmEgY29uZmlndXJh
dGlvbiBhcyBwb3NzaWJsZSwgYWRkaW5nIGl0IHRvCnRoZSBMQU44NzAwIFBIWSBkcml2ZXIgYXMg
bmVlZGVkLgoKWW91IGFsc28gaGF2ZSB0byBiZSBjYXJlZnVsIG9mIGxvY2tpbmcuIHBoeWxpYiB0
YWtlcyB0aGUgcGh5ZGV2IGxvY2sKd2hlbiBjYWxsaW5nIGludG8gdGhlIFBIWSBkcml2ZXIuIEFu
eXRoaW5nIHRoZSBNQUMgZG9lcyB0byB0aGUgUEhZIGlzCm5vdCBnb2luZyB0byBiZSBkb25lIHdp
dGggdGhpcyBsb2NrIGhlbGQuIFNvIGJhZCB0aGluZ3MgY2FuIGhhcHBlbi4KCiAgICBBbmRyZXcK

From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH 09/19] usbnet: smsc95xx: Connect to phydev
Date: Thu, 3 Jan 2019 14:22:50 +0100
Message-ID: <20190103132250.GA21849@lunn.ch>
References: <20190103011040.25974-1-marex@denx.de>
 <20190103011040.25974-10-marex@denx.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
        Nisar Sayed <Nisar.Sayed@microchip.com>,
        Woojung Huh <Woojung.Huh@microchip.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        linux-usb@vger.kernel.org
To: Marek Vasut <marex@denx.de>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:32915 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727067AbfACNW7 (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 3 Jan 2019 08:22:59 -0500
Content-Disposition: inline
In-Reply-To: <20190103011040.25974-10-marex@denx.de>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, Jan 03, 2019 at 02:10:30AM +0100, Marek Vasut wrote:
> Add code to detect and connect to PHY. The internal PHY of the SMSC95xx
> is a regular SMSC LAN8700 and the driver only supports the internal PHY,
> so just use the SMSC PHY driver to configure the PHY. Note that the
> driver does a lot of extra configuration of the PHY, which is left in
> to avoid breakage. Some of the extra configuration is sorted out by
> later patches in this series.

Hi Marek

A MAC driver is not expected to touch the PHY at all. Please try to
remove as much of the extra configuration as possible, adding it to
the LAN8700 PHY driver as needed.

You also have to be careful of locking. phylib takes the phydev lock
when calling into the PHY driver. Anything the MAC does to the PHY is
not going to be done with this lock held. So bad things can happen.

    Andrew