Re: [PATCH] SUNRPC: Fix TCP receive code on archs with flush_dcache_page()

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2327 bytes --]

Hi Trond,

I love your patch! Perhaps something to improve:

[auto build test WARNING on nfs/linux-next]
[also build test WARNING on v4.20 next-20190102]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Trond-Myklebust/SUNRPC-Fix-TCP-receive-code-on-archs-with-flush_dcache_page/20190103-113507
base:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
config: m68k-sun3_defconfig (attached as .config)
compiler: m68k-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=m68k 

All warnings (new ones prefixed by >>):

   In file included from include/linux/pagemap.h:8:0,
                    from net/sunrpc/xprtsock.c:27:
   net/sunrpc/xprtsock.c: In function 'xs_flush_bvec':
   net/sunrpc/xprtsock.c:396:24: error: 'struct bio_vec' has no member named 'page'; did you mean 'bv_page'?
      flush_dcache_page(bv.page);
                           ^
   include/linux/mm.h:1258:48: note: in definition of macro 'page_address'
    #define page_address(page) lowmem_page_address(page)
                                                   ^~~~
>> net/sunrpc/xprtsock.c:396:3: note: in expansion of macro 'flush_dcache_page'
      flush_dcache_page(bv.page);
      ^~~~~~~~~~~~~~~~~

vim +/flush_dcache_page +396 net/sunrpc/xprtsock.c

   383	
   384	#if ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE
   385	static void
   386	xs_flush_bvec(const struct bio_vec *bvec, size_t count, size_t seek)
   387	{
   388		struct bvec_iter bi, __start = {
   389			.bi_size = count,
   390		};
   391		struct bio_vec bv;
   392	
   393		bvec_iter_advance(bvec, &__start, seek & PAGE_MASK);
   394	
   395		for_each_bvec(bv, bvec, bi, __start)
 > 396			flush_dcache_page(bv.page);
   397	}
   398	#else
   399	static inline void
   400	xs_flush_bvec(const struct bio_vec *bvec, size_t count, size_t seek)
   401	{
   402	}
   403	#endif
   404	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 12123 bytes --]