From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Rohit kumar <rohitkr@codeaurora.org>
Cc: dianders@chromium.org, andy.gross@linaro.org,
david.brown@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, plai@codeaurora.org,
bgoswami@codeaurora.org, srinivas.kandagatla@linaro.org,
linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: qcom: sdm845: Add ADSP reserve-memory nodes
Date: Thu, 3 Jan 2019 15:42:49 -0800 [thread overview]
Message-ID: <20190103234249.GH31596@builder> (raw)
In-Reply-To: <1545313174-13481-2-git-send-email-rohitkr@codeaurora.org>
On Thu 20 Dec 05:39 PST 2018, Rohit kumar wrote:
> Add memory nodes required for remoteproc q6v5_adsp pil.
>
This range doesn't match the documented memory map. I would prefer to
see a "Specify all PIL regions as defined in V10" or similar.
Regards,
Bjorn
> Signed-off-by: Rohit kumar <rohitkr@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 23a253b..c0a012f 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -88,6 +88,11 @@
> reg = <0 0x86200000 0 0x2d00000>;
> no-map;
> };
> +
> + pil_adsp_mem: memory@8b100000 {
> + reg = <0 0x8b100000 0 0x1a00000>;
> + no-map;
> + };
> };
>
> cpus {
> --
> Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
> is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
>
next prev parent reply other threads:[~2019-01-03 23:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 13:39 [PATCH 0/2] arm64: dts: qcom: sdm845: add support for ADSP PIL Rohit kumar
2018-12-20 13:39 ` [PATCH 1/2] arm64: dts: qcom: sdm845: Add ADSP reserve-memory nodes Rohit kumar
2019-01-03 23:42 ` Bjorn Andersson [this message]
2019-01-07 7:47 ` Rohit Kumar
2018-12-20 13:39 ` [PATCH 2/2] arm64: dts: qcom: sdm845: Add Q6V5 ADSP node Rohit kumar
2018-12-22 11:34 ` kbuild test robot
2018-12-22 11:34 ` kbuild test robot
2018-12-22 11:34 ` kbuild test robot
2019-01-03 23:50 ` Bjorn Andersson
2019-01-08 12:34 ` Rohit Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190103234249.GH31596@builder \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=bgoswami@codeaurora.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=plai@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=rohitkr@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.