From: "hch@lst.de" <hch@lst.de>
To: Huaisheng HS1 Ye <yehs1@lenovo.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
"hch@lst.de" <hch@lst.de>,
"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
"boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>,
"jgross@suse.com" <jgross@suse.com>,
"m.szyprowski@samsung.com" <m.szyprowski@samsung.com>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
NingTing Cheng <chengnt@lenovo.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
Huaisheng Ye <yehs2007@zoho.com>
Subject: Re: [PATCH] dma-mapping: remove unused attrs parameter to dma_common_get_sgtable
Date: Fri, 4 Jan 2019 08:26:51 +0100 [thread overview]
Message-ID: <20190104072651.GA14560@lst.de> (raw)
In-Reply-To: <HK2PR03MB44183AC87F67594E93F31E75928E0@HK2PR03MB4418.apcprd03.prod.outlook.com>
On Fri, Jan 04, 2019 at 01:45:26AM +0000, Huaisheng HS1 Ye wrote:
> From: Stefano Stabellini <sstabellini@kernel.org>
> Sent: Friday, January 04, 2019 1:55 AM
> > On Thu, 3 Jan 2019, Huaisheng Ye wrote:
> > > From: Huaisheng Ye <yehs1@lenovo.com>
> > >
> > > dma_common_get_sgtable has parameter attrs which is not used at all.
> > > Remove it.
> > >
> > > Signed-off-by: Huaisheng Ye <yehs1@lenovo.com>
> >
> > Acked-by: Stefano Stabellini <sstabellini@kernel.org>
> >
> > FYI the patch doesn't apply cleanly to master.
>
> Got it, I will rebase it to branch master and resend the patch later.
I think we can skip it. For the next merge window I plan to remove
the fallbacks for get_sgtable and mmap and instead wire everything up
explicitly. And to be a possible method instance it will have to match
the prototype and thus keep the unused argument.
next prev parent reply other threads:[~2019-01-04 7:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 1:45 [PATCH] dma-mapping: remove unused attrs parameter to dma_common_get_sgtable Huaisheng HS1 Ye
2019-01-04 1:45 ` Huaisheng HS1 Ye
2019-01-04 7:26 ` hch [this message]
2019-01-04 7:26 ` hch
-- strict thread matches above, loose matches on Subject: below --
2019-01-04 2:36 Huaisheng Ye via iommu
2019-01-04 2:36 ` Huaisheng Ye
2019-01-04 2:36 Huaisheng Ye
2019-01-04 1:45 Huaisheng HS1 Ye
2019-01-03 8:29 Huaisheng Ye
2019-01-03 8:29 Huaisheng Ye via iommu
2019-01-03 8:29 ` Huaisheng Ye
2019-01-03 17:54 ` Stefano Stabellini
2019-01-03 17:54 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190104072651.GA14560@lst.de \
--to=hch@lst.de \
--cc=boris.ostrovsky@oracle.com \
--cc=chengnt@lenovo.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=yehs1@lenovo.com \
--cc=yehs2007@zoho.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.