From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:50066 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725958AbfADLAe (ORCPT ); Fri, 4 Jan 2019 06:00:34 -0500 Date: Fri, 4 Jan 2019 12:00:33 +0100 From: Jan Kara To: Amir Goldstein Cc: Jan Kara , Matthew Bobrowski , linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH v4 00/15] fanotify: add support for more event types Message-ID: <20190104110033.GK22409@quack2.suse.cz> References: <20181202113826.32133-1-amir73il@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181202113826.32133-1-amir73il@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi, On Sun 02-12-18 13:38:11, Amir Goldstein wrote: > This is the 4th revision of patch series to add support for filesystem > change monitoring to fanotify. > It incorporates the changes you requested in review of v3 FAN_REPORT_FID > patches. > The complete work is available on fanotify_dirent branch [1] on my tree. > > The combined functionality of FAN_MARK_FILESYSTEM, FAN_REPORT_FID and > dirent modification events is demonstrated with a prototype of global > filesystem monitor based on inotify-tools [2]. > > In your review of v3 patched you only got as far as patch v3 9/13. > Because this patch marks the end of the FAN_REPORT_FID sub series, > I found it best to re-post the entire series with the changes you > requested thus far. For convenience of review, I pushed branches > fanotify_fid-v3 [3] and fanotify_fid-v4 [4] with the work you > reviewed so far and its re-worked version. > > One thing that we discussed and I did NOT do is move struct file_handle > to uapi headers. This got complicated due to existing definitions in > glibc header files and I realized we could do without it. > > I have added the vfs_get_fsid() helper as you requested, but since it > wasn't required by the patch set, I added it as two new cleanup patches > at the end of the FAN_REPORT_FID series, so you will be able to stage > the feature with or without the VFS change. So overall the series looks very good. I've had only some smaller comments / disagreements. So once we settle those please resend the series and I'll pick it up to my tree. Honza -- Jan Kara SUSE Labs, CR