From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3] cgroup_regression_test.sh ported to newlib
Date: Fri, 4 Jan 2019 13:25:35 +0100 [thread overview]
Message-ID: <20190104122535.GA31329@dell5510> (raw)
In-Reply-To: <9a580965-10d4-80d1-a0c6-23c502289ee7@arm.com>
Hi Cristian,
> > See diff bellow. I also added 4 commits related to this test,
> > one of them is fixing regression I added while changing your code
> > (I'm sorry).
> Everything's fine but in cgroup_regress_test_6_2.c you reverted to old API,
> while you previously told me not to:
> > +++ b/testcases/kernel/controllers/cgroup/cgroup_regress_test_6_2.c
> > @@ -0,0 +1,37 @@
> [snip]
> > +#include <sched.h>
> > +#include <stdlib.h>
> > +#include <unistd.h>
> > +#include "test.h"
> Please don't use legacy API. <<<<<<
> is that fine ?
I'm sorry I forget to tell you I reverted this, it was deliberate change.
Using TST_NO_DEFAULT_MAIN was wrong (it's usually used in LTP library only.
Also it's recommended to use SAFE_*() if possible.
I've sent patch to implement this for some C code [1], but it's failing (endless clone).
Kind regards,
Petr
[1] https://patchwork.ozlabs.org/patch/1020712/
next prev parent reply other threads:[~2019-01-04 12:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-21 18:25 [LTP] [PATCH v3] cgroup_regression_test.sh ported to newlib Cristian Marussi
2019-01-04 3:45 ` Petr Vorel
2019-01-04 10:21 ` Cristian Marussi
2019-01-04 12:25 ` Petr Vorel [this message]
2019-01-04 12:28 ` Cristian Marussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190104122535.GA31329@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.