From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Junio C Hamano <gitster@pobox.com>, Carlo Arenas <carenas@gmail.com>
Cc: Johannes Sixt <j6t@kdbg.org>, Max Kirillov <max@max630.net>,
Jeff King <peff@peff.net>,
Eric Sunshine <sunshine@sunshineco.com>,
git@vger.kernel.org
Subject: Re: [PATCH v2] test-lib: check Bash version for '-x' without using shell arrays
Date: Fri, 4 Jan 2019 13:38:19 +0100 [thread overview]
Message-ID: <20190104123819.GD4673@szeder.dev> (raw)
In-Reply-To: <xmqq5zv4fyuy.fsf@gitster-ct.c.googlers.com>
On Fri, Jan 04, 2019 at 03:25:57AM -0800, Junio C Hamano wrote:
> SZEDER Gábor <szeder.dev@gmail.com> writes:
>
> > On Thu, Jan 03, 2019 at 12:29:35PM -0800, Junio C Hamano wrote:
> >> Let's treat this as an independent and more urgent fix-up. I think
> >> it is sufficient to apply it to 2.20.x track, even though we could
> >> go back to 2.17.x and above.
> >>
> >> And then let's tentatively kick the "stress test" series out of
> >> 'pu', and have that series rebuilt on top of 'master' and this
> >> patch.
> >
> > I rebased my '--stress' patch series on top of
> > 'sg/test-bash-version-fix', and the result is the same as what's at
> > the tip of 'sg/stress-test' at 1d1416a34b.
>
> Yeah, sorry for not reporting what I did after pushing the
> integration result out. I ended up rebasing the stress series on
> top of the updated fix with eval myself.
No problem, it still saved me from writing a cover letter :)
Note that I didn't actually test either of these patches on NetBSD,
though both "Should Work". Carlo sent a Tested-by for v1; I hope
he'll be able to get around and test v2 as well.
next prev parent reply other threads:[~2019-01-04 12:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-01 23:19 [PATCH] test-lib: check Bash version for '-x' without using shell arrays SZEDER Gábor
2019-01-02 0:20 ` Johannes Sixt
2019-01-02 16:46 ` Junio C Hamano
2019-01-03 11:43 ` [PATCH v2] " SZEDER Gábor
2019-01-03 20:29 ` Junio C Hamano
2019-01-04 9:30 ` SZEDER Gábor
2019-01-04 11:25 ` Junio C Hamano
2019-01-04 12:38 ` SZEDER Gábor [this message]
2019-01-04 18:42 ` Carlo Arenas
2019-01-04 20:04 ` Junio C Hamano
2019-01-03 4:52 ` [PATCH] " Jeff King
2019-01-02 18:05 ` Eric Sunshine
2019-01-02 18:31 ` Carlo Arenas
2019-01-03 11:36 ` SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190104123819.GD4673@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=max@max630.net \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.