From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/wine: Add gettext dependency for host-wine only with NLS enabled
Date: Fri, 4 Jan 2019 13:42:38 +0100 [thread overview]
Message-ID: <20190104134238.484d60b2@windsurf> (raw)
In-Reply-To: <20190104114909.14166-1-vadim4j@gmail.com>
Hello,
On Fri, 4 Jan 2019 13:49:09 +0200, Vadim Kochan wrote:
> Checked that host-wine compiles ok without host-gettext, so no
> needs to specify this dependency.
>
> libgettextpo is required by tools/wrc (https://linux.die.net/man/1/wrc)
> which allows to convert windows resources also to *.po format, which is
> not needed if NLS is disabled.
>
> Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
> ---
> package/wine/wine.mk | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/package/wine/wine.mk b/package/wine/wine.mk
> index 78c8e6ab63..ef70b6276c 100644
> --- a/package/wine/wine.mk
> +++ b/package/wine/wine.mk
> @@ -307,8 +307,10 @@ WINE_CONF_OPTS += --without-zlib
> endif
>
> # host-gettext is essential for .po file support in host-wine wrc
> +ifeq ($(BR2_SYSTEM_ENABLE_NLS),y)
> HOST_WINE_DEPENDENCIES += host-gettext
> HOST_WINE_CONF_OPTS += --with-gettext --with-gettextpo
> +endif
It probably needs a "else" clause, to pass --without-gettext
--without-gettextpo.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-01-04 12:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 11:49 [Buildroot] [PATCH 1/1] package/wine: Add gettext dependency for host-wine only with NLS enabled Vadim Kochan
2019-01-04 12:42 ` Thomas Petazzoni [this message]
2019-01-04 13:58 ` Vadim Kochan
2019-01-04 14:01 ` Yann E. MORIN
2019-01-04 17:10 ` Vadim Kochan
2019-01-05 14:10 ` Thomas Petazzoni
2019-01-05 14:56 ` Vadim Kochan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190104134238.484d60b2@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.