From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=28AGc0HiJHfpxT8qHSz2y36U9i6yalY9MijZ4ERXzYM=; b=aNFU5utlUINNyEQvImB29CkGF8E3qxlMSTaJ13yBmaMmObnPopqBBWMM9I7tfF/WnHRgB8lKsD/ckQQNha6flNOIlG3hMc1dG5fSEUo9AvfxrRsFqBS4Mu/3ZYK3nFz+3qupbyzvIj58eau4v95gSJBUt52hymMnZ7xT3Nz8zac= From: Ido Schimmel Date: Fri, 4 Jan 2019 13:58:40 +0000 Message-ID: <20190104135837.GB11955@splinter> References: <20190103224702.21541-1-f.fainelli@gmail.com> In-Reply-To: <20190103224702.21541-1-f.fainelli@gmail.com> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Bridge] [PATCH net-next v2] Documentation: networking: Clarify switchdev devices behavior List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Florian Fainelli Cc: "andrew@lunn.ch" , "nikolay@cumulusnetworks.com" , "netdev@vger.kernel.org" , "roopa@cumulusnetworks.com" , "bridge@lists.linux-foundation.org" , "vivien.didelot@gmail.com" , Jiri Pirko , "davem@davemloft.net" On Thu, Jan 03, 2019 at 02:47:02PM -0800, Florian Fainelli wrote: > +A switchdev driver can also refuse to support dynamic toggling of the VL= AN > +filtering knob at runtime and require a destruction of the bridge device= (s) and > +a creation of new bridge device(s) with a different VLAN filtering value= to > +ensure VLAN awareness is pushed down to the HW. ... > +Similarly to VLAN filtering, if dynamic toggling of the IGMP snooping I think you meant to continue this sentence with something about vetoing the operation. Note that it is not currently possible as br_mc_disabled_update() returns void. Can be extended if needed. > --=20 > 2.17.1 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ido Schimmel Subject: Re: [PATCH net-next v2] Documentation: networking: Clarify switchdev devices behavior Date: Fri, 4 Jan 2019 13:58:40 +0000 Message-ID: <20190104135837.GB11955@splinter> References: <20190103224702.21541-1-f.fainelli@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "netdev@vger.kernel.org" , "davem@davemloft.net" , "andrew@lunn.ch" , Jiri Pirko , "vivien.didelot@gmail.com" , "nikolay@cumulusnetworks.com" , "roopa@cumulusnetworks.com" , "bridge@lists.linux-foundation.org" , "cphealy@gmail.com" To: Florian Fainelli Return-path: Received: from mail-eopbgr60053.outbound.protection.outlook.com ([40.107.6.53]:42720 "EHLO EUR04-DB3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726104AbfADN6q (ORCPT ); Fri, 4 Jan 2019 08:58:46 -0500 In-Reply-To: <20190103224702.21541-1-f.fainelli@gmail.com> Content-Language: en-US Content-ID: Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Jan 03, 2019 at 02:47:02PM -0800, Florian Fainelli wrote: > +A switchdev driver can also refuse to support dynamic toggling of the VL= AN > +filtering knob at runtime and require a destruction of the bridge device= (s) and > +a creation of new bridge device(s) with a different VLAN filtering value= to > +ensure VLAN awareness is pushed down to the HW. ... > +Similarly to VLAN filtering, if dynamic toggling of the IGMP snooping I think you meant to continue this sentence with something about vetoing the operation. Note that it is not currently possible as br_mc_disabled_update() returns void. Can be extended if needed. > --=20 > 2.17.1 >=20