From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony PERARD Subject: Re: [PATCH v7 09/18] xen: remove unnecessary code from dataplane/xen-block.c Date: Fri, 4 Jan 2019 15:56:15 +0000 Message-ID: <20190104155615.GD1508@perard.uk.xensource.com> References: <20181220171439.11159-1-paul.durrant@citrix.com> <20181220171439.11159-10-paul.durrant@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gfRpb-0003Zo-9q for xen-devel@lists.xenproject.org; Fri, 04 Jan 2019 15:56:19 +0000 Content-Disposition: inline In-Reply-To: <20181220171439.11159-10-paul.durrant@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Paul Durrant Cc: Kevin Wolf , Stefano Stabellini , qemu-block@nongnu.org, qemu-devel@nongnu.org, Max Reitz , Stefan Hajnoczi , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org T24gVGh1LCBEZWMgMjAsIDIwMTggYXQgMDU6MTQ6MzBQTSArMDAwMCwgUGF1bCBEdXJyYW50IHdy b3RlOgo+IE5vdCBhbGwgb2YgdGhlIGNvZGUgZHVwbGljYXRlZCBmcm9tIHhlbl9kaXNrLmMgaXMg cmVxdWlyZWQgYXMgdGhlIGJhc2lzIGZvcgo+IHRoZSBuZXcgZGF0YXBsYW5lIGltcGxlbWVudGF0 aW9uIHNvIHRoaXMgcGF0Y2ggcmVtb3ZlcyBleHRyYW5lb3VzIGNvZGUsCj4gYWxvbmcgd2l0aCB0 aGUgbGVnYWN5ICNpbmNsdWRlcyBhbmQgY2FsbHMgdG8gdGhlIGxlZ2FjeSB4ZW5fcHZfcHJpbnRm KCkKPiBmdW5jdGlvbi4gRXJyb3IgbWVzc2FnZXMgYXJlIGNoYW5nZWQgdG8gYmUgcmVwb3J0ZWQg dXNpbmcgZXJyb3JfcmVwb3J0KCkuCj4gCj4gTk9URTogVGhlIGNvZGUgaXMgc3RpbGwgbm90IHll dCBidWlsdC4gRnVydGhlciB0cmFuc2Zvcm1hdGlvbnMgd2lsbCBiZQo+ICAgICAgIHJlcXVpcmVk IHRvIG1ha2UgaXQgY29ycmVjdGx5IGludGVyZmFjZSB0byB0aGUgbmV3IFhlbkJ1cy9YZW5EZXZp Y2UKPiAgICAgICBmcmFtZXdvcmsuIFRoZXkgd2lsbCBiZSBkZWxpdmVyZWQgaW4gYSBzdWJzZXF1 ZW50IHBhdGNoLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFBhdWwgRHVycmFudCA8cGF1bC5kdXJyYW50 QGNpdHJpeC5jb20+CgpBY2tlZC1ieTogQW50aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNp dHJpeC5jb20+CgotLSAKQW50aG9ueSBQRVJBUkQKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxp c3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9s aXN0aW5mby94ZW4tZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44650) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gfRzd-0004q6-FB for qemu-devel@nongnu.org; Fri, 04 Jan 2019 11:06:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gfRza-0002bk-Aj for qemu-devel@nongnu.org; Fri, 04 Jan 2019 11:06:41 -0500 Date: Fri, 4 Jan 2019 15:56:15 +0000 From: Anthony PERARD Message-ID: <20190104155615.GD1508@perard.uk.xensource.com> References: <20181220171439.11159-1-paul.durrant@citrix.com> <20181220171439.11159-10-paul.durrant@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20181220171439.11159-10-paul.durrant@citrix.com> Subject: Re: [Qemu-devel] [PATCH v7 09/18] xen: remove unnecessary code from dataplane/xen-block.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Durrant Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, xen-devel@lists.xenproject.org, Stefano Stabellini , Stefan Hajnoczi , Kevin Wolf , Max Reitz On Thu, Dec 20, 2018 at 05:14:30PM +0000, Paul Durrant wrote: > Not all of the code duplicated from xen_disk.c is required as the basis for > the new dataplane implementation so this patch removes extraneous code, > along with the legacy #includes and calls to the legacy xen_pv_printf() > function. Error messages are changed to be reported using error_report(). > > NOTE: The code is still not yet built. Further transformations will be > required to make it correctly interface to the new XenBus/XenDevice > framework. They will be delivered in a subsequent patch. > > Signed-off-by: Paul Durrant Acked-by: Anthony PERARD -- Anthony PERARD