From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell Parker Subject: Re: [PATCH 1/1] conf/ucm: chtrt5650: Add UCM config for chtrt5650 Date: Fri, 4 Jan 2019 09:30:56 -0800 Message-ID: <20190104173056.GA9638@celes> References: <20181230053526.14989-1-russell.parker7@gmail.com> <1f9d849d-db6f-ae8b-5551-efdb1b13bdea@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1f9d849d-db6f-ae8b-5551-efdb1b13bdea@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Pierre-Louis Bossart Cc: alsa-devel@alsa-project.org, patch@alsa-project.org, evananderson@thelinuxman.us List-Id: alsa-devel@alsa-project.org On Wed, Jan 02, 2019 at 10:14:06AM -0600, Pierre-Louis Bossart wrote: > > On 12/29/18 11:35 PM, Russell Parker wrote: > > Add a UCM configuration for the rt5650 codec. Tested on > > a Samsung Chromebook 3. Adapted with minor modifications > > from GitHub user evan-a-a's gist: > > https://gist.github.com/evan-a-a/86b2a698708074530e2d0ee7c6498767 > > > > Signed-off-by: Russell Parker > > Interesting, thanks! > > IIRC rt5650 is a low-cost version of rt5645, the machine driver only has a > minor difference in the routing map and the controls are largely identical. > Could we maybe factor the common codec parts with the include mechanism, > similar to what was done for the SOC/platform driver settings? I'll take a stab at parsing out the common configuration this weekend. Seems like chtrt5645-mono-speaker-analog-mic can also be refactored to use the shared code. Any input on naming the shared directory? The existing shared configurations all seem to be from the same codec. Maybe a src/conf/ucm/codecs/rt5645-rt5650/ directory is in order.