From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93FB0C43387 for ; Mon, 7 Jan 2019 10:07:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 65A2D20854 for ; Mon, 7 Jan 2019 10:07:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546855646; bh=q/mHSHiOqx+qLUxtR+DGpBOw0nsfW8eJ6575faKLTtY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=usHPgyOitNZPRcwRD4vgnDDIdRPftMS6QYJN5cfZI4e/PGiqAL92qOvkkZtcnkDOo dxonO+2Ar5f8BJNQDx+DLeHIe5/hQmDDUUZeq5wbQpG78nkdKDFzA3S9UmIEs6A8+c s1PhgQJwzq6v2A2z6vWHwlW0T1Rw/8lLvQWoJ15k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726633AbfAGKH0 (ORCPT ); Mon, 7 Jan 2019 05:07:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:35418 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726453AbfAGKHZ (ORCPT ); Mon, 7 Jan 2019 05:07:25 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DD94F20854; Mon, 7 Jan 2019 10:07:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546855645; bh=q/mHSHiOqx+qLUxtR+DGpBOw0nsfW8eJ6575faKLTtY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f3y/FyT/Yq4PsyjbdaqFqAUjASNoGJ98uF1ArifxdgiEXYAmz9mI3DjNPKadqZu46 /eOglHQyDKSAdDmHazbbZaWC4pTWQIofuXZHknBKkURYP89OWIKSXV2rrxBIZvBn0y F9p9NTa2PuHUyGelfv9z/Jpathv48kgBiHvuuEps= Date: Mon, 7 Jan 2019 11:07:22 +0100 From: Greg Kroah-Hartman To: Amit Pundir Cc: Minchan Kim , stable Subject: Re: [for-4.9.y] Patch series "use up highorder free pages before OOM", v3. Message-ID: <20190107100722.GC1314@kroah.com> References: <20190107094852.GA31759@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.1 (2018-12-01) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Jan 07, 2019 at 03:25:42PM +0530, Amit Pundir wrote: > On Mon, 7 Jan 2019 at 15:18, Greg Kroah-Hartman > wrote: > > > > On Mon, Jan 07, 2019 at 03:10:35PM +0530, Amit Pundir wrote: > > > Hi Greg, > > > > > > Kindly review and consider following mm/OOM upstream fixes for stable 4.9.y. > > > > > > 88ed365ea227 ("mm: don't steal highatomic pageblock") > > > 04c8716f7b00 ("mm: try to exhaust highatomic reserve before the OOM") > > > 29fac03bef72 ("mm: make unreserve highatomic functions reliable") > > > > > > The original 4 patch series is archived here > > > https://lkml.org/lkml/2016/10/12/77 for review. > > > One of the patch from this series: > > > 4855e4a7f29d ("mm: prevent double decrease of nr_reserved_highatomic") > > > has already been picked up for 4.9.y and 4.4.y. > > > > > > I ran into these fixes in one of the msm-4.9(android) trees. > > > Cherry-picked and build tested on Linux 4.9.148 for > > > ARCH=arm/arm64 defconfig. > > > > > > Only the first patch from this series can be applied cleanly on > > > v4.4.y, while others fail to apply cleanly due to OOM rework done in > > > v4.7 release cycle, 0a0337e0d1d1 ("mm, oom: rework oom detection"). > > > Plus I don't see this series backported to v4.4 in any of the > > > msm-4.4(android) trees either. So I'm skipping it for v4.4.y. > > > > Can you get an ack from the mm developers that these really are viable > > for backporting to older kernel trees as they solve a real issue? > > I forgot to mention that marking the original series for stable > (v4.4+) was discussed as well, and was sort of NACked > https://lkml.org/lkml/2016/10/12/655 because no one else reported this > OOM behavior. And the only reason I submitted this series for v4.9 is > msm-4.9 Android trees which cherry-picked this whole series as is. I remember that thread, which is why I asked for explicit "yes this is good" for 4.9. Just because a crazy vendor dropped patches in their tree is not always a good reason to actually put them in everyone's tree. That vendor is liable for the fallout as-is, do not transfer that liability to upstream when they explicitly said "do not apply these"... thanks, greg k-h