From: Rajendra Nayak <rnayak@codeaurora.org>
To: andy.gross@linaro.org, robh@kernel.org, viresh.kumar@linaro.org,
sboyd@kernel.org, ulf.hansson@linaro.org,
collinsd@codeaurora.org, mka@chromium.org
Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, henryc.chen@mediatek.com,
Rajendra Nayak <rnayak@codeaurora.org>
Subject: [PATCH v9 09/10] soc: qcom: rpmpd: Use dev_pm_opp_of_get_level() helper
Date: Mon, 7 Jan 2019 15:39:58 +0530 [thread overview]
Message-ID: <20190107100959.14528-10-rnayak@codeaurora.org> (raw)
In-Reply-To: <20190107100959.14528-1-rnayak@codeaurora.org>
Get rid of the duplicate code across rpmpd and rpmhpd to read the
performance state value (opp-level) from Device tree and use the
dev_pm_opp_of_get_level() helper instead.
Suggested-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
---
drivers/soc/qcom/rpmhpd.c | 11 +----------
drivers/soc/qcom/rpmpd.c | 11 +----------
2 files changed, 2 insertions(+), 20 deletions(-)
diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c
index 521aa2a571bb..38c8a11c92c8 100644
--- a/drivers/soc/qcom/rpmhpd.c
+++ b/drivers/soc/qcom/rpmhpd.c
@@ -276,16 +276,7 @@ static int rpmhpd_set_performance_state(struct generic_pm_domain *domain,
static unsigned int rpmhpd_get_performance_state(struct generic_pm_domain *genpd,
struct dev_pm_opp *opp)
{
- struct device_node *np;
- unsigned int level = 0;
-
- np = dev_pm_opp_get_of_node(opp);
- if (of_property_read_u32(np, "opp-level", &level))
- pr_err("%s: missing 'opp-level' property\n", __func__);
-
- of_node_put(np);
-
- return level;
+ return dev_pm_opp_of_get_level(opp);
}
static int rpmhpd_update_level_mapping(struct rpmhpd *rpmhpd)
diff --git a/drivers/soc/qcom/rpmpd.c b/drivers/soc/qcom/rpmpd.c
index 1c6c5dec2667..68179e4bac3d 100644
--- a/drivers/soc/qcom/rpmpd.c
+++ b/drivers/soc/qcom/rpmpd.c
@@ -248,16 +248,7 @@ static int rpmpd_set_performance(struct generic_pm_domain *domain,
static unsigned int rpmpd_get_performance(struct generic_pm_domain *genpd,
struct dev_pm_opp *opp)
{
- struct device_node *np;
- unsigned int corner = 0;
-
- np = dev_pm_opp_get_of_node(opp);
- if (of_property_read_u32(np, "opp-level", &corner))
- pr_err("%s: missing 'opp-level' property\n", __func__);
-
- of_node_put(np);
-
- return corner;
+ return dev_pm_opp_of_get_level(opp);
}
static int rpmpd_probe(struct platform_device *pdev)
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2019-01-07 10:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 10:09 [PATCH v9 00/10] Add power domain driver for corners on msm8996/sdm845 Rajendra Nayak
2019-01-07 10:09 ` [PATCH v9 01/10] dt-bindings: opp: Introduce opp-level bindings Rajendra Nayak
2019-01-08 4:49 ` Viresh Kumar
2019-01-07 10:09 ` [PATCH v9 02/10] dt-bindings: power: Add qcom rpm power domain driver bindings Rajendra Nayak
2019-01-07 10:09 ` [PATCH v9 03/10] soc: qcom: rpmpd: Add a Power domain driver to model corners Rajendra Nayak
2019-01-07 10:09 ` [PATCH v9 04/10] soc: qcom: rpmpd: Add support for get/set performance state Rajendra Nayak
2019-01-07 10:09 ` [PATCH v9 05/10] arm64: dts: msm8996: Add rpmpd device node Rajendra Nayak
2019-01-07 10:09 ` [PATCH v9 06/10] soc: qcom: rpmhpd: Add RPMh power domain driver Rajendra Nayak
2019-01-07 10:09 ` [PATCH v9 07/10] arm64: dts: sdm845: Add rpmh powercontroller node Rajendra Nayak
2019-01-07 10:09 ` [PATCH v9 08/10] OPP: Add a dev_pm_opp_of_get_level() helper Rajendra Nayak
2019-01-08 4:54 ` Viresh Kumar
2019-01-07 10:09 ` Rajendra Nayak [this message]
2019-01-07 10:09 ` [PATCH v9 10/10] soc: qcom: rpmhpd: Mark mx as a parent for cx Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107100959.14528-10-rnayak@codeaurora.org \
--to=rnayak@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=collinsd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=henryc.chen@mediatek.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.