From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Aditya Pakki <pakki001@umn.edu>
Cc: Arushi Singhal <arushisinghal19971997@gmail.com>,
devel@driverdev.osuosl.org, kjlu@umn.edu,
linux-kernel@vger.kernel.org,
Mamta Shukla <mamtashukla555@gmail.com>,
Colin Ian King <colin.king@canonical.com>,
Nathan Chancellor <natechancellor@gmail.com>,
Quytelda Kahja <quytelda@tamalin.org>,
Wen Yang <wen.yang99@zte.com.cn>
Subject: Re: [PATCH] v2 staging: rtl8723bs: Clean up dead code
Date: Mon, 7 Jan 2019 11:16:49 +0100 [thread overview]
Message-ID: <20190107101649.GA2750@kroah.com> (raw)
In-Reply-To: <20190106162101.9176-1-pakki001@umn.edu>
On Sun, Jan 06, 2019 at 10:20:59AM -0600, Aditya Pakki wrote:
> rtw_wps_start() is part of dead code due to CONFIG_INTEL_WIDI.
> The fix removes the deadcode and replaces the function with NULL
> in rtw_private_handler. Identified as part of copy_from_user bug.
>
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
> ---
> .../staging/rtl8723bs/os_dep/ioctl_linux.c | 34 +------------------
> 1 file changed, 1 insertion(+), 33 deletions(-)
What changed from v1? Always put that below the --- line.
Please fix up and send v3.
thanks,
greg k-h
next prev parent reply other threads:[~2019-01-07 10:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-06 16:20 [PATCH] v2 staging: rtl8723bs: Clean up dead code Aditya Pakki
2019-01-07 10:16 ` Greg Kroah-Hartman [this message]
2019-01-07 13:00 ` Dan Carpenter
2019-01-07 12:57 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107101649.GA2750@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arushisinghal19971997@gmail.com \
--cc=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=mamtashukla555@gmail.com \
--cc=natechancellor@gmail.com \
--cc=pakki001@umn.edu \
--cc=quytelda@tamalin.org \
--cc=wen.yang99@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.