All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: m.balaji@intel.com
Cc: linux-usb@vger.kernel.org, mathias.nyman@linux.intel.com,
	hdegoede@redhat.com, M@linux.intel.com
Subject: [V2] roles: Fix for Enabling USB ROLE SWITCH QUIRK on INTEL_SUNRISEPOINT_LP_XHCI
Date: Mon, 7 Jan 2019 13:36:32 +0200	[thread overview]
Message-ID: <20190107113632.GA9543@kuha.fi.intel.com> (raw)

On Tue, Jan 08, 2019 at 05:04:20AM -0500, m.balaji@intel.com wrote:
> From: M, Balaji <m.balaji@intel.com>
> 
> This fix enables USB role feature on intel commercial nuc
> platform which is based on Kabylake chipset.
> 
> Signed-off-by: M, Balaji <m.balaji@intel.com>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>

OK by me:

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

Do not send an other version where you add just that tag! Mathias, as
the maintainer, will take care of adding the tag to the commit.

> ---
>  Changes from v1: Added Reviewed-by
>  drivers/usb/host/xhci-pci.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index a9ec7051f286..c2fe218e051f 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
> @@ -194,6 +194,7 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
>  		xhci->quirks |= XHCI_SSIC_PORT_UNUSED;
>  	if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
>  	    (pdev->device == PCI_DEVICE_ID_INTEL_CHERRYVIEW_XHCI ||
> +	     pdev->device == PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_XHCI ||
>  	     pdev->device == PCI_DEVICE_ID_INTEL_APL_XHCI))
>  		xhci->quirks |= XHCI_INTEL_USB_ROLE_SW;
>  	if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
> -- 
> 2.17.1

thanks,

             reply	other threads:[~2019-01-07 11:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-07 11:36 Heikki Krogerus [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-01-08 10:04 [V2] roles: Fix for Enabling USB ROLE SWITCH QUIRK on INTEL_SUNRISEPOINT_LP_XHCI m.balaji
2019-01-07 16:15 Greg KH
2019-01-07 14:58 m.balaji
2019-01-07 10:49 Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190107113632.GA9543@kuha.fi.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=M@linux.intel.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=m.balaji@intel.com \
    --cc=mathias.nyman@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.