From: Dan Carpenter <dan.carpenter@oracle.com>
To: David Binderman <dcb314@hotmail.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: linux-5.0-rc1/drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c:412]: (style) Expression is always false
Date: Mon, 7 Jan 2019 16:08:03 +0300 [thread overview]
Message-ID: <20190107130802.GE3200@kadam> (raw)
In-Reply-To: <DB7PR08MB3801DE2E52BE7BF2E0D7D0129C890@DB7PR08MB3801.eurprd08.prod.outlook.com>
On Mon, Jan 07, 2019 at 11:40:08AM +0000, David Binderman wrote:
>
> Hello there,
>
> linux-5.0-rc1/drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c:412]: (style) Expression is always false because 'else if' condition matches previous condition at line 410.
>
> Source code is
>
> else if (pRaInfo->HighestRate > 0x0b)
> pRaInfo->PTModeSS = 2;
> else if (pRaInfo->HighestRate > 0x0b)
> pRaInfo->PTModeSS = 1;
>
That's true, but that's how to the code was originally when it was
committed 5 years ago so it's hard to tell what the fix should be...
regards,
dan carpenter
prev parent reply other threads:[~2019-01-07 13:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <DB7PR08MB3801DE2E52BE7BF2E0D7D0129C890@DB7PR08MB3801.eurprd08.prod.outlook.com>
2019-01-07 12:27 ` linux-5.0-rc1/drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c:412]: (style) Expression is always false gregkh
2019-01-07 13:08 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107130802.GE3200@kadam \
--to=dan.carpenter@oracle.com \
--cc=dcb314@hotmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.