From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] lib/tst_test.c: Restrict that tst_brk() only works with TBROK/TCONF
Date: Mon, 7 Jan 2019 14:30:56 +0100 [thread overview]
Message-ID: <20190107133056.GA15221@rei.lan> (raw)
In-Reply-To: <5C10B56B.9030809@cn.fujitsu.com>
Hi!
> > Also I'm not sure if we want to convert TFAIL to TWARN inside of test
> > cleanup. And even if we wanted that change it should most likely go in
> > in a separate patch.
> Why do we need to convert TBROK to TWARN in test cleanup? Your fix
> patch(commit 6440c5d)
> has avoided the Infinite loop in test cleanup, so can we just keep the
> actual result by removing
> the existed conversion?
That is just to be backward compatible with the conventions we used to
have before we allowed for SAFE_MACROS() to be used in cleanups. Before
that most of the tests were coded so that failure in cleanup produced a
warning.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2019-01-07 13:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 12:55 [LTP] [PATCH 1/2] lib: Introduce tst_strttype() Xiao Yang
2018-11-08 12:55 ` [LTP] [PATCH 2/2] lib/tst_test.c: Restrict that tst_brk() only works with TBROK/TCONF Xiao Yang
2018-11-08 17:53 ` Jan Stancek
2018-11-09 2:46 ` Xiao Yang
2018-11-09 3:12 ` Xiao Yang
2018-11-09 7:54 ` Jan Stancek
2018-11-09 8:17 ` Xiao Yang
2018-11-09 17:52 ` Jan Stancek
2018-11-12 2:29 ` Xiao Yang
2018-12-11 15:17 ` Cyril Hrubis
2018-12-12 7:14 ` Xiao Yang
2019-01-07 13:30 ` Cyril Hrubis [this message]
2018-12-13 8:35 ` [LTP] [PATCH v3 1/3] lib: Introduce tst_strttype() Xiao Yang
2018-12-13 8:35 ` [LTP] [PATCH v3 2/3] lib/tst_test.c: Update result counters when calling tst_brk() Xiao Yang
2019-01-07 15:06 ` Cyril Hrubis
2019-01-07 17:39 ` Jan Stancek
2019-01-07 18:29 ` Cyril Hrubis
2019-01-08 13:11 ` Cyril Hrubis
2019-01-08 9:08 ` Xiao Yang
2018-12-13 8:36 ` [LTP] [PATCH v3 3/3] lib/tst_test.c: Convert TFAIL to TWARN in test cleanup Xiao Yang
2019-01-07 13:34 ` Cyril Hrubis
2019-01-07 14:28 ` Jan Stancek
2018-11-09 7:06 ` [LTP] [PATCH v2 1/2] lib: Introduce tst_strttype() Xiao Yang
2018-11-09 7:06 ` [LTP] [PATCH v2 2/2] lib/tst_test.c: Update result counters when calling tst_brk() Xiao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107133056.GA15221@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.