From: Luca Boccassi <bluca@debian.org>
To: dev@dpdk.org
Cc: bruce.richardson@intel.com, gavin.hu@arm.com,
viktorin@rehivetech.com, jerinj@marvell.com,
Luca Boccassi <bluca@debian.org>,
stable@dpdk.org
Subject: [PATCH v3] build: use generic march on arm64 when using 'default' machine
Date: Mon, 7 Jan 2019 14:11:30 +0000 [thread overview]
Message-ID: <20190107141130.24360-1-bluca@debian.org> (raw)
In-Reply-To: <20181224125627.25690-1-bluca@debian.org>
When building for generic distribution we need a stable baseline
architecture, or depending on the build worker the result will vary.
Force the default flags if the user explicitly sets machine=default
at configuration time.
Fixes: b1d48c41189a ("build: support ARM with meson")
Cc: stable@dpdk.org
Signed-off-by: Luca Boccassi <bluca@debian.org>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
v2: fix typo in commit message, remove variable used only once
v3: put back temporary variable, as "machine" gets overwritten
by the function and loses the original value before we need
it.
config/arm/meson.build | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/config/arm/meson.build b/config/arm/meson.build
index dae55d6b2..614139534 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -6,6 +6,7 @@
march_opt = '-march=@0@'.format(machine)
arm_force_native_march = false
+arm_force_default_march = (machine == 'default')
machine_args_generic = [
['default', ['-march=armv8-a+crc+crypto']],
@@ -105,7 +106,11 @@ else
cmd_generic = ['generic', '', '', 'default', '']
cmd_output = cmd_generic # Set generic by default
machine_args = [] # Clear previous machine args
- if not meson.is_cross_build()
+ if arm_force_default_march and not meson.is_cross_build()
+ machine = impl_generic
+ cmd_output = cmd_generic
+ impl_pn = 'default'
+ elif not meson.is_cross_build()
# The script returns ['Implementer', 'Variant', 'Architecture',
# 'Primary Part number', 'Revision']
detect_vendor = find_program(join_paths(
--
2.20.1
next prev parent reply other threads:[~2019-01-07 14:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-24 12:56 [PATCH] build: use generic march on arm64 when using 'default' machine Luca Boccassi
2019-01-07 12:24 ` Bruce Richardson
2019-01-07 13:40 ` Luca Boccassi
2019-01-07 13:45 ` Luca Boccassi
2019-01-07 13:39 ` [PATCH v2] " Luca Boccassi
2019-01-07 14:11 ` Luca Boccassi [this message]
2019-01-11 10:45 ` [PATCH v3] " Luca Boccassi
2019-01-14 8:09 ` [EXT] " Jerin Jacob Kollanukkaran
2019-01-14 9:58 ` Luca Boccassi
2019-01-14 10:35 ` Jerin Jacob Kollanukkaran
2019-01-14 11:07 ` Luca Boccassi
2019-02-27 12:15 ` Luca Boccassi
2019-03-20 5:01 ` Pavan Nikhilesh Bhagavatula
2019-03-20 13:18 ` Luca Boccassi
2019-03-20 13:18 ` [PATCH v4] " luca.boccassi
2019-04-17 20:27 ` [dpdk-dev] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107141130.24360-1-bluca@debian.org \
--to=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gavin.hu@arm.com \
--cc=jerinj@marvell.com \
--cc=stable@dpdk.org \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.