Re: [igt-dev] [PATCH i-g-t] lib/igt_edid_template: Fix parenthesis for vertical pulse coding

From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cc: Petri Latvala <petri.latvala@intel.com>,
	igt-dev@lists.freedesktop.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [igt-dev] [PATCH i-g-t] lib/igt_edid_template: Fix parenthesis for vertical pulse coding
Date: Mon, 7 Jan 2019 16:39:50 +0200	[thread overview]
Message-ID: <20190107143950.GP20097@intel.com> (raw)
In-Reply-To: <20190103165448.23748-1-paul.kocialkowski@bootlin.com>

On Thu, Jan 03, 2019 at 05:54:48PM +0100, Paul Kocialkowski wrote:
> Add missing parenthesis in the macro coding the vertical pulse high
> bits. Without them, the shift takes precedence over the logical and
> operation, which is not how these bits should be coded according to
> the spec.
> 
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  lib/igt_edid_template.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/igt_edid_template.h b/lib/igt_edid_template.h
> index de421e080a88..8dbd19caea4c 100644
> --- a/lib/igt_edid_template.h
> +++ b/lib/igt_edid_template.h
> @@ -8,7 +8,7 @@
>  #define op(ho, hp, vo, vp) ((ho) & 0xff), ((hp) & 0xff), \
>  		(((vo) & 0xf) << 4) | ((vp) & 0xf), \
>  		(((ho) & 0x300) >> 2) | (((hp) & 0x300) >> 4) \
> -		| (((vo) & 0x30) >> 2) | ((vp) & 0x30 >> 4)
> +		| (((vo) & 0x30) >> 2) | (((vp) & 0x30) >> 4)
>  
>  static unsigned char EDID_NAME[EDID_LENGTH] = {
>  	0x00, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0x00, /* header */
> -- 
> 2.20.1

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev