From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johan Hovold Subject: Re: [PATCH RFC 4/5] usb: cdc-acm: Enable serdev support Date: Mon, 7 Jan 2019 16:02:38 +0100 Message-ID: <20190107150238.GB14782@localhost> References: <20190104112131.14451-1-afaerber@suse.de> <20190104112131.14451-5-afaerber@suse.de> <1546868906.3037.37.camel@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <1546868906.3037.37.camel@suse.com> Sender: linux-kernel-owner@vger.kernel.org To: Oliver Neukum Cc: Andreas =?iso-8859-1?Q?F=E4rber?= , linux-lpwan@lists.infradead.org, linux-serial@vger.kernel.org, Johan Hovold , Rob Herring , Greg Kroah-Hartman , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org List-Id: linux-serial@vger.kernel.org On Mon, Jan 07, 2019 at 02:48:26PM +0100, Oliver Neukum wrote: > On Fr, 2019-01-04 at 12:21 +0100, Andreas Färber wrote: > > Switch from tty_port_register_device() to tty_port_register_device_serdev() > > and from tty_unregister_device() to tty_port_unregister_device(). > > > > On removal of a serdev driver sometimes count mismatch warnings were seen: > > > > ttyACM ttyACM0: tty_hangup: tty->count(1) != (#fd's(0) + #kopen's(0)) > > ttyACM ttyACM0: tty_port_close_start: tty->count = 1 port count = 0 > > > > Note: The serdev drivers appear to probe asynchronously as soon as they > > are registered. Should the USB quirks in probe be moved before registration? > > No noticeable difference for the devices at hand. > > That is quite drastic a change. > Johan, how complete in terms of features is serdev? serdev doesn't support hangups yet, and that's precisely why it's not enabled for hotpluggable buses. That would need to be fixed before accepting something like this. Johan From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [RFC,4/5] usb: cdc-acm: Enable serdev support From: Johan Hovold Message-Id: <20190107150238.GB14782@localhost> Date: Mon, 7 Jan 2019 16:02:38 +0100 To: Oliver Neukum Cc: Andreas =?iso-8859-1?Q?F=E4rber?= , linux-lpwan@lists.infradead.org, linux-serial@vger.kernel.org, Johan Hovold , Rob Herring , Greg Kroah-Hartman , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org List-ID: T24gTW9uLCBKYW4gMDcsIDIwMTkgYXQgMDI6NDg6MjZQTSArMDEwMCwgT2xpdmVyIE5ldWt1bSB3 cm90ZToKPiBPbiBGciwgMjAxOS0wMS0wNCBhdCAxMjoyMSArMDEwMCwgQW5kcmVhcyBGw6RyYmVy ICB3cm90ZToKPiA+IFN3aXRjaCBmcm9tIHR0eV9wb3J0X3JlZ2lzdGVyX2RldmljZSgpIHRvIHR0 eV9wb3J0X3JlZ2lzdGVyX2RldmljZV9zZXJkZXYoKQo+ID4gYW5kIGZyb20gdHR5X3VucmVnaXN0 ZXJfZGV2aWNlKCkgdG8gdHR5X3BvcnRfdW5yZWdpc3Rlcl9kZXZpY2UoKS4KPiA+IAo+ID4gT24g cmVtb3ZhbCBvZiBhIHNlcmRldiBkcml2ZXIgc29tZXRpbWVzIGNvdW50IG1pc21hdGNoIHdhcm5p bmdzIHdlcmUgc2VlbjoKPiA+IAo+ID4gICB0dHlBQ00gdHR5QUNNMDogdHR5X2hhbmd1cDogdHR5 LT5jb3VudCgxKSAhPSAoI2ZkJ3MoMCkgKyAja29wZW4ncygwKSkKPiA+ICAgdHR5QUNNIHR0eUFD TTA6IHR0eV9wb3J0X2Nsb3NlX3N0YXJ0OiB0dHktPmNvdW50ID0gMSBwb3J0IGNvdW50ID0gMAo+ ID4gCj4gPiBOb3RlOiBUaGUgc2VyZGV2IGRyaXZlcnMgYXBwZWFyIHRvIHByb2JlIGFzeW5jaHJv bm91c2x5IGFzIHNvb24gYXMgdGhleQo+ID4gYXJlIHJlZ2lzdGVyZWQuIFNob3VsZCB0aGUgVVNC IHF1aXJrcyBpbiBwcm9iZSBiZSBtb3ZlZCBiZWZvcmUgcmVnaXN0cmF0aW9uPwo+ID4gTm8gbm90 aWNlYWJsZSBkaWZmZXJlbmNlIGZvciB0aGUgZGV2aWNlcyBhdCBoYW5kLgo+IAo+IFRoYXQgaXMg cXVpdGUgZHJhc3RpYyBhIGNoYW5nZS4KPiBKb2hhbiwgaG93IGNvbXBsZXRlIGluIHRlcm1zIG9m IGZlYXR1cmVzIGlzIHNlcmRldj8KCnNlcmRldiBkb2Vzbid0IHN1cHBvcnQgaGFuZ3VwcyB5ZXQs IGFuZCB0aGF0J3MgcHJlY2lzZWx5IHdoeSBpdCdzIG5vdAplbmFibGVkIGZvciBob3RwbHVnZ2Fi bGUgYnVzZXMuIFRoYXQgd291bGQgbmVlZCB0byBiZSBmaXhlZCBiZWZvcmUKYWNjZXB0aW5nIHNv bWV0aGluZyBsaWtlIHRoaXMuCgpKb2hhbgo=