From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CADFEC43387 for ; Mon, 7 Jan 2019 15:28:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9A6E1206C0 for ; Mon, 7 Jan 2019 15:28:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546874917; bh=RcixJq78h0C952Zgsn01+myiP+SUgsh5msjaZxrUJm4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=KCLjv6zJalPsHa7YiL1/n8VfoBcui8EtPA80ZwS9bk+iI1P6PGOiwCAQQOV8QcZY1 /V9Y25WCwvhWh7Z11W8B8I6t+JPvLsSdroHxOO61AYgLo/TM++0QT8vyxpl8fykeJB UwzmdIzsr5fAXdTS6kBcBgY/c+Id79E5XP+RYDoo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729855AbfAGP2h (ORCPT ); Mon, 7 Jan 2019 10:28:37 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:37486 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729808AbfAGP2g (ORCPT ); Mon, 7 Jan 2019 10:28:36 -0500 Received: by mail-lj1-f193.google.com with SMTP id t18-v6so675277ljd.4; Mon, 07 Jan 2019 07:28:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=aWgsobAhrek/X2lv+z2iwZQ0pv5cj7NcHN3lmCT1VaY=; b=k+IjXNorJBKjNh1L4Eu1C/P7UeKcE1Y1hYWYhkY6AMrORQC17sowJg4S474M7jjmI5 PLla+zTHuw0WZxA6PBaR8wpS/wbnajkbsU7xQ3Ngi6gpmuCRC9TKQgmwUF2dHH9YGEBA 1YXsGl1aZJP3v8ASpoN0VJ/jOk26n8znPBj3qTXbfPWHlop8TIll0DdXaeWNpqatKqXH MgrUzY8rLq8UDm1rFSOYoYmjzc78JqEVs/MgjHcw4XOCVk2aqVo7phXoUkdvD5bPdMDa vbLb1K+HJra0ienW0DtktcTxWjszuLXvxZRXKtab48WRDgBeTwUNbGXctTXYHEICXIN8 P4tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=aWgsobAhrek/X2lv+z2iwZQ0pv5cj7NcHN3lmCT1VaY=; b=iZ7SHjtYAzK7FGxMO14zVBVu7DtDLKuI263Pv9/SeHyIn6J8HfPVLo0Wvzexgnr8XA HHBTb1mlGrGTVubtYI2ZqphsWShoGWsbMVX8N5iMXeX2h6EpsAVYV0N3UOAtmsAhTJET wyNWFgYFQAQTG26TlxP5oH+rTWmDsGFk2ReyEV92h8a7rH/mVj5efMynAA+G3G30JiHW z+11f0o3PkepB8yZ9HY0EmbEujFq1aVMU4aVkmKHpssxeI1u8OVkbSoXGEYiRlsG/AEC gB5XbOKgoyW/OHEe4mwi4hzUe81xHimuTS+BW+fXz7qAgYjnmT5dzWFOENj+9+XR4qo6 KqGQ== X-Gm-Message-State: AJcUukeFgqxhA5beb9ez0+v3WQlwK8Sxv5OuLSpOFqKOGHIfZE/b50zB LQeKVbX+XH3H5fkDYjmBCNs= X-Google-Smtp-Source: ALg8bN6gqCHucZ0GB6CO/t9fGUK+uCdHzcIi4JGUrbgJCXeYKAWVnjYzaCnPRkX1wZKfbUIIPJetTA== X-Received: by 2002:a2e:94ce:: with SMTP id r14-v6mr34162556ljh.34.1546874914004; Mon, 07 Jan 2019 07:28:34 -0800 (PST) Received: from xi.terra (c-74bee655.07-184-6d6c6d4.bbcust.telenor.se. [85.230.190.116]) by smtp.gmail.com with ESMTPSA id a62sm12756190lfa.37.2019.01.07.07.28.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Jan 2019 07:28:33 -0800 (PST) Received: from johan by xi.terra with local (Exim 4.91) (envelope-from ) id 1ggWpO-0003VN-Ir; Mon, 07 Jan 2019 16:28:34 +0100 Date: Mon, 7 Jan 2019 16:28:34 +0100 From: Johan Hovold To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Rob Herring , linux-lpwan@lists.infradead.org, linux-serial , Linux USB List , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , Johan Hovold , "David S. Miller" , Oliver Neukum , Greg Kroah-Hartman , netdev , linux-clk Subject: Re: [RFC lora-next 5/5] HACK: net: lora: sx130x: Add PicoCell gateway shim for cdc-acm Message-ID: <20190107152834.GC14782@localhost> References: <20190104112131.14451-1-afaerber@suse.de> <20190104112131.14451-6-afaerber@suse.de> <9d97fec5-31b0-8717-cd10-de4f36d1cf05@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9d97fec5-31b0-8717-cd10-de4f36d1cf05@suse.de> User-Agent: Mutt/1.11.1 (2018-12-01) Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Sat, Jan 05, 2019 at 12:43:48AM +0100, Andreas Färber wrote: > Hi Rob, > > Am 04.01.19 um 18:07 schrieb Rob Herring: > > On Fri, Jan 4, 2019 at 5:21 AM Andreas Färber wrote: > >> > >> Ignore our device in cdc-acm probing and add a new driver for it, > >> dispatching to cdc-acm for the actual implementation. > >> > >> WARNING: It is likely that this VID/PID is in use for unrelated devices. > >> Only the Product string hints what this really is in current v0.2.1. > >> Previous code v0.2.0 was using a Semtech VID/PID, but no card shipping > >> with such firmware is known to me. > >> > >> While this may seem unorthodox, no internals of the driver are accessed, > >> just the set of driver callbacks is duplicated as shim. > >> > >> Use this shim construct to fake DT nodes for serdev on probe. > >> For testing purposes these nodes do not have a parent yet. > >> This results in two "Error -2 creating of_node link" warnings on probe. > > > > It looks like the DT is pretty static. Rather than creating the nodes > > at run-time, can't you create a dts file and build that into your > > module. > > Heh, if that were the only issue with this patch... ;) My thoughts exactly. ;) This clearly is too much of a hack, but maintaining serdev compatible information in the corresponding tty drivers is probably what we'll want to do. When the tty driver binds and registers its ports with tty core, we can could match again on the USB descriptors, but since the device has already been matched, we can just pass the equivalent of a compatible string, or more generally dt-fragment, instead. Without having had time to look into it myself yet, this sounds like something we should be using the new software nodes for (software generated fw nodes). That way, we don't depend on CONFIG_OF either. Johan From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [RFC,lora-next,5/5] HACK: net: lora: sx130x: Add PicoCell gateway shim for cdc-acm From: Johan Hovold Message-Id: <20190107152834.GC14782@localhost> Date: Mon, 7 Jan 2019 16:28:34 +0100 To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Rob Herring , linux-lpwan@lists.infradead.org, linux-serial , Linux USB List , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , Johan Hovold , "David S. Miller" , Oliver Neukum , Greg Kroah-Hartman , netdev , linux-clk List-ID: T24gU2F0LCBKYW4gMDUsIDIwMTkgYXQgMTI6NDM6NDhBTSArMDEwMCwgQW5kcmVhcyBGw6RyYmVy IHdyb3RlOgo+IEhpIFJvYiwKPiAKPiBBbSAwNC4wMS4xOSB1bSAxODowNyBzY2hyaWViIFJvYiBI ZXJyaW5nOgo+ID4gT24gRnJpLCBKYW4gNCwgMjAxOSBhdCA1OjIxIEFNIEFuZHJlYXMgRsOkcmJl ciA8YWZhZXJiZXJAc3VzZS5kZT4gd3JvdGU6Cj4gPj4KPiA+PiBJZ25vcmUgb3VyIGRldmljZSBp biBjZGMtYWNtIHByb2JpbmcgYW5kIGFkZCBhIG5ldyBkcml2ZXIgZm9yIGl0LAo+ID4+IGRpc3Bh dGNoaW5nIHRvIGNkYy1hY20gZm9yIHRoZSBhY3R1YWwgaW1wbGVtZW50YXRpb24uCj4gPj4KPiA+ PiBXQVJOSU5HOiBJdCBpcyBsaWtlbHkgdGhhdCB0aGlzIFZJRC9QSUQgaXMgaW4gdXNlIGZvciB1 bnJlbGF0ZWQgZGV2aWNlcy4KPiA+PiBPbmx5IHRoZSBQcm9kdWN0IHN0cmluZyBoaW50cyB3aGF0 IHRoaXMgcmVhbGx5IGlzIGluIGN1cnJlbnQgdjAuMi4xLgo+ID4+IFByZXZpb3VzIGNvZGUgdjAu Mi4wIHdhcyB1c2luZyBhIFNlbXRlY2ggVklEL1BJRCwgYnV0IG5vIGNhcmQgc2hpcHBpbmcKPiA+ PiB3aXRoIHN1Y2ggZmlybXdhcmUgaXMga25vd24gdG8gbWUuCj4gPj4KPiA+PiBXaGlsZSB0aGlz IG1heSBzZWVtIHVub3J0aG9kb3gsIG5vIGludGVybmFscyBvZiB0aGUgZHJpdmVyIGFyZSBhY2Nl c3NlZCwKPiA+PiBqdXN0IHRoZSBzZXQgb2YgZHJpdmVyIGNhbGxiYWNrcyBpcyBkdXBsaWNhdGVk IGFzIHNoaW0uCj4gPj4KPiA+PiBVc2UgdGhpcyBzaGltIGNvbnN0cnVjdCB0byBmYWtlIERUIG5v ZGVzIGZvciBzZXJkZXYgb24gcHJvYmUuCj4gPj4gRm9yIHRlc3RpbmcgcHVycG9zZXMgdGhlc2Ug bm9kZXMgZG8gbm90IGhhdmUgYSBwYXJlbnQgeWV0Lgo+ID4+IFRoaXMgcmVzdWx0cyBpbiB0d28g IkVycm9yIC0yIGNyZWF0aW5nIG9mX25vZGUgbGluayIgd2FybmluZ3Mgb24gcHJvYmUuCj4gPiAK PiA+IEl0IGxvb2tzIGxpa2UgdGhlIERUIGlzIHByZXR0eSBzdGF0aWMuIFJhdGhlciB0aGFuIGNy ZWF0aW5nIHRoZSBub2Rlcwo+ID4gYXQgcnVuLXRpbWUsIGNhbid0IHlvdSBjcmVhdGUgYSBkdHMg ZmlsZSBhbmQgYnVpbGQgdGhhdCBpbnRvIHlvdXIKPiA+IG1vZHVsZS4KPiAKPiBIZWgsIGlmIHRo YXQgd2VyZSB0aGUgb25seSBpc3N1ZSB3aXRoIHRoaXMgcGF0Y2guLi4gOykKCk15IHRob3VnaHRz IGV4YWN0bHkuIDspCgpUaGlzIGNsZWFybHkgaXMgdG9vIG11Y2ggb2YgYSBoYWNrLCBidXQgbWFp bnRhaW5pbmcgc2VyZGV2IGNvbXBhdGlibGUKaW5mb3JtYXRpb24gaW4gdGhlIGNvcnJlc3BvbmRp bmcgdHR5IGRyaXZlcnMgaXMgcHJvYmFibHkgd2hhdCB3ZSdsbCB3YW50CnRvIGRvLgoKV2hlbiB0 aGUgdHR5IGRyaXZlciBiaW5kcyBhbmQgcmVnaXN0ZXJzIGl0cyBwb3J0cyB3aXRoIHR0eSBjb3Jl LCB3ZSBjYW4KY291bGQgbWF0Y2ggYWdhaW4gb24gdGhlIFVTQiBkZXNjcmlwdG9ycywgYnV0IHNp bmNlIHRoZSBkZXZpY2UgaGFzCmFscmVhZHkgYmVlbiBtYXRjaGVkLCB3ZSBjYW4ganVzdCBwYXNz IHRoZSBlcXVpdmFsZW50IG9mIGEgY29tcGF0aWJsZQpzdHJpbmcsIG9yIG1vcmUgZ2VuZXJhbGx5 IGR0LWZyYWdtZW50LCBpbnN0ZWFkLgoKV2l0aG91dCBoYXZpbmcgaGFkIHRpbWUgdG8gbG9vayBp bnRvIGl0IG15c2VsZiB5ZXQsIHRoaXMgc291bmRzIGxpa2UKc29tZXRoaW5nIHdlIHNob3VsZCBi ZSB1c2luZyB0aGUgbmV3IHNvZnR3YXJlIG5vZGVzIGZvciAoc29mdHdhcmUKZ2VuZXJhdGVkIGZ3 IG5vZGVzKS4gVGhhdCB3YXksIHdlIGRvbid0IGRlcGVuZCBvbiBDT05GSUdfT0YgZWl0aGVyLgoK Sm9oYW4K