Re: [PATCH v2 2/2] x86/dom0: add verbose mode and print memory allocation stats

From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
	Julien Grall <julien.grall@arm.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 2/2] x86/dom0: add verbose mode and print memory allocation stats
Date: Mon, 7 Jan 2019 16:35:56 +0100	[thread overview]
Message-ID: <20190107153556.jeeir4dbsdiruwnv@mac> (raw)
In-Reply-To: <5C332392020000780020ABC9@prv1-mh.provo.novell.com>

On Mon, Jan 07, 2019 at 03:01:54AM -0700, Jan Beulich wrote:
> >>> On 28.12.18 at 12:18, <roger.pau@citrix.com> wrote:
> > --- a/xen/arch/x86/hvm/dom0_build.c
> > +++ b/xen/arch/x86/hvm/dom0_build.c
> > @@ -60,6 +60,18 @@ static struct acpi_madt_interrupt_override __initdata *intsrcovr;
> >  static unsigned int __initdata acpi_nmi_sources;
> >  static struct acpi_madt_nmi_source __initdata *nmisrc;
> >  
> > +static unsigned int __initdata order_stats[MAX_ORDER + 1] = { };
> 
> Pointless initializer.
> 
> > +static void __init print_order_stats(void)
> > +{
> > +    unsigned int i;
> > +
> > +    printk("Memory allocation stats:\n");
> 
> I think this wants prefixing with "Dom0".

I will use Dom%u and d->domain_id.

> > +    for ( i = 0; i < ARRAY_SIZE(order_stats); i++ )
> > +        if ( order_stats[i] )
> > +            printk("order: %2u allocations: %u\n", i, order_stats[i]);
> 
> Why the first of the two colons?

Because it's printing the order, I will remove it in the next version.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel