From: Alexey Dobriyan <adobriyan@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Waiman Long <longman@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Luis Chamberlain <mcgrof@kernel.org>,
Kees Cook <keescook@chromium.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
Davidlohr Bueso <dave@stgolabs.net>,
Miklos Szeredi <miklos@szeredi.hu>,
Daniel Colascione <dancol@google.com>,
Dave Chinner <david@fromorbit.com>,
Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH 2/2] /proc/stat: Add sysctl parameter to control irq counts latency
Date: Mon, 7 Jan 2019 19:33:01 +0300 [thread overview]
Message-ID: <20190107163301.GA14354@avx2> (raw)
In-Reply-To: <20190107155840.GY6310@bombadil.infradead.org>
On Mon, Jan 07, 2019 at 07:58:40AM -0800, Matthew Wilcox wrote:
> On Mon, Jan 07, 2019 at 10:12:58AM -0500, Waiman Long wrote:
> > A new "fs/proc-stat-irqs-latency-ms" sysctl parameter is now added to
>
> No. No, no, no, no, no. No.
>
> Stop adding new sysctls for this kind of thing. It's just a way to shift
> blame from us (who allegedly know what we're doing) to the sysadmin
> (who probably has better things to be doing than keeping up with the
> intricacies of development of every single piece of software running on
> their system).
>
> Let's figure out what this _should_ be.
Yeah, let's start interrogating about which values specifically this
super sekret applications wants.
I assume CPU stats, so system call which returns CPU statistics in binary form.
> Why are you caching the _output_ of calling sprintf(), rather than caching the
> values of each interrupt?
For output caching string is better, but I'm not defending the patch.
next prev parent reply other threads:[~2019-01-07 16:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 15:12 [PATCH 0/2] /proc/stat: Reduce irqs counting performance overhead Waiman Long
2019-01-07 15:12 ` [PATCH 1/2] /proc/stat: Extract irqs counting code into show_stat_irqs() Waiman Long
2019-01-07 21:42 ` Kees Cook
2019-01-07 15:12 ` [PATCH 2/2] /proc/stat: Add sysctl parameter to control irq counts latency Waiman Long
2019-01-07 15:58 ` Matthew Wilcox
2019-01-07 16:07 ` Waiman Long
2019-01-07 16:14 ` Matthew Wilcox
2019-01-07 16:19 ` Waiman Long
2019-01-07 16:33 ` Alexey Dobriyan [this message]
2019-01-07 16:59 ` Waiman Long
2019-01-18 8:44 ` [/proc/stat] 3047027b34: reaim.jobs_per_min -4.8% regression kernel test robot
2019-01-18 8:44 ` [LKP] " kernel test robot
2019-01-21 20:02 ` Kees Cook
2019-01-21 20:02 ` Kees Cook
2019-01-21 21:25 ` [LKP] " Alexey Dobriyan
2019-01-21 21:25 ` Alexey Dobriyan
2019-01-07 22:32 ` [PATCH 0/2] /proc/stat: Reduce irqs counting performance overhead Dave Chinner
2019-01-07 22:41 ` Daniel Colascione
2019-01-07 23:49 ` Alexey Dobriyan
2019-01-07 22:41 ` Waiman Long
2019-01-08 2:04 ` Dave Chinner
2019-01-08 16:11 ` Michal Hocko
2019-01-08 17:05 ` Waiman Long
2019-01-08 17:32 ` Waiman Long
2019-01-08 16:58 ` Waiman Long
2019-01-08 22:27 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107163301.GA14354@avx2 \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=dancol@google.com \
--cc=dave@stgolabs.net \
--cc=david@fromorbit.com \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mcgrof@kernel.org \
--cc=miklos@szeredi.hu \
--cc=rdunlap@infradead.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.