From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanislav Fomichev Subject: Re: [PATCH bpf] selftests/bpf: fix incorrect users of create_and_get_cgroup Date: Mon, 7 Jan 2019 08:49:56 -0800 Message-ID: <20190107164956.GA14250@mini-arch> References: <20190103185717.58134-1-sdf@google.com> <20190105043438.4nr7hxc4gbqayp5v@ast-mbp.dhcp.thefacebook.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Stanislav Fomichev , netdev@vger.kernel.org, davem@davemloft.net, ast@kernel.org, daniel@iogearbox.net To: Alexei Starovoitov Return-path: Received: from mail-pf1-f196.google.com ([209.85.210.196]:34787 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726992AbfAGQt7 (ORCPT ); Mon, 7 Jan 2019 11:49:59 -0500 Received: by mail-pf1-f196.google.com with SMTP id h3so444710pfg.1 for ; Mon, 07 Jan 2019 08:49:58 -0800 (PST) Content-Disposition: inline In-Reply-To: <20190105043438.4nr7hxc4gbqayp5v@ast-mbp.dhcp.thefacebook.com> Sender: netdev-owner@vger.kernel.org List-ID: On 01/04, Alexei Starovoitov wrote: > On Thu, Jan 03, 2019 at 10:57:17AM -0800, Stanislav Fomichev wrote: > > create_and_get_cgroup returns 0 on error, fix the users that assume > > negative value in case of an error. > > > > Signed-off-by: Stanislav Fomichev > > --- > > tools/testing/selftests/bpf/get_cgroup_id_user.c | 2 +- > > tools/testing/selftests/bpf/test_sockmap.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/tools/testing/selftests/bpf/get_cgroup_id_user.c b/tools/testing/selftests/bpf/get_cgroup_id_user.c > > index e8da7b39158d..dfaa9b353ac3 100644 > > --- a/tools/testing/selftests/bpf/get_cgroup_id_user.c > > +++ b/tools/testing/selftests/bpf/get_cgroup_id_user.c > > @@ -64,7 +64,7 @@ int main(int argc, char **argv) > > return 1; > > > > cgroup_fd = create_and_get_cgroup(TEST_CGROUP); > > - if (CHECK(cgroup_fd < 0, "create_and_get_cgroup", "err %d errno %d\n", > > + if (CHECK(!cgroup_fd, "create_and_get_cgroup", "err %d errno %d\n", > > fd can be zero. Assumed it was fine for the test where we never close stdin. > Hence I prefer to fix it the other way to avoid this corner case. > Pls fix create_and_get_cgroup() to return -1 in case of error. > The diff will be much bigger, but overall it's imo cleaner. Agree, will sent a v2 shortly. > Also pls add Fixes tag. > > Thanks >