From: Tony Lindgren <tony@atomide.com>
To: Rob Herring <robh@kernel.org>
Cc: linux-omap <linux-omap@vger.kernel.org>,
"Benoît Cousson" <bcousson@baylibre.com>,
devicetree@vger.kernel.org, "Pavel Machek" <pavel@ucw.cz>,
"Sebastian Reichel" <sre@kernel.org>
Subject: Re: [PATCH] ARM: dts: omap4-droid4: Fix typo in cpcap IRQ flags
Date: Mon, 7 Jan 2019 10:45:43 -0800 [thread overview]
Message-ID: <20190107184543.GH5544@atomide.com> (raw)
In-Reply-To: <CAL_Jsq+kzUv=U3fAY=r1jh9nMsi+m8KFg50aeh-Ap9gdK3rstA@mail.gmail.com>
* Rob Herring <robh@kernel.org> [190107 18:37]:
> On Mon, Jan 7, 2019 at 11:59 AM Tony Lindgren <tony@atomide.com> wrote:
> >
> > We're now getting the following error:
> >
> > genirq: Setting trigger mode 1 for irq 230 failed
> > (regmap_irq_set_type+0x0/0x15c)
> > cpcap-usb-phy cpcap-usb-phy.0: could not get irq dp: -524
> >
> > This is because of a typo in the irq flags. Really these interrupts
> > are LEVEL, but before we change them we need to test them. So let's
> > do a minimal fix first.
>
> Hopefully, you mean a driver fix later and not changing the DT again?
> A 0 flag is correct if the type is not programmable which I'd guess is
> the case here.
Oh OK thanks for letting me know. In that case with 0 being correct
for non-programmable interrupts, I'll just drop that paragraph and
no need for further changes. The driver should be already doing the
right thing.
Regards,
Tony
next prev parent reply other threads:[~2019-01-07 18:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 17:59 [PATCH] ARM: dts: omap4-droid4: Fix typo in cpcap IRQ flags Tony Lindgren
2019-01-07 18:37 ` Rob Herring
2019-01-07 18:45 ` Tony Lindgren [this message]
2019-01-07 18:45 ` Pavel Machek
2019-01-25 16:28 ` Pavel Machek
2019-01-25 16:53 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107184543.GH5544@atomide.com \
--to=tony@atomide.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.