From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Habkost Subject: [PATCH 0/3] machine: Make compat_props arrays shorter and more readable Date: Mon, 7 Jan 2019 17:30:17 -0200 Message-ID: <20190107193020.21744-1-ehabkost@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ggabQ-0001jr-E5 for xen-devel@lists.xenproject.org; Mon, 07 Jan 2019 19:30:24 +0000 List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, Stefano Stabellini , Eduardo Habkost , David Hildenbrand , Cornelia Huck , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, "Michael S. Tsirkin" , Marcel Apfelbaum , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Anthony Perard , Paolo Bonzini , David Gibson , xen-devel@lists.xenproject.org, Richard Henderson List-Id: xen-devel@lists.xenproject.org Q3VycmVudCBkZWNsYXJhdGlvbnMgb2YgY29tcGF0X3Byb3BzIGFycmF5cyBhcmUgdmVyeSB2ZXJi b3NlLAp3aXRoIGVhY2ggZW50cnkgdGFraW5nIDQgbGluZXMgb2YgY29kZS4gIEJ5IG9taXR0aW5n IHRoZSBmaWVsZApkZXNpZ25hdG9ycywgd2UgY2FuIG1ha2UgZWFjaCBhcnJheSBlbnRyeSBmaXQg YSBzaW5nbGUgbGluZSBvZgpjb2RlIGFuZCBiZSBtb3JlIHJlYWRhYmxlLgoKRWR1YXJkbyBIYWJr b3N0ICgzKToKICBzcGFwcjogRWxpbWluYXRlIFNQQVBSX1BDSV8yXzdfTU1JT19XSU5fU0laRSBt YWNybwogIG1hY2hpbmU6IEVsaW1pbmF0ZSB1bm5lY2Vzc2FyeSBzdHJpbmdpZnkoKSB1c2FnZQog IG1hY2hpbmU6IFVzZSBzaG9ydGVyIGZvcm1hdCBmb3IgR2xvYmFsUHJvcGVydHkgYXJyYXlzCgog aW5jbHVkZS9ody9pMzg2L3BjLmggICAgICAgIHwgIDE4ICstCiBpbmNsdWRlL2h3L3BjaS1ob3N0 L3NwYXByLmggfCAgIDEgLQogaHcvY29yZS9tYWNoaW5lLmMgICAgICAgICAgIHwgMzM4ICsrKyst LS0tLS0tLS0tLS0tCiBody9pMzg2L3BjLmMgICAgICAgICAgICAgICAgfCA3MjAgKysrKysrKy0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiBody9pMzg2L3BjX3BpaXguYyAgICAgICAgICAg fCAxOTIgKystLS0tLS0tLQogaHcvcHBjL3NwYXByLmMgICAgICAgICAgICAgIHwgIDcyICstLS0K IGh3L3MzOTB4L3MzOTAtdmlydGlvLWNjdy5jICB8ICA3NSArLS0tCiBody94ZW4veGVuLWNvbW1v bi5jICAgICAgICAgfCAgMTggKy0KIDggZmlsZXMgY2hhbmdlZCwgMjY1IGluc2VydGlvbnMoKyks IDExNjkgZGVsZXRpb25zKC0pCgotLSAKMi4xOC4wLnJjMS4xLmczZjFmZjIxNDAKCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGlu ZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnBy b2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:33251) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggabe-0008EF-Pp for qemu-devel@nongnu.org; Mon, 07 Jan 2019 14:30:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggabc-0000Et-PE for qemu-devel@nongnu.org; Mon, 07 Jan 2019 14:30:38 -0500 From: Eduardo Habkost Date: Mon, 7 Jan 2019 17:30:17 -0200 Message-Id: <20190107193020.21744-1-ehabkost@redhat.com> Subject: [Qemu-devel] [PATCH 0/3] machine: Make compat_props arrays shorter and more readable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: David Hildenbrand , Paolo Bonzini , Christian Borntraeger , Cornelia Huck , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Richard Henderson , David Gibson , qemu-s390x@nongnu.org, Halil Pasic , Anthony Perard , Eduardo Habkost , Marcel Apfelbaum , Stefano Stabellini , "Michael S. Tsirkin" , qemu-ppc@nongnu.org, xen-devel@lists.xenproject.org Current declarations of compat_props arrays are very verbose, with each entry taking 4 lines of code. By omitting the field designators, we can make each array entry fit a single line of code and be more readable. Eduardo Habkost (3): spapr: Eliminate SPAPR_PCI_2_7_MMIO_WIN_SIZE macro machine: Eliminate unnecessary stringify() usage machine: Use shorter format for GlobalProperty arrays include/hw/i386/pc.h | 18 +- include/hw/pci-host/spapr.h | 1 - hw/core/machine.c | 338 ++++------------- hw/i386/pc.c | 720 +++++++----------------------------- hw/i386/pc_piix.c | 192 ++-------- hw/ppc/spapr.c | 72 +--- hw/s390x/s390-virtio-ccw.c | 75 +--- hw/xen/xen-common.c | 18 +- 8 files changed, 265 insertions(+), 1169 deletions(-) -- 2.18.0.rc1.1.g3f1ff2140