From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [2/4] usb: musb: jz4740: Add support for devicetree From: Bin Liu Message-Id: <20190107194725.GB25910@uda0271908> Date: Mon, 7 Jan 2019 13:47:25 -0600 To: Paul Cercueil Cc: Greg Kroah-Hartman , Rob Herring , Mark Rutland , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, od@zcrc.me List-ID: SGksCgpPbiBUaHUsIERlYyAxMywgMjAxOCBhdCAwMzo0NTo1M1BNICswMTAwLCBQYXVsIENlcmN1 ZWlsIHdyb3RlOgo+IEFkZCBzdXBwb3J0IGZvciBwcm9iaW5nIHRoZSBkcml2ZXIgZnJvbSBkZXZp Y2V0cmVlLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFBhdWwgQ2VyY3VlaWwgPHBhdWxAY3JhcG91aWxs b3UubmV0Pgo+IC0tLQo+ICBkcml2ZXJzL3VzYi9tdXNiL2p6NDc0MC5jIHwgNyArKysrKysrCj4g IDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy91c2IvbXVzYi9qejQ3NDAuYyBiL2RyaXZlcnMvdXNiL211c2Ivano0NzQwLmMKPiBpbmRleCAw NGQ4YjJiYzIwNWEuLjlhMmNlYmNhYzI2MCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3VzYi9tdXNi L2p6NDc0MC5jCj4gKysrIGIvZHJpdmVycy91c2IvbXVzYi9qejQ3NDAuYwo+IEBAIC0xMCw2ICsx MCw3IEBACj4gICNpbmNsdWRlIDxsaW51eC9lcnJuby5oPgo+ICAjaW5jbHVkZSA8bGludXgva2Vy bmVsLmg+Cj4gICNpbmNsdWRlIDxsaW51eC9tb2R1bGUuaD4KPiArI2luY2x1ZGUgPGxpbnV4L29m X2RldmljZS5oPgo+ICAjaW5jbHVkZSA8bGludXgvcGxhdGZvcm1fZGV2aWNlLmg+Cj4gICNpbmNs dWRlIDxsaW51eC91c2IvdXNiX3BoeV9nZW5lcmljLmg+Cj4gIAo+IEBAIC0xODgsMTEgKzE4OSwx NyBAQCBzdGF0aWMgaW50IGp6NDc0MF9yZW1vdmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRl dikKPiAgCXJldHVybiAwOwo+ICB9Cj4gIAo+ICtzdGF0aWMgY29uc3Qgc3RydWN0IG9mX2Rldmlj ZV9pZCBqejQ3NDBfbXVzYl9vZl9tYXRjaFtdID0gewo+ICsJeyAuY29tcGF0aWJsZSA9ICJpbmdl bmljLGp6NDc0MC1tdXNiIiB9LAo+ICsJe30sCj4gK307CgpzaG91bGQgYmUgd3JhcHBlZCBieSAn I2lmZGVmIENPTkZJR19PRic/CgptaXNzIE1PRFVMRV9ERVZJQ0VfVEFCTEUoKQoKPiArCj4gIHN0 YXRpYyBzdHJ1Y3QgcGxhdGZvcm1fZHJpdmVyIGp6NDc0MF9kcml2ZXIgPSB7Cj4gIAkucHJvYmUJ CT0gano0NzQwX3Byb2JlLAo+ICAJLnJlbW92ZQkJPSBqejQ3NDBfcmVtb3ZlLAo+ICAJLmRyaXZl cgkJPSB7Cj4gIAkJLm5hbWUJPSAibXVzYi1qejQ3NDAiLAo+ICsJCS5vZl9tYXRjaF90YWJsZSA9 IG9mX21hdGNoX3B0cihqejQ3NDBfbXVzYl9vZl9tYXRjaCksCj4gIAl9LAo+ICB9Owo+ICAKClJl Z2FyZHMsCi1CaW4uCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bin Liu Subject: Re: [PATCH 2/4] usb: musb: jz4740: Add support for devicetree Date: Mon, 7 Jan 2019 13:47:25 -0600 Message-ID: <20190107194725.GB25910@uda0271908> References: <20181213144555.24031-1-paul@crapouillou.net> <20181213144555.24031-2-paul@crapouillou.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <20181213144555.24031-2-paul@crapouillou.net> Sender: linux-kernel-owner@vger.kernel.org To: Paul Cercueil Cc: Greg Kroah-Hartman , Rob Herring , Mark Rutland , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, od@zcrc.me List-Id: devicetree@vger.kernel.org Hi, On Thu, Dec 13, 2018 at 03:45:53PM +0100, Paul Cercueil wrote: > Add support for probing the driver from devicetree. > > Signed-off-by: Paul Cercueil > --- > drivers/usb/musb/jz4740.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/usb/musb/jz4740.c b/drivers/usb/musb/jz4740.c > index 04d8b2bc205a..9a2cebcac260 100644 > --- a/drivers/usb/musb/jz4740.c > +++ b/drivers/usb/musb/jz4740.c > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -188,11 +189,17 @@ static int jz4740_remove(struct platform_device *pdev) > return 0; > } > > +static const struct of_device_id jz4740_musb_of_match[] = { > + { .compatible = "ingenic,jz4740-musb" }, > + {}, > +}; should be wrapped by '#ifdef CONFIG_OF'? miss MODULE_DEVICE_TABLE() > + > static struct platform_driver jz4740_driver = { > .probe = jz4740_probe, > .remove = jz4740_remove, > .driver = { > .name = "musb-jz4740", > + .of_match_table = of_match_ptr(jz4740_musb_of_match), > }, > }; > Regards, -Bin. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFC4EC43387 for ; Mon, 7 Jan 2019 19:47:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8421121855 for ; Mon, 7 Jan 2019 19:47:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="p4tVf4gP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727825AbfAGTrg (ORCPT ); Mon, 7 Jan 2019 14:47:36 -0500 Received: from lelv0143.ext.ti.com ([198.47.23.248]:39118 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726654AbfAGTrf (ORCPT ); Mon, 7 Jan 2019 14:47:35 -0500 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x07JlQXR027689; Mon, 7 Jan 2019 13:47:26 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1546890446; bh=OAFsEGX65HZt0ksZDgtSE5/pDgQZSHK+rmU6cGkmFUg=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=p4tVf4gPsAz1DJKY56Grn/SahFlqKoeU5SLaQsk8NcI4SePXmXJwLtVapkJSAs1Ef lYF0aa5k/aUJlsiGhVAMnYxVJO9M39CL+pLa78eWnnmaGb8QQRNwFvNPhd0ULkM9Xf ZVVtolReFFhlNR7iWAIiD4x2tePODxN1yFrtEB7s= Received: from DFLE103.ent.ti.com (dfle103.ent.ti.com [10.64.6.24]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x07JlQ8p047721 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 7 Jan 2019 13:47:26 -0600 Received: from DFLE110.ent.ti.com (10.64.6.31) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Mon, 7 Jan 2019 13:47:26 -0600 Received: from dlep33.itg.ti.com (157.170.170.75) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1591.10 via Frontend Transport; Mon, 7 Jan 2019 13:47:25 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id x07JlPZ2028921; Mon, 7 Jan 2019 13:47:25 -0600 Date: Mon, 7 Jan 2019 13:47:25 -0600 From: Bin Liu To: Paul Cercueil CC: Greg Kroah-Hartman , Rob Herring , Mark Rutland , , , , Subject: Re: [PATCH 2/4] usb: musb: jz4740: Add support for devicetree Message-ID: <20190107194725.GB25910@uda0271908> Mail-Followup-To: Bin Liu , Paul Cercueil , Greg Kroah-Hartman , Rob Herring , Mark Rutland , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, od@zcrc.me References: <20181213144555.24031-1-paul@crapouillou.net> <20181213144555.24031-2-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20181213144555.24031-2-paul@crapouillou.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, Dec 13, 2018 at 03:45:53PM +0100, Paul Cercueil wrote: > Add support for probing the driver from devicetree. > > Signed-off-by: Paul Cercueil > --- > drivers/usb/musb/jz4740.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/usb/musb/jz4740.c b/drivers/usb/musb/jz4740.c > index 04d8b2bc205a..9a2cebcac260 100644 > --- a/drivers/usb/musb/jz4740.c > +++ b/drivers/usb/musb/jz4740.c > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -188,11 +189,17 @@ static int jz4740_remove(struct platform_device *pdev) > return 0; > } > > +static const struct of_device_id jz4740_musb_of_match[] = { > + { .compatible = "ingenic,jz4740-musb" }, > + {}, > +}; should be wrapped by '#ifdef CONFIG_OF'? miss MODULE_DEVICE_TABLE() > + > static struct platform_driver jz4740_driver = { > .probe = jz4740_probe, > .remove = jz4740_remove, > .driver = { > .name = "musb-jz4740", > + .of_match_table = of_match_ptr(jz4740_musb_of_match), > }, > }; > Regards, -Bin.