From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [1/2] dt-bindings: Add Qualcomm USB Super-Speed PHY bindings From: Jack Pham Message-Id: <20190107202606.GC23243@jackp-linux.qualcomm.com> Date: Mon, 7 Jan 2019 12:26:06 -0800 To: Jorge Ramirez Cc: Rob Herring , Andy Gross , gregkh@linuxfoundation.org, mark.rutland@arm.com, kishon@ti.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, shawn.guo@linaro.org, vkoul@kernel.org, Manu Gautam , Sriharsha Allenki List-ID: SGkgSm9yZ2UsCgpTb3JyeSBmb3IgdGhlIGxhdGUgcmVwbHkgYXMgSSB3YXMgb3V0IGR1cmluZyB0 aGUgaG9saWRheSBicmVhay4KCk9uIEZyaSwgRGVjIDI4LCAyMDE4IGF0IDAxOjM4OjU5UE0gKzAx MDAsIEpvcmdlIFJhbWlyZXogd3JvdGU6Cj4gT24gMTIvMjAvMTggMTg6MzcsIEphY2sgUGhhbSB3 cm90ZToKPiA+SGkgUm9iLCBKb3JnZSwKPiA+Cj4gPk9uIFRodSwgRGVjIDIwLCAyMDE4IGF0IDEx OjA1OjMxQU0gLTA2MDAsIFJvYiBIZXJyaW5nIHdyb3RlOgo+ID4+T24gRnJpLCBEZWMgMDcsIDIw MTggYXQgMTA6NTU6NTdBTSArMDEwMCwgSm9yZ2UgUmFtaXJlei1PcnRpeiB3cm90ZToKPiA+Pj5C aW5kaW5nIGRlc2NyaXB0aW9uIGZvciBRdWFsY29tbSdzIFN5bm9wc3lzIDEuMC4wIHN1cGVyLXNw ZWVkIFBIWQo+ID4+PmNvbnRyb2xsZXIgZW1iZWRkZWQgaW4gUUNTNDA0Lgo+ID4+Pgo+ID4+PkJh c2VkIG9uIFNyaWhhcnNoYSBBbGxlbmtpJ3MgPHNhbGxlbmtpQGNvZGVhdXJvcmEub3JnPiBvcmln aW5hbAo+ID4+PmRlZmluaXRpb25zLgo+ID4+Pgo+ID4+PlNpZ25lZC1vZmYtYnk6IEpvcmdlIFJh bWlyZXotT3J0aXogPGpvcmdlLnJhbWlyZXotb3J0aXpAbGluYXJvLm9yZz4KPiA+Pj5SZXZpZXdl ZC1ieTogVmlub2QgS291bCA8dmtvdWxAa2VybmVsLm9yZz4KPiA+Pj4tLS0KPiA+Pj4gIC4uLi9k ZXZpY2V0cmVlL2JpbmRpbmdzL3VzYi9xY29tLHVzYi1zc3BoeS50eHQgICAgIHwgNzggKysrKysr KysrKysrKysrKysrKysrKwo+ID4+PiAgMSBmaWxlIGNoYW5nZWQsIDc4IGluc2VydGlvbnMoKykK PiA+Pj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGlu Z3MvdXNiL3Fjb20sdXNiLXNzcGh5LnR4dAo+ID4+Pgo+ID4+PmRpZmYgLS1naXQgYS9Eb2N1bWVu dGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdXNiL3Fjb20sdXNiLXNzcGh5LnR4dCBiL0RvY3Vt ZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy91c2IvcWNvbSx1c2Itc3NwaHkudHh0Cj4gPj4+ bmV3IGZpbGUgbW9kZSAxMDA2NDQKPiA+Pj5pbmRleCAwMDAwMDAwLi5mY2Y0ZTAxCj4gPj4+LS0t IC9kZXYvbnVsbAo+ID4+PisrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy91 c2IvcWNvbSx1c2Itc3NwaHkudHh0Cj4gPj4+QEAgLTAsMCArMSw3OCBAQAo+ID4+PitRdWFsY29t bSBTeW5vcHN5cyAxLjAuMCBTUyBwaHkgY29udHJvbGxlcgo+ID4+Pis9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Cj4gPj4+Kwo+ID4+PitTeW5vcHN5cyAxLjAuMCBz cyBwaHkgY29udHJvbGxlciBzdXBwb3J0cyBTUyB1c2IgY29ubmVjdGl2aXR5IG9uIFF1YWxjb21t Cj4gPj4+K2NoaXBzZXRzCj4gPj4+Kwo+ID4+PitSZXF1aXJlZCBwcm9wZXJ0aWVzOgo+ID4+PisK PiA+Pj4rLSBjb21wYXRpYmxlOgo+ID4+PisgICAgVmFsdWUgdHlwZTogPHN0cmluZz4KPiA+Pj4r ICAgIERlZmluaXRpb246IFNob3VsZCBjb250YWluICJxY29tLHVzYi1zc3BoeSIuCj4gPj4KPiA+ PldoYXQgaXMgInFjb20sZHdjMy1zcy11c2ItcGh5IiB3aGljaCBhbHJlYWR5IGV4aXN0cyB0aGVu Pwo+ID4KPiA+VWgsIGFwcGFyZW50bHkgb25seSB0aGUgYmluZGluZ3MgZG9jIGlzIHRoZXJlIGJ1 dCB0aGUgZHJpdmVyIG5ldmVyCj4gPmxhbmRlZC4gSSBndWVzcyBpdCBmZWxsIHRocm91Z2ggdGhl IGNyYWNrcyBuZWFybHkgNCB5ZWFycyBhZ28uCj4gPgo+ID5odHRwczovL2xvcmUua2VybmVsLm9y Zy9wYXRjaHdvcmsvcGF0Y2gvNDk5NTAyLwo+ID4KPiA+Sm9yZ2UsIGRvZXMgQW5keSdzIHZlcnNp b24gb2YgdGhpcyBkcml2ZXIgYXQgYWxsIHJlc2VtYmxlIHdoYXQgY2FuIGJlCj4gPnVzZWQgZm9y IFFDUzQwND8KPiAKPiBvbiBjbG9zZSBpbnNwZWN0aW9uIEkgY2FudCBzZWUgYW55IHNpbWlsaXR1 ZGVzIGJldHdlZW4gdGhlIGRyaXZlcnMuCj4gVW5mb3J0dW5hdGVseSBJIGRvbid0IGhhdmUgYWNj ZXNzIHRvIGRvY3VtZW50YXRpb24geWV0IGJ1dCB0aGUKPiBjb250cm9sIHJlZ2lzdGVyIG9mZnNl dHMgYW5kIHRoZSBjb250cm9sIGJpdHMgaW4gdGhlIGRyaXZlcnMgZG8gbm90Cj4gbWF0Y2guCj4g Cj4gYmVjYXVzZSBvZiB0aGUgYWJvdmUgSSdkIGxpa2UgdG8gZ28gYWhlYWQgd2l0aCBvdXIgc2Vw YXJhdGUgZHJpdmVycwo+IC1hbHJlYWR5IHRlc3RlZCBhbmQgdmFsaWRhdGVkLSBmb3IgSFMgKFNo YXduJ3MpIGFuZCBTUyAobWluZSkuCj4gCj4gaWYgdGhhdCBpcyBhY2NlcHRhYmxlLCBzaG91bGQg d2UgcmV1c2UgdGhlIHVwc3RyZWFtIGJpbmRpbmdzIGZvcgo+IG91ciBpbXBsZW1lbnRhdGlvbj8g b3IgcGVyaGFwcyBTaGF3biBHdW8gd2lsbCBkbyBmb3IgaGlzIEhTIHZlcnNpb24KPiBvZiB0aGUg ZHJpdmVyIGFuZCBJIGdvIGFoZWFkIGFuZCBjcmVhdGUgYSBuZXcgb25lPyB3aGF0IHdvdWxkIHlv dQo+IHN1Z2dlc3Q/CgpJJ20gbm90IHJlYWxseSBzdXJlLiBNeSB1bmRlcnN0YW5kaW5nIG9mIHRo ZSBkcml2ZXIgQW5keSBzdWJtaXR0ZWQKd2VyZSBmb3Igc29tZSBvZiB0aGUgb2xkZXIgTVNNIGFu ZCBJUFEgU29DcyB0aGF0IGltcGxlbWVudGVkIHRoZSBQSFkKY29udHJvbHMgYXMgcGFydCBvZiB0 aGUgRFdDMyBjb250cm9sbGVyJ3MgIlFTY3JhdGNoIiByZWdpc3RlcnMsIHdoaWNoIGlzCndoeSB0 aGUgYmluZGluZ3MgZG9jIGFuZCB0aGUgY29tcGF0aWJsZSBzdHJpbmcgcmVmZXJlbmNlICJkd2Mz IiBpbiBib3RoCnRoZSBjb21wYXRpYmxlIGFuZCB0aGUgZG9jcyBmaWxlbmFtZS4gSXMgdGhlIFNO UFMgUEhZIG9uIFFDUzQwNAphcmNoaXRlY3RlZCBzaW1pbGFybHkgaW4gdGhpcyByZWdhcmQ/IEVp dGhlciB3YXksIHRoZSBleGlzdGluZyBiaW5kaW5ncwpkb2MgZm9yIHRoZSBub24tZXhpc3RlbnQg ZHJpdmVyIGxvb2tzIGluY29tcGxldGUgZm9yIFFDUzQwNCwgc28geW91J2QKaGF2ZSB0byB1cGRh dGUgaXQgYW55d2F5LiBNeSBmZWVsaW5nIGlzIHRoYXQgdGhlcmUgc2hvdWxkIGp1c3QgYmUgb25l CmRvY3VtZW50IGRlc2NyaWJpbmcgYWxsIHZhcmlhbnRzIG9mIFNOUFMgUEhZcyBvbiBRdWFsY29t bSBjaGlwcy4KCk1heWJlIHdlIHNob3VsZCBhbHNvIGp1c3QgZGVsZXRlIHRoZSAicWNvbSxkd2Mz LXNzLXVzYi1waHkiIGJpbmRpbmcKdW5sZXNzIHRoZXJlIGlzIGEgcGxhbiB0byByZXN1cnJlY3Qg QW5keSdzIGRyaXZlci4KCkphY2sK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jack Pham Subject: Re: [PATCH 1/2] dt-bindings: Add Qualcomm USB Super-Speed PHY bindings Date: Mon, 7 Jan 2019 12:26:06 -0800 Message-ID: <20190107202606.GC23243@jackp-linux.qualcomm.com> References: <1544176558-7946-1-git-send-email-jorge.ramirez-ortiz@linaro.org> <1544176558-7946-2-git-send-email-jorge.ramirez-ortiz@linaro.org> <20181220170531.GA19862@bogus> <20181220173633.GA19912@jackp-linux.qualcomm.com> <2a007a91-e709-c9f1-f634-ddcf707e954d@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <2a007a91-e709-c9f1-f634-ddcf707e954d@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Jorge Ramirez Cc: Rob Herring , Andy Gross , gregkh@linuxfoundation.org, mark.rutland@arm.com, kishon@ti.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, shawn.guo@linaro.org, vkoul@kernel.org, Manu Gautam , Sriharsha Allenki List-Id: devicetree@vger.kernel.org Hi Jorge, Sorry for the late reply as I was out during the holiday break. On Fri, Dec 28, 2018 at 01:38:59PM +0100, Jorge Ramirez wrote: > On 12/20/18 18:37, Jack Pham wrote: > >Hi Rob, Jorge, > > > >On Thu, Dec 20, 2018 at 11:05:31AM -0600, Rob Herring wrote: > >>On Fri, Dec 07, 2018 at 10:55:57AM +0100, Jorge Ramirez-Ortiz wrote: > >>>Binding description for Qualcomm's Synopsys 1.0.0 super-speed PHY > >>>controller embedded in QCS404. > >>> > >>>Based on Sriharsha Allenki's original > >>>definitions. > >>> > >>>Signed-off-by: Jorge Ramirez-Ortiz > >>>Reviewed-by: Vinod Koul > >>>--- > >>> .../devicetree/bindings/usb/qcom,usb-ssphy.txt | 78 ++++++++++++++++++++++ > >>> 1 file changed, 78 insertions(+) > >>> create mode 100644 Documentation/devicetree/bindings/usb/qcom,usb-ssphy.txt > >>> > >>>diff --git a/Documentation/devicetree/bindings/usb/qcom,usb-ssphy.txt b/Documentation/devicetree/bindings/usb/qcom,usb-ssphy.txt > >>>new file mode 100644 > >>>index 0000000..fcf4e01 > >>>--- /dev/null > >>>+++ b/Documentation/devicetree/bindings/usb/qcom,usb-ssphy.txt > >>>@@ -0,0 +1,78 @@ > >>>+Qualcomm Synopsys 1.0.0 SS phy controller > >>>+=========================================== > >>>+ > >>>+Synopsys 1.0.0 ss phy controller supports SS usb connectivity on Qualcomm > >>>+chipsets > >>>+ > >>>+Required properties: > >>>+ > >>>+- compatible: > >>>+ Value type: > >>>+ Definition: Should contain "qcom,usb-ssphy". > >> > >>What is "qcom,dwc3-ss-usb-phy" which already exists then? > > > >Uh, apparently only the bindings doc is there but the driver never > >landed. I guess it fell through the cracks nearly 4 years ago. > > > >https://lore.kernel.org/patchwork/patch/499502/ > > > >Jorge, does Andy's version of this driver at all resemble what can be > >used for QCS404? > > on close inspection I cant see any similitudes between the drivers. > Unfortunately I don't have access to documentation yet but the > control register offsets and the control bits in the drivers do not > match. > > because of the above I'd like to go ahead with our separate drivers > -already tested and validated- for HS (Shawn's) and SS (mine). > > if that is acceptable, should we reuse the upstream bindings for > our implementation? or perhaps Shawn Guo will do for his HS version > of the driver and I go ahead and create a new one? what would you > suggest? I'm not really sure. My understanding of the driver Andy submitted were for some of the older MSM and IPQ SoCs that implemented the PHY controls as part of the DWC3 controller's "QScratch" registers, which is why the bindings doc and the compatible string reference "dwc3" in both the compatible and the docs filename. Is the SNPS PHY on QCS404 architected similarly in this regard? Either way, the existing bindings doc for the non-existent driver looks incomplete for QCS404, so you'd have to update it anyway. My feeling is that there should just be one document describing all variants of SNPS PHYs on Qualcomm chips. Maybe we should also just delete the "qcom,dwc3-ss-usb-phy" binding unless there is a plan to resurrect Andy's driver. Jack -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project