From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:39020) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gglkL-00033V-Pw for qemu-devel@nongnu.org; Tue, 08 Jan 2019 02:24:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gglkK-0005sD-GF for qemu-devel@nongnu.org; Tue, 08 Jan 2019 02:24:21 -0500 Received: from mga18.intel.com ([134.134.136.126]:43735) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gglkI-0005Vu-FA for qemu-devel@nongnu.org; Tue, 08 Jan 2019 02:24:19 -0500 Date: Tue, 8 Jan 2019 15:20:33 +0800 From: Yang Zhong Message-ID: <20190108072033.GC27412@yangzhon-Virtual> References: <20181227063419.12981-1-yang.zhong@intel.com> <20181227063419.12981-11-yang.zhong@intel.com> <2a2562bd-addc-d507-f2a1-b90e2a22200e@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2a2562bd-addc-d507-f2a1-b90e2a22200e@redhat.com> Subject: Re: [Qemu-devel] [RFC PATCH 10/25] build: convert pci.mak to Kconfig List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: qemu-devel@nongnu.org, eter.maydell@linaro.org, sameo@linux.intel.com, pbonzini@redhat.com, ehabkost@redhat.com, yang.zhong@intel.com On Fri, Jan 04, 2019 at 02:48:03PM +0100, Thomas Huth wrote: > On 2018-12-27 07:34, Yang Zhong wrote: > > From: Paolo Bonzini > > > > Instead of including the same list of devices for each target, > > set CONFIG_PCI to true, and make the devices default to present > > whenever PCI is available. > > > > Done mostly with the following script: > > > > while read i; do > > i=${i%=y}; i=${i#CONFIG_} > > sed -i -e'/^config '$i'$/!b' -en \ > > -e'a\' -e' default y\' -e' depends on PCI' \ > > `grep -lw $i hw/*/Kconfig` > > done < default-configs/pci.mak > > > > followed by replacing a few "depends on" clauses with "select" > > whenever the symbol is not really related to PCI. > > > > Signed-off-by: Paolo Bonzini > > Signed-off-by: Yang Zhong > > --- > > default-configs/i386-softmmu.mak | 2 +- > > default-configs/pci.mak | 47 -------------------------------- > > hw/audio/Kconfig | 6 ++++ > > hw/block/Kconfig | 2 ++ > > hw/char/Kconfig | 2 ++ > > hw/display/Kconfig | 12 +++++++- > > hw/ide/Kconfig | 6 ++++ > > hw/ipack/Kconfig | 2 ++ > > hw/misc/Kconfig | 4 +++ > > hw/net/Kconfig | 19 +++++++++++++ > > hw/scsi/Kconfig | 11 ++++++++ > > hw/sd/Kconfig | 3 ++ > > hw/usb/Kconfig | 10 +++++++ > > hw/virtio/Kconfig | 3 ++ > > hw/watchdog/Kconfig | 2 ++ > > 15 files changed, 82 insertions(+), 49 deletions(-) > > delete mode 100644 default-configs/pci.mak > [...] > > diff --git a/hw/char/Kconfig b/hw/char/Kconfig > > index 26c13243cf..1ed6f0dbce 100644 > > --- a/hw/char/Kconfig > > +++ b/hw/char/Kconfig > > @@ -15,6 +15,8 @@ config SERIAL_ISA > > > > config SERIAL_PCI > > bool > > + default y > > + depends on PCI > > I think this likely needs a "select SERIAL", too? At least the > SERIAL_ISA switch gets a "select SERIAL" in patch 15/25, so it sounds > logical if the SERIAL_PCI would get this, too... > > Thomas Thomas, thanks, i will add "select SERIAL" into 15/25 patch, thanks again! Regards, Yang