From: Boris Brezillon <bbrezillon@kernel.org>
To: Boris Brezillon <bbrezillon@kernel.org>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Boris Brezillon <boris.brezillon@bootlin.com>,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org
Subject: Re: [2/2] mtd: Check add_mtd_device() ret code
Date: Tue, 8 Jan 2019 09:29:59 +0100 [thread overview]
Message-ID: <20190108082959.20870-1-bbrezillon@kernel.org> (raw)
In-Reply-To: <20190102143654.24362-2-bbrezillon@kernel.org>
From: Boris Brezillon <boris.brezillon@bootlin.com>
On Wed, 2019-01-02 at 14:36:54 UTC, Boris Brezillon wrote:
> add_mtd_device() can fail. We should always check its return value
> and gracefully handle the failure case. Fix the call sites where this
> not done (in mtdpart.c) and add a __must_check attribute to the
> prototype to avoid this kind of mistakes.
>
> Signed-off-by: Boris Brezillon <bbrezillon@kernel.org>
Applied to http://git.infradead.org/linux-mtd.git master, thanks.
Boris
next prev parent reply other threads:[~2019-01-08 8:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 14:36 [PATCH 1/2] mtd: Fix the check on nvmem_register() ret code Boris Brezillon
2019-01-02 14:36 ` [PATCH 2/2] mtd: Check add_mtd_device() " Boris Brezillon
2019-01-08 8:29 ` Boris Brezillon [this message]
2019-01-22 11:21 ` Geert Uytterhoeven
2019-01-22 12:31 ` Boris Brezillon
2019-01-29 11:03 ` Boris Brezillon
2019-01-29 15:29 ` Geert Uytterhoeven
2019-01-30 8:52 ` Boris Brezillon
2019-01-30 9:05 ` Geert Uytterhoeven
2019-01-30 9:10 ` Boris Brezillon
2019-01-30 9:16 ` Geert Uytterhoeven
2019-02-01 8:50 ` Boris Brezillon
2019-02-01 9:02 ` Geert Uytterhoeven
2019-01-30 9:17 ` Boris Brezillon
2019-01-30 8:55 ` Boris Brezillon
2019-01-30 9:12 ` Geert Uytterhoeven
2019-04-01 9:50 ` Geert Uytterhoeven
2019-04-01 13:27 ` Boris Brezillon
2019-01-02 15:13 ` [PATCH 1/2] mtd: Fix the check on nvmem_register() " Bartosz Golaszewski
2019-01-08 8:30 ` [1/2] " Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190108082959.20870-1-bbrezillon@kernel.org \
--to=bbrezillon@kernel.org \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.