From: Brian Masney <masneyb@onstation.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: andy.gross@linaro.org, bjorn.andersson@linaro.org,
lee.jones@linaro.org, linus.walleij@linaro.org,
marc.zyngier@arm.com, shawnguo@kernel.org, dianders@chromium.org,
linux-gpio@vger.kernel.org, nicolas.dechesne@linaro.org,
niklas.cassel@linaro.org, david.brown@linaro.org,
robh+dt@kernel.org, mark.rutland@arm.com,
thierry.reding@gmail.com, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 4/5] qcom: spmi-gpio: add support for hierarchical IRQ chip
Date: Tue, 8 Jan 2019 05:35:45 -0500 [thread overview]
Message-ID: <20190108103545.GB3643@basecamp> (raw)
In-Reply-To: <154689814280.15366.2705028033847856491@swboyd.mtv.corp.google.com>
On Mon, Jan 07, 2019 at 01:55:42PM -0800, Stephen Boyd wrote:
> > + ret = pmic_gpio_domain_translate(domain, fwspec, &hwirq, &type);
> > + if (ret)
> > + return ret;
> > +
> > + for (i = 0; i < nr_irqs; i++)
> > + irq_domain_set_info(domain, virq + i, hwirq + i,
> > + &pmic_gpio_irq_chip, state,
> > + handle_level_irq, NULL, NULL);
> > +
> > + parent_fwspec.fwnode = domain->parent->fwnode;
> > + parent_fwspec.param_count = 4;
> > + parent_fwspec.param[0] = 0;
> > + parent_fwspec.param[1] = fwspec->param[0] + 0xc0 - 1;
>
> Is the -1 there twice, once in pmic_gpio_domain_translate() and then
> here?
That should be 'hwirq + c0' to improve the code readability.
Brian
next prev parent reply other threads:[~2019-01-08 10:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 2:11 [PATCH v2 0/5] qcom: spmi: add support for hierarchical IRQ chip Brian Masney
2019-01-07 2:11 ` [PATCH v2 1/5] spmi: pmic-arb: hardcode IRQ counts Brian Masney
2019-01-07 7:13 ` kbuild test robot
2019-01-07 10:47 ` Linus Walleij
2019-01-07 21:26 ` Stephen Boyd
2019-01-07 2:11 ` [PATCH v2 2/5] mfd: qcom-spmi-pmic: use devm_mfd_add_devices instead of devm_of_platform_populate Brian Masney
2019-01-07 10:53 ` Linus Walleij
2019-01-07 11:30 ` Brian Masney
2019-01-07 21:41 ` Stephen Boyd
2019-01-08 10:32 ` Brian Masney
2019-01-07 2:11 ` [PATCH v2 3/5] spmi: pmic-arb: convert to v2 irq interfaces to support hierarchical IRQ chips Brian Masney
2019-01-07 2:11 ` [PATCH v2 4/5] qcom: spmi-gpio: add support for hierarchical IRQ chip Brian Masney
2019-01-07 21:55 ` Stephen Boyd
2019-01-08 10:35 ` Brian Masney [this message]
2019-01-07 2:11 ` [PATCH v2 5/5] ARM: dts: qcom: msm8974: add interrupt controller properties Brian Masney
2019-01-07 23:51 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190108103545.GB3643@basecamp \
--to=masneyb@onstation.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=nicolas.dechesne@linaro.org \
--cc=niklas.cassel@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.