From: Yang Zhong <yang.zhong@intel.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org,
sameo@linux.intel.com, pbonzini@redhat.com, ehabkost@redhat.com,
yang.zhong@intel.com
Subject: Re: [Qemu-devel] [RFC PATCH 23/25] x86_64-softmmu.mak: remove i386-softmmu.mak include
Date: Tue, 8 Jan 2019 18:55:54 +0800 [thread overview]
Message-ID: <20190108105554.GI27840@yangzhon-Virtual> (raw)
In-Reply-To: <d3192ec2-bb58-0fdf-a100-7e885f8d8916@redhat.com>
On Fri, Jan 04, 2019 at 08:58:09PM +0100, Thomas Huth wrote:
> On 2018-12-27 07:34, Yang Zhong wrote:
> > Only keep same boards definitions as i386-softmmu.mak in
> > x86_64-softmmu.mak.
> >
> > Signed-off-by: Yang Zhong <yang.zhong@intel.com>
> > ---
> > default-configs/x86_64-softmmu.mak | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/default-configs/x86_64-softmmu.mak b/default-configs/x86_64-softmmu.mak
> > index 64b2ee2960..0c69c2930c 100644
> > --- a/default-configs/x86_64-softmmu.mak
> > +++ b/default-configs/x86_64-softmmu.mak
> > @@ -1,3 +1,7 @@
> > # Default configuration for x86_64-softmmu
> >
> > -include i386-softmmu.mak
> > +# Boards:
> > +#
> > +CONFIG_ISAPC=y
> > +CONFIG_I440FX=y
> > +CONFIG_Q35=y
>
> Not sure whether this patch is really necessary since the two configs
> are currently really the same. Anyway, in case you want to keep the patch:
>
Thanks for comments, yes, it seems this patch is not useful, i will remove
this patch in next version.
Regards,
Yang
> Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2019-01-08 10:59 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-27 6:33 [Qemu-devel] [RFC PATCH 00/25] Support Kconfig in QEMU Yang Zhong
2018-12-27 6:33 ` [Qemu-devel] [RFC PATCH 01/25] build: actually use CONFIG_PAM Yang Zhong
2019-01-03 14:15 ` Thomas Huth
2019-01-07 11:29 ` Yang Zhong
2018-12-27 6:33 ` [Qemu-devel] [RFC PATCH 02/25] hw/i386/Makefile.objs: Build pc_piix* and pc_q35 boards Yang Zhong
2019-01-03 14:30 ` Thomas Huth
2018-12-27 6:33 ` [Qemu-devel] [RFC PATCH 03/25] minikconfig: add parser skeleton Yang Zhong
2019-01-04 13:36 ` Paolo Bonzini
2018-12-27 6:33 ` [Qemu-devel] [RFC PATCH 04/25] minikconfig: add AST Yang Zhong
2019-01-04 14:13 ` Paolo Bonzini
2019-01-07 12:06 ` Yang Zhong
2018-12-27 6:33 ` [Qemu-devel] [RFC PATCH 05/25] minikconfig: add semantic analysis Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 06/25] hw/display: make edid configurable Yang Zhong
2019-01-03 14:49 ` Thomas Huth
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 07/25] kconfig: introduce kconfig files Yang Zhong
2019-01-03 15:04 ` Thomas Huth
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 08/25] build: switch to Kconfig Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 09/25] ide: express dependencies with Kconfig Yang Zhong
2019-01-03 15:47 ` Thomas Huth
2019-01-08 5:22 ` Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 10/25] build: convert pci.mak to Kconfig Yang Zhong
2019-01-03 16:06 ` Thomas Huth
2019-01-08 5:58 ` Yang Zhong
2019-01-04 13:48 ` Thomas Huth
2019-01-08 7:20 ` Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 11/25] build: convert sound.mak " Yang Zhong
2019-01-04 13:26 ` Thomas Huth
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 12/25] build: convert usb.mak " Yang Zhong
2019-01-04 13:31 ` Thomas Huth
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 13/25] scsi: express dependencies with Kconfig Yang Zhong
2019-01-04 13:38 ` Paolo Bonzini
2019-01-08 7:32 ` Yang Zhong
2019-01-04 13:39 ` Thomas Huth
2019-01-08 8:04 ` Yang Zhong
2019-01-08 11:42 ` Paolo Bonzini
2019-01-11 3:08 ` Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 14/25] bluetooth: " Yang Zhong
2019-01-04 13:41 ` Thomas Huth
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 15/25] isa: express dependencies with kconfig Yang Zhong
2019-01-04 13:55 ` Thomas Huth
2019-01-08 9:08 ` Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 16/25] i386: express dependencies with Kconfig Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 17/25] i2c: " Yang Zhong
2019-01-04 15:30 ` Thomas Huth
2019-01-08 9:15 ` Yang Zhong
2019-01-08 11:46 ` Paolo Bonzini
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 18/25] ptimer: " Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 19/25] edid: express dependencies with kconfig Yang Zhong
2019-01-04 15:35 ` Thomas Huth
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 20/25] hyperv: " Yang Zhong
2019-01-04 15:38 ` Thomas Huth
2019-01-04 19:50 ` Paolo Bonzini
2019-01-08 10:38 ` Yang Zhong
2019-01-08 10:35 ` Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 21/25] virtio: make virtio dependencies with Kconfig Yang Zhong
2019-01-04 19:54 ` Thomas Huth
2019-01-08 10:45 ` Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 22/25] i386-softmmu.mak: remove all CONFIG_* except boards definitions Yang Zhong
2019-01-04 13:59 ` Paolo Bonzini
2019-01-08 10:53 ` Yang Zhong
2019-01-08 11:48 ` Paolo Bonzini
2019-01-11 2:22 ` Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 23/25] x86_64-softmmu.mak: remove i386-softmmu.mak include Yang Zhong
2019-01-04 19:58 ` Thomas Huth
2019-01-08 10:55 ` Yang Zhong [this message]
2019-01-05 15:32 ` Peter Maydell
2019-01-08 10:58 ` Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 24/25] minikconf: implement allyesconfig, allnoconfig, randconfig, defconfig Yang Zhong
2018-12-27 6:34 ` [Qemu-devel] [RFC PATCH 25/25] Makefile: only support defconfig Yang Zhong
2019-01-04 14:02 ` [Qemu-devel] [RFC PATCH 00/25] Support Kconfig in QEMU Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190108105554.GI27840@yangzhon-Virtual \
--to=yang.zhong@intel.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sameo@linux.intel.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.