From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [PATCH 1/3] spapr: Eliminate SPAPR_PCI_2_7_MMIO_WIN_SIZE macro Date: Tue, 8 Jan 2019 10:59:46 +0100 Message-ID: <20190108105946.5fdd8e38.cohuck@redhat.com> References: <20190107193020.21744-1-ehabkost@redhat.com> <20190107193020.21744-2-ehabkost@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ggoAx-00084T-Sl for xen-devel@lists.xenproject.org; Tue, 08 Jan 2019 09:59:59 +0000 In-Reply-To: <20190107193020.21744-2-ehabkost@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Eduardo Habkost Cc: Stefano Stabellini , xen-devel@lists.xenproject.org, David Hildenbrand , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, qemu-ppc@nongnu.org, Marcel Apfelbaum , =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau , Anthony Perard , Paolo Bonzini , David Gibson , Richard Henderson List-Id: xen-devel@lists.xenproject.org T24gTW9uLCAgNyBKYW4gMjAxOSAxNzozMDoxOCAtMDIwMApFZHVhcmRvIEhhYmtvc3QgPGVoYWJr b3N0QHJlZGhhdC5jb20+IHdyb3RlOgoKPiBUaGUgbWFjcm8gaXMgb25seSB1c2VkIGluIG9uZSBw bGFjZSwgd2hlcmUgdGhlIHB1cnBvc2Ugb2YgdGhlCj4gdmFsdWUgaXMgb2J2aW91cy4gIEVsaW1p bmF0ZSB0aGUgbWFjcm8gc28gd2UgZG9uJ3QgbmVlZCB0byByZWx5Cj4gb24gc3RyaW5naWZ5KCku Cj4gCj4gU2lnbmVkLW9mZi1ieTogRWR1YXJkbyBIYWJrb3N0IDxlaGFia29zdEByZWRoYXQuY29t Pgo+IC0tLQo+ICBpbmNsdWRlL2h3L3BjaS1ob3N0L3NwYXByLmggfCAxIC0KPiAgaHcvcHBjL3Nw YXByLmMgICAgICAgICAgICAgIHwgMiArLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDEgaW5zZXJ0aW9u KCspLCAyIGRlbGV0aW9ucygtKQoKUmV2aWV3ZWQtYnk6IENvcm5lbGlhIEh1Y2sgPGNvaHVja0By ZWRoYXQuY29tPgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcK aHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:33951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggoB0-0004DL-T7 for qemu-devel@nongnu.org; Tue, 08 Jan 2019 05:00:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggoAx-0005am-Lh for qemu-devel@nongnu.org; Tue, 08 Jan 2019 05:00:02 -0500 Date: Tue, 8 Jan 2019 10:59:46 +0100 From: Cornelia Huck Message-ID: <20190108105946.5fdd8e38.cohuck@redhat.com> In-Reply-To: <20190107193020.21744-2-ehabkost@redhat.com> References: <20190107193020.21744-1-ehabkost@redhat.com> <20190107193020.21744-2-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/3] spapr: Eliminate SPAPR_PCI_2_7_MMIO_WIN_SIZE macro List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, David Hildenbrand , Paolo Bonzini , Christian Borntraeger , =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau , Richard Henderson , David Gibson , qemu-s390x@nongnu.org, Halil Pasic , Anthony Perard , Marcel Apfelbaum , Stefano Stabellini , "Michael S. Tsirkin" , qemu-ppc@nongnu.org, xen-devel@lists.xenproject.org On Mon, 7 Jan 2019 17:30:18 -0200 Eduardo Habkost wrote: > The macro is only used in one place, where the purpose of the > value is obvious. Eliminate the macro so we don't need to rely > on stringify(). > > Signed-off-by: Eduardo Habkost > --- > include/hw/pci-host/spapr.h | 1 - > hw/ppc/spapr.c | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Cornelia Huck