From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [PATCH 2/3] machine: Eliminate unnecessary stringify() usage Date: Tue, 8 Jan 2019 11:03:38 +0100 Message-ID: <20190108110338.60749ad6.cohuck@redhat.com> References: <20190107193020.21744-1-ehabkost@redhat.com> <20190107193020.21744-3-ehabkost@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ggoEj-0000Ps-TX for xen-devel@lists.xenproject.org; Tue, 08 Jan 2019 10:03:53 +0000 In-Reply-To: <20190107193020.21744-3-ehabkost@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Eduardo Habkost Cc: Stefano Stabellini , xen-devel@lists.xenproject.org, David Hildenbrand , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, qemu-ppc@nongnu.org, Marcel Apfelbaum , =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau , Anthony Perard , Paolo Bonzini , David Gibson , Richard Henderson List-Id: xen-devel@lists.xenproject.org T24gTW9uLCAgNyBKYW4gMjAxOSAxNzozMDoxOSAtMDIwMApFZHVhcmRvIEhhYmtvc3QgPGVoYWJr b3N0QHJlZGhhdC5jb20+IHdyb3RlOgoKPiBzdHJpbmdpZnkoKSBpcyB1c2VmdWwgd2hlbiB3ZSBu ZWVkIHRvIHVzZSBtYWNyb3MgaW4gY29tcGF0X3Byb3BzCj4gKGxpa2Ugd2hlbiB3ZSBzZXQgdmly dGlvLWJhbG9vbi1wY2kuY2xhc3M9UENJX0NMQVNTX01FTU9SWV9SQU0gYXQKPiBwY19pNDQwZnhf MV8wX21hY2hpbmVfb3B0aW9ucygpKSwgYnV0IGl0IGlzIHBvaW50bGVzcyB3aGVuIHdlIGFyZQo+ IGFscmVhZHkgcHJvdmlkaW5nIGEgbnVtYmVyIGxpdGVyYWwuCj4gCj4gUmVwbGFjZSBzdHJpbmdp ZnkoKSB3aXRoIHN0cmluZyBsaXRlcmFscyB3aGVuIGFwcHJvcHJpYXRlLgo+IAo+IFNpZ25lZC1v ZmYtYnk6IEVkdWFyZG8gSGFia29zdCA8ZWhhYmtvc3RAcmVkaGF0LmNvbT4KPiAtLS0KPiAgaHcv Y29yZS9tYWNoaW5lLmMgfCAgOCArKy0tCj4gIGh3L2kzODYvcGMuYyAgICAgIHwgOTQgKysrKysr KysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgaHcvaTM4Ni9wY19w aWl4LmMgfCAzMCArKysrKysrLS0tLS0tLS0KPiAgaHcvcHBjL3NwYXByLmMgICAgfCAgMiArLQo+ ICA0IGZpbGVzIGNoYW5nZWQsIDY3IGluc2VydGlvbnMoKyksIDY3IGRlbGV0aW9ucygtKQoKUmV2 aWV3ZWQtYnk6IENvcm5lbGlhIEh1Y2sgPGNvaHVja0ByZWRoYXQuY29tPgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlz dApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0 Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:35161) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggoEp-0005Qw-3I for qemu-devel@nongnu.org; Tue, 08 Jan 2019 05:04:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggoEm-00052K-Si for qemu-devel@nongnu.org; Tue, 08 Jan 2019 05:03:58 -0500 Date: Tue, 8 Jan 2019 11:03:38 +0100 From: Cornelia Huck Message-ID: <20190108110338.60749ad6.cohuck@redhat.com> In-Reply-To: <20190107193020.21744-3-ehabkost@redhat.com> References: <20190107193020.21744-1-ehabkost@redhat.com> <20190107193020.21744-3-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] machine: Eliminate unnecessary stringify() usage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, David Hildenbrand , Paolo Bonzini , Christian Borntraeger , =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau , Richard Henderson , David Gibson , qemu-s390x@nongnu.org, Halil Pasic , Anthony Perard , Marcel Apfelbaum , Stefano Stabellini , "Michael S. Tsirkin" , qemu-ppc@nongnu.org, xen-devel@lists.xenproject.org On Mon, 7 Jan 2019 17:30:19 -0200 Eduardo Habkost wrote: > stringify() is useful when we need to use macros in compat_props > (like when we set virtio-baloon-pci.class=PCI_CLASS_MEMORY_RAM at > pc_i440fx_1_0_machine_options()), but it is pointless when we are > already providing a number literal. > > Replace stringify() with string literals when appropriate. > > Signed-off-by: Eduardo Habkost > --- > hw/core/machine.c | 8 ++-- > hw/i386/pc.c | 94 +++++++++++++++++++++++------------------------ > hw/i386/pc_piix.c | 30 +++++++-------- > hw/ppc/spapr.c | 2 +- > 4 files changed, 67 insertions(+), 67 deletions(-) Reviewed-by: Cornelia Huck