From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [Qemu-devel] [PATCH 3/3] machine: Use shorter format for GlobalProperty arrays Date: Tue, 8 Jan 2019 11:20:12 +0100 Message-ID: <20190108112012.78f3dbb9.cohuck@redhat.com> References: <20190107193020.21744-1-ehabkost@redhat.com> <20190107193020.21744-4-ehabkost@redhat.com> <20190108064543.asg63onrb3hpripf@sirius.home.kraxel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ggoUe-0001yl-O1 for xen-devel@lists.xenproject.org; Tue, 08 Jan 2019 10:20:20 +0000 In-Reply-To: <20190108064543.asg63onrb3hpripf@sirius.home.kraxel.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Gerd Hoffmann Cc: Stefano Stabellini , Eduardo Habkost , David Hildenbrand , Richard Henderson , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, qemu-ppc@nongnu.org, Paolo Bonzini , Anthony Perard , =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau , xen-devel@lists.xenproject.org, David Gibson List-Id: xen-devel@lists.xenproject.org T24gVHVlLCA4IEphbiAyMDE5IDA3OjQ1OjQzICswMTAwCkdlcmQgSG9mZm1hbm4gPGtyYXhlbEBy ZWRoYXQuY29tPiB3cm90ZToKCj4gICBIaSwKPiAKPiA+ICsgICAgeyAibWlncmF0aW9uIiwgImRl Y29tcHJlc3MtZXJyb3ItY2hlY2siLCAib2ZmIiB9LAo+ID4gKyAgICB7ICJoZGEtYXVkaW8iLCAi dXNlLXRpbWVyIiwgImZhbHNlIiB9LAo+ID4gKyAgICB7ICJjaXJydXMtdmdhIiwgImdsb2JhbC12 bXN0YXRlIiwgInRydWUiIH0sCj4gPiArICAgIHsgIlZHQSIsICJnbG9iYWwtdm1zdGF0ZSIsICJ0 cnVlIiB9LAo+ID4gKyAgICB7ICJ2bXdhcmUtc3ZnYSIsICJnbG9iYWwtdm1zdGF0ZSIsICJ0cnVl IiB9LAo+ID4gKyAgICB7ICJxeGwtdmdhIiwgImdsb2JhbC12bXN0YXRlIiwgInRydWUiIH0sICAK PiAKPiBJJ2QgbGlrZSB0byBoYXZlIHRoZSBmaWVsZHMgYWxpZ25lZC4gIEVzcGVjaWFsbHkgaW4g Y2FzZXMgbGlrZSB0aGlzIG9uZQo+IHdoZXJlIG11bHRpcGxlIGRldmljZXMgZ2V0IHRoZSBzYW1l IHZhbHVlIGFzc2lnbmVkIGl0IG1ha2VzIHRoaW5ncyBtb3JlCj4gcmVhZGFibGU6Cj4gCj4gICAg IHsgIm1pZ3JhdGlvbiIsICAgImRlY29tcHJlc3MtZXJyb3ItY2hlY2siLCAib2ZmIiAgIH0sCj4g ICAgIHsgImhkYS1hdWRpbyIsICAgInVzZS10aW1lciIsICAgICAgICAgICAgICAiZmFsc2UiIH0s Cj4gICAgIHsgImNpcnJ1cy12Z2EiLCAgImdsb2JhbC12bXN0YXRlIiwgICAgICAgICAidHJ1ZSIg IH0sCj4gICAgIHsgIlZHQSIsICAgICAgICAgImdsb2JhbC12bXN0YXRlIiwgICAgICAgICAidHJ1 ZSIgIH0sCj4gICAgIHsgInZtd2FyZS1zdmdhIiwgImdsb2JhbC12bXN0YXRlIiwgICAgICAgICAi dHJ1ZSIgIH0sCj4gICAgIHsgInF4bC12Z2EiLCAgICAgImdsb2JhbC12bXN0YXRlIiwgICAgICAg ICAidHJ1ZSIgIH0sCj4gCj4gdGhhbmtzLAo+ICAgR2VyZAo+IAoKSSdtIGEgYml0IG9uIHRoZSBm ZW5jZSBoZXJlLiBJdCBkb2VzIG1ha2UgdGhpbmdzIG1vcmUgcmVhZGFibGUgKGF0CmxlYXN0IGlu IHlvdXIgZXhhbXBsZSksIGJ1dCBJIGZpbmQgZWRpdGluZyBhbGlnbmVkIHRhYmxlcyBhIGJpdAph bm5veWluZy4gT1RPSCwgdGhhdCB3b24ndCBoYXBwZW4gb2Z0ZW4sIGFueXdheS4KCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5n IGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJv amVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:40266) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggoUp-00025P-S0 for qemu-devel@nongnu.org; Tue, 08 Jan 2019 05:20:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggoUm-0006oE-KX for qemu-devel@nongnu.org; Tue, 08 Jan 2019 05:20:30 -0500 Date: Tue, 8 Jan 2019 11:20:12 +0100 From: Cornelia Huck Message-ID: <20190108112012.78f3dbb9.cohuck@redhat.com> In-Reply-To: <20190108064543.asg63onrb3hpripf@sirius.home.kraxel.org> References: <20190107193020.21744-1-ehabkost@redhat.com> <20190107193020.21744-4-ehabkost@redhat.com> <20190108064543.asg63onrb3hpripf@sirius.home.kraxel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3] machine: Use shorter format for GlobalProperty arrays List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Eduardo Habkost , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, Stefano Stabellini , David Hildenbrand , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, "Michael S. Tsirkin" , =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau , Anthony Perard , Paolo Bonzini , David Gibson , xen-devel@lists.xenproject.org, Richard Henderson On Tue, 8 Jan 2019 07:45:43 +0100 Gerd Hoffmann wrote: > Hi, > > > + { "migration", "decompress-error-check", "off" }, > > + { "hda-audio", "use-timer", "false" }, > > + { "cirrus-vga", "global-vmstate", "true" }, > > + { "VGA", "global-vmstate", "true" }, > > + { "vmware-svga", "global-vmstate", "true" }, > > + { "qxl-vga", "global-vmstate", "true" }, > > I'd like to have the fields aligned. Especially in cases like this one > where multiple devices get the same value assigned it makes things more > readable: > > { "migration", "decompress-error-check", "off" }, > { "hda-audio", "use-timer", "false" }, > { "cirrus-vga", "global-vmstate", "true" }, > { "VGA", "global-vmstate", "true" }, > { "vmware-svga", "global-vmstate", "true" }, > { "qxl-vga", "global-vmstate", "true" }, > > thanks, > Gerd > I'm a bit on the fence here. It does make things more readable (at least in your example), but I find editing aligned tables a bit annoying. OTOH, that won't happen often, anyway.