From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [PATCH 3/3] machine: Use shorter format for GlobalProperty arrays Date: Tue, 8 Jan 2019 11:21:09 +0100 Message-ID: <20190108112109.41a93a75.cohuck@redhat.com> References: <20190107193020.21744-1-ehabkost@redhat.com> <20190107193020.21744-4-ehabkost@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ggoVe-00024y-4f for xen-devel@lists.xenproject.org; Tue, 08 Jan 2019 10:21:22 +0000 In-Reply-To: <20190107193020.21744-4-ehabkost@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Eduardo Habkost Cc: Stefano Stabellini , xen-devel@lists.xenproject.org, David Hildenbrand , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, qemu-ppc@nongnu.org, Marcel Apfelbaum , =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau , Anthony Perard , Paolo Bonzini , David Gibson , Richard Henderson List-Id: xen-devel@lists.xenproject.org T24gTW9uLCAgNyBKYW4gMjAxOSAxNzozMDoyMCAtMDIwMApFZHVhcmRvIEhhYmtvc3QgPGVoYWJr b3N0QHJlZGhhdC5jb20+IHdyb3RlOgoKPiBJbnN0ZWFkIG9mIHZlcmJvc2UgYXJyYXlzIHdpdGgg NCBsaW5lcyBmb3IgZWFjaCBlbnRyeSwgbWFrZSBlYWNoCj4gZW50cnkgdGFrZSBvbmx5IG9uZSBs aW5lLiAgVGhpcyBtYWtlcyBsb25nIGFycmF5cyB0aGF0IGNvdWxkbid0Cj4gZml0IGluIHRoZSBz Y3JlZW4gYmVjb21lIHNob3J0IGFuZCByZWFkYWJsZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBFZHVh cmRvIEhhYmtvc3QgPGVoYWJrb3N0QHJlZGhhdC5jb20+Cj4gLS0tCj4gIGluY2x1ZGUvaHcvaTM4 Ni9wYy5oICAgICAgIHwgIDE4ICstCj4gIGh3L2NvcmUvbWFjaGluZS5jICAgICAgICAgIHwgMzM4 ICsrKystLS0tLS0tLS0tLS0tCj4gIGh3L2kzODYvcGMuYyAgICAgICAgICAgICAgIHwgNzIwICsr KysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgaHcvaTM4Ni9wY19waWl4LmMg ICAgICAgICAgfCAxOTIgKystLS0tLS0tLQo+ICBody9wcGMvc3BhcHIuYyAgICAgICAgICAgICB8 ICA3MiArLS0tCj4gIGh3L3MzOTB4L3MzOTAtdmlydGlvLWNjdy5jIHwgIDc1ICstLS0KPiAgaHcv eGVuL3hlbi1jb21tb24uYyAgICAgICAgfCAgMTggKy0KPiAgNyBmaWxlcyBjaGFuZ2VkLCAyNjUg aW5zZXJ0aW9ucygrKSwgMTE2OCBkZWxldGlvbnMoLSkKPiAKCiguLi4pCgo+IGRpZmYgLS1naXQg YS9ody9zMzkweC9zMzkwLXZpcnRpby1jY3cuYyBiL2h3L3MzOTB4L3MzOTAtdmlydGlvLWNjdy5j Cj4gaW5kZXggYzczNzUwNzA1My4uODExZmRmOTEzZCAxMDA2NDQKPiAtLS0gYS9ody9zMzkweC9z MzkwLXZpcnRpby1jY3cuYwo+ICsrKyBiL2h3L3MzOTB4L3MzOTAtdmlydGlvLWNjdy5jCgooLi4u KQoKPiBAQCAtODEwLDE1ICs3OTgsOCBAQCBzdGF0aWMgdm9pZCBjY3dfbWFjaGluZV8yXzZfY2xh c3Nfb3B0aW9ucyhNYWNoaW5lQ2xhc3MgKm1jKQo+ICB7Cj4gICAgICBTMzkwQ2N3TWFjaGluZUNs YXNzICpzMzkwbWMgPSBTMzkwX01BQ0hJTkVfQ0xBU1MobWMpOwo+ICAgICAgc3RhdGljIEdsb2Jh bFByb3BlcnR5IGNvbXBhdFtdID0gewo+IC0gICAgICAgIHsKPiAtICAgICAgICAgICAgLmRyaXZl ciAgID0gVFlQRV9TMzkwX0lQTCwKPiAtICAgICAgICAgICAgLnByb3BlcnR5ID0gImlwbGJleHRf bWlncmF0aW9uIiwKPiAtICAgICAgICAgICAgLnZhbHVlICAgID0gIm9mZiIsCj4gLSAgICAgICAg fSwgewo+IC0gICAgICAgICAgICAuZHJpdmVyICAgPSBUWVBFX1ZJUlRVQUxfQ1NTX0JSSURHRSwK PiAtICAgICAgICAgICAgLnByb3BlcnR5ID0gImNzc19kZXZfcGF0aCIsCj4gLSAgICAgICAgICAg IC52YWx1ZSAgICA9ICJvZmYiLAo+IC0gICAgICAgIH0sCj4gKyAgICAgICAgeyBUWVBFX1MzOTBf SVBMLCAiaXBsYmV4dF9taWdyYXRpb24iLCAib2ZmIiwgfSwKPiArICAgICAgICAgeyBUWVBFX1ZJ UlRVQUxfQ1NTX0JSSURHRSwgImNzc19kZXZfcGF0aCIsICJvZmYiLCB9LAoKVGhlIGluZGVudGF0 aW9uIGxvb2tzIG9mZiBoZXJlLgoKPiAgICAgIH07Cj4gIAo+ICAgICAgczM5MG1jLT5yaV9hbGxv d2VkID0gZmFsc2U7CgooLi4uKQoKV2l0aCBvciB3aXRob3V0IGFsaWdubWVudDoKClJldmlld2Vk LWJ5OiBDb3JuZWxpYSBIdWNrIDxjb2h1Y2tAcmVkaGF0LmNvbT4KCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVu LWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcv bWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:40576) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggoVi-0002fV-2Y for qemu-devel@nongnu.org; Tue, 08 Jan 2019 05:21:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggoVh-0000jS-4S for qemu-devel@nongnu.org; Tue, 08 Jan 2019 05:21:26 -0500 Date: Tue, 8 Jan 2019 11:21:09 +0100 From: Cornelia Huck Message-ID: <20190108112109.41a93a75.cohuck@redhat.com> In-Reply-To: <20190107193020.21744-4-ehabkost@redhat.com> References: <20190107193020.21744-1-ehabkost@redhat.com> <20190107193020.21744-4-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3] machine: Use shorter format for GlobalProperty arrays List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, David Hildenbrand , Paolo Bonzini , Christian Borntraeger , =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau , Richard Henderson , David Gibson , qemu-s390x@nongnu.org, Halil Pasic , Anthony Perard , Marcel Apfelbaum , Stefano Stabellini , "Michael S. Tsirkin" , qemu-ppc@nongnu.org, xen-devel@lists.xenproject.org On Mon, 7 Jan 2019 17:30:20 -0200 Eduardo Habkost wrote: > Instead of verbose arrays with 4 lines for each entry, make each > entry take only one line. This makes long arrays that couldn't > fit in the screen become short and readable. > > Signed-off-by: Eduardo Habkost > --- > include/hw/i386/pc.h | 18 +- > hw/core/machine.c | 338 ++++------------- > hw/i386/pc.c | 720 +++++++------------------------------ > hw/i386/pc_piix.c | 192 ++-------- > hw/ppc/spapr.c | 72 +--- > hw/s390x/s390-virtio-ccw.c | 75 +--- > hw/xen/xen-common.c | 18 +- > 7 files changed, 265 insertions(+), 1168 deletions(-) > (...) > diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c > index c737507053..811fdf913d 100644 > --- a/hw/s390x/s390-virtio-ccw.c > +++ b/hw/s390x/s390-virtio-ccw.c (...) > @@ -810,15 +798,8 @@ static void ccw_machine_2_6_class_options(MachineClass *mc) > { > S390CcwMachineClass *s390mc = S390_MACHINE_CLASS(mc); > static GlobalProperty compat[] = { > - { > - .driver = TYPE_S390_IPL, > - .property = "iplbext_migration", > - .value = "off", > - }, { > - .driver = TYPE_VIRTUAL_CSS_BRIDGE, > - .property = "css_dev_path", > - .value = "off", > - }, > + { TYPE_S390_IPL, "iplbext_migration", "off", }, > + { TYPE_VIRTUAL_CSS_BRIDGE, "css_dev_path", "off", }, The indentation looks off here. > }; > > s390mc->ri_allowed = false; (...) With or without alignment: Reviewed-by: Cornelia Huck