All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Paul Durrant <Paul.Durrant@citrix.com>
Cc: Anthony Perard <anthony.perard@citrix.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"qemu-block@nongnu.org" <qemu-block@nongnu.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Max Reitz <mreitz@redhat.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [Qemu-devel] [PATCH v7 16/18] xen: automatically create XenBlockDevice-s
Date: Tue, 8 Jan 2019 13:53:21 +0100	[thread overview]
Message-ID: <20190108125321.GD11492@linux.fritz.box> (raw)
In-Reply-To: <da727b0b8a9a4f9baa47a660298a9cba@AMSPEX02CL03.citrite.net>

Am 04.01.2019 um 17:40 hat Paul Durrant geschrieben:
> > -----Original Message-----
> > From: Anthony PERARD [mailto:anthony.perard@citrix.com]
> > Sent: 04 January 2019 16:31
> > To: Paul Durrant <Paul.Durrant@citrix.com>
> > Cc: qemu-devel@nongnu.org; qemu-block@nongnu.org; xen-
> > devel@lists.xenproject.org; Kevin Wolf <kwolf@redhat.com>; Max Reitz
> > <mreitz@redhat.com>; Stefano Stabellini <sstabellini@kernel.org>
> > Subject: Re: [PATCH v7 16/18] xen: automatically create XenBlockDevice-s
> > 
> > Almost done, there is one thing left which I believe is an issue.
> > Whenever I attach a raw file to QEMU, it print:
> >     qemu-system-i386: warning: Opening a block device as a file using the
> > 'file' driver is deprecated
> 
> Oh, I'd not noticed that... but then I only use raw files occasionally.

Strictly speaking, this is not about raw (regular) files, but raw block
devices. 'file' is fine for actual regular files, but the protocol
driver for block devices is 'host_device'.

> > raw files should use the "raw" driver, so we aren't done yet.
> 
> Ok. Having a strictly 2-layer stack actually makes things simpler anyway :-)

Using 'raw' there will make the block layer auto-detect the right
protocol layer, so this works. If you want to avoid the second layer,
you'd have to figure out manually whether to use 'file' or
'host_device'.

Kevin

  reply	other threads:[~2019-01-08 12:53 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-20 17:14 [PATCH v7 00/18] Xen PV backend 'qdevification' Paul Durrant
2018-12-20 17:14 ` [Qemu-devel] " Paul Durrant
2018-12-20 17:14 ` [PATCH v7 01/18] xen: re-name XenDevice to XenLegacyDevice Paul Durrant
2018-12-20 17:14   ` [Qemu-devel] " Paul Durrant
2018-12-20 17:14 ` [PATCH v7 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy Paul Durrant
2018-12-20 17:14   ` [Qemu-devel] " Paul Durrant
2018-12-20 17:14 ` [Qemu-devel] [PATCH v7 03/18] xen: introduce 'xen-block', 'xen-disk' and 'xen-cdrom' Paul Durrant
2018-12-20 17:14 ` Paul Durrant
2018-12-20 17:14 ` [PATCH v7 04/18] xen: create xenstore areas for XenDevice-s Paul Durrant
2018-12-20 17:14   ` [Qemu-devel] " Paul Durrant
2018-12-20 17:14 ` [Qemu-devel] [PATCH v7 05/18] xen: add xenstore watcher infrastructure Paul Durrant
2018-12-20 17:14 ` Paul Durrant
2018-12-20 17:14 ` [PATCH v7 06/18] xen: add grant table interface for XenDevice-s Paul Durrant
2018-12-20 17:14   ` [Qemu-devel] " Paul Durrant
2018-12-20 17:14 ` [PATCH v7 07/18] xen: add event channel " Paul Durrant
2018-12-20 17:14   ` [Qemu-devel] " Paul Durrant
2018-12-20 17:14 ` [PATCH v7 08/18] xen: duplicate xen_disk.c as basis of dataplane/xen-block.c Paul Durrant
2018-12-20 17:14   ` [Qemu-devel] " Paul Durrant
2018-12-20 17:14 ` [PATCH v7 09/18] xen: remove unnecessary code from dataplane/xen-block.c Paul Durrant
2018-12-20 17:14   ` [Qemu-devel] " Paul Durrant
2019-01-04  9:09   ` Paul Durrant
2019-01-04  9:09     ` [Qemu-devel] " Paul Durrant
2019-01-04 15:56   ` Anthony PERARD
2019-01-04 15:56     ` [Qemu-devel] " Anthony PERARD
2018-12-20 17:14 ` [PATCH v7 10/18] xen: add header and build dataplane/xen-block.c Paul Durrant
2018-12-20 17:14   ` [Qemu-devel] " Paul Durrant
2018-12-20 17:14 ` [PATCH v7 11/18] xen: remove 'XenBlkDev' and 'blkdev' names from dataplane/xen-block Paul Durrant
2018-12-20 17:14   ` [Qemu-devel] " Paul Durrant
2018-12-20 17:14 ` [PATCH v7 12/18] xen: remove 'ioreq' struct/varable/field names from dataplane/xen-block.c Paul Durrant
2018-12-20 17:14   ` [Qemu-devel] " Paul Durrant
2018-12-20 17:14 ` [PATCH v7 13/18] xen: purge 'blk' and 'ioreq' from function names in dataplane/xen-block.c Paul Durrant
2018-12-20 17:14 ` [Qemu-devel] " Paul Durrant
2018-12-20 17:14 ` [PATCH v7 14/18] xen: add implementations of xen-block connect and disconnect functions Paul Durrant
2018-12-20 17:14 ` [Qemu-devel] " Paul Durrant
2018-12-20 17:14 ` [PATCH v7 15/18] xen: add a mechanism to automatically create XenDevice-s Paul Durrant
2018-12-20 17:14   ` [Qemu-devel] " Paul Durrant
2018-12-20 17:14 ` [PATCH v7 16/18] xen: automatically create XenBlockDevice-s Paul Durrant
2018-12-20 17:14 ` [Qemu-devel] " Paul Durrant
2019-01-04  9:13   ` Paul Durrant
2019-01-04  9:13     ` [Qemu-devel] " Paul Durrant
2019-01-04 16:31   ` Anthony PERARD
2019-01-04 16:31   ` [Qemu-devel] " Anthony PERARD
2019-01-04 16:40     ` Paul Durrant
2019-01-04 16:40       ` [Qemu-devel] " Paul Durrant
2019-01-08 12:53       ` Kevin Wolf [this message]
2019-01-08 13:07         ` Paul Durrant
2019-01-08 13:07         ` [Qemu-devel] " Paul Durrant
2019-01-08 13:28           ` Anthony PERARD
2019-01-08 13:28           ` [Qemu-devel] " Anthony PERARD
2019-01-08 14:11             ` Paul Durrant
2019-01-08 14:11             ` [Qemu-devel] " Paul Durrant
2019-01-08 14:20               ` Paul Durrant
2019-01-08 14:20               ` [Qemu-devel] " Paul Durrant
2019-01-08 15:25                 ` Kevin Wolf
2019-01-08 15:25                 ` Kevin Wolf
2019-01-08 14:38             ` [Qemu-devel] " Paul Durrant
2019-01-08 14:41               ` Anthony PERARD
2019-01-08 14:41               ` [Qemu-devel] " Anthony PERARD
2019-01-08 14:38             ` Paul Durrant
2019-01-08 12:53       ` Kevin Wolf
2018-12-20 17:14 ` [Qemu-devel] [PATCH v7 17/18] MAINTAINERS: add myself as a Xen maintainer Paul Durrant
2018-12-20 17:14 ` Paul Durrant
2018-12-20 17:14 ` [PATCH v7 18/18] xen: remove the legacy 'xen_disk' backend Paul Durrant
2018-12-20 17:14   ` [Qemu-devel] " Paul Durrant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190108125321.GD11492@linux.fritz.box \
    --to=kwolf@redhat.com \
    --cc=Paul.Durrant@citrix.com \
    --cc=anthony.perard@citrix.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.