From: Cornelia Huck <cohuck@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: qemu-devel@nongnu.org, Fam Zheng <fam@euphon.net>,
qemu-trivial@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
David Hildenbrand <david@redhat.com>,
qemu-ppc@nongnu.org, Thomas Huth <thuth@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
qemu-s390x@nongnu.org, Richard Henderson <rth@twiddle.net>,
Stefano Garzarella <sgarzare@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Halil Pasic <pasic@linux.ibm.com>,
Gerd Hoffmann <kraxel@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-trivial] [PATCH v2 1/3] util/cutils: Move size_to_str() from "qemu-common.h" to "cutils.h"
Date: Tue, 8 Jan 2019 13:44:40 +0100 [thread overview]
Message-ID: <20190108134440.0d52f2c7.cohuck@redhat.com> (raw)
In-Reply-To: <20190104181208.7809-2-philmd@redhat.com>
On Fri, 4 Jan 2019 19:12:06 +0100
Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> The size_to_str() function doesn't need to be in a generic header.
>
> It makes also sens to find this function in the same header than
> the opposite string to size functions: qemu_strtosz*().
> Note than this function is already implemented in util/cutils.c.
>
> Since we introduce a new function in a header, we document it,
> using the previous comment from the source file.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> include/qemu-common.h | 1 -
> include/qemu/cutils.h | 13 +++++++++++++
> qapi/string-output-visitor.c | 2 +-
> util/cutils.c | 6 ------
> 4 files changed, 14 insertions(+), 8 deletions(-)
With the patch description fixed (as noted by Eric):
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2019-01-08 12:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 18:12 [Qemu-trivial] [PATCH v2 0/3] cutils: Cleanup, improve documentation Philippe Mathieu-Daudé
2019-01-04 18:12 ` [Qemu-trivial] [PATCH v2 1/3] util/cutils: Move size_to_str() from "qemu-common.h" to "cutils.h" Philippe Mathieu-Daudé
2019-01-04 19:45 ` [Qemu-trivial] [Qemu-devel] " Eric Blake
2019-01-07 0:39 ` [Qemu-trivial] " David Gibson
2019-01-07 8:59 ` Stefano Garzarella
2019-01-08 12:44 ` Cornelia Huck [this message]
2019-01-30 10:22 ` Laurent Vivier
2019-01-04 18:12 ` [Qemu-trivial] [PATCH v2 2/3] util/cutils: Move ctype macros " Philippe Mathieu-Daudé
2019-01-04 20:15 ` [Qemu-trivial] [Qemu-devel] " Eric Blake
2019-01-08 12:56 ` Cornelia Huck
2019-01-07 0:40 ` [Qemu-trivial] " David Gibson
2019-01-30 10:24 ` Laurent Vivier
2019-01-30 10:38 ` Laurent Vivier
2019-01-04 18:12 ` [Qemu-trivial] [PATCH v2 3/3] util/cutils: Move function documentations to the header Philippe Mathieu-Daudé
2019-01-04 20:17 ` [Qemu-trivial] [Qemu-devel] " Eric Blake
2019-01-07 13:40 ` Markus Armbruster
2019-01-08 13:00 ` Cornelia Huck
2019-01-07 0:41 ` [Qemu-trivial] " David Gibson
2019-01-07 9:00 ` Stefano Garzarella
2019-01-30 10:26 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190108134440.0d52f2c7.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=armbru@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=fam@euphon.net \
--cc=kraxel@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rth@twiddle.net \
--cc=sgarzare@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.