All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] linux-firmware package : files not copied to TARGET_DIR
Date: Tue, 8 Jan 2019 13:49:21 +0100	[thread overview]
Message-ID: <20190108134921.26e793a6@windsurf> (raw)
In-Reply-To: <c5319275-53e0-f7df-3fdb-a9699160bd1f@gmx.com>

Hello David,

On Tue, 8 Jan 2019 10:43:05 +0100, David Picard wrote:

> The linux-firmware package builds OK. But I have to manually copy the 
> binary blob required by the driver to $TARGET/lib/firmware.

The linux-firmware package is definitely installing files to
$(TARGET_DIR):

ifneq ($(LINUX_FIRMWARE_FILES),)
define LINUX_FIRMWARE_INSTALL_FILES
        cd $(@D) && \
                $(TAR) cf install.tar $(sort $(LINUX_FIRMWARE_FILES)) && \
                $(TAR) xf install.tar -C $(TARGET_DIR)/lib/firmware
endef
endif

ifneq ($(LINUX_FIRMWARE_DIRS),)
# We need to rm-rf the destination directory to avoid copying
# into it in itself, should we re-install the package.
define LINUX_FIRMWARE_INSTALL_DIRS
        $(foreach d,$(LINUX_FIRMWARE_DIRS), \
                rm -rf $(TARGET_DIR)/lib/firmware/$(d); \
                mkdir -p $(dir $(TARGET_DIR)/lib/firmware/$(d)); \
                cp -a $(@D)/$(d) $(TARGET_DIR)/lib/firmware/$(d)$(sep))
endef
endif

Could you describe in more details what you are seeing ? Which
configuration are you using ? Could you post the build log of the
linux-firmware package in your situation ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-01-08 12:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-08  9:43 [Buildroot] linux-firmware package : files not copied to TARGET_DIR David Picard
2019-01-08 12:49 ` Thomas Petazzoni [this message]
2019-01-08 13:17   ` David Picard
2019-01-08 14:39     ` Thomas Petazzoni
2019-01-09  8:00       ` David Picard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190108134921.26e793a6@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.