From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [2/2] EDAC: add ARM Cortex A15 L2 internal asynchronous error detection driver From: Greg Kroah-Hartman Message-Id: <20190108181206.GA3848@kroah.com> Date: Tue, 8 Jan 2019 19:12:06 +0100 To: James Morse Cc: Borislav Petkov , "Wiebe, Wladislav (Nokia - DE/Ulm)" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "mchehab+samsung@kernel.org" , "davem@davemloft.net" , "akpm@linux-foundation.org" , "nicolas.ferre@microchip.com" , "arnd@arndb.de" , "linux-edac@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "mchehab@kernel.org" , "Sverdlin, Alexander (Nokia - DE/Ulm)" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-ID: T24gVHVlLCBKYW4gMDgsIDIwMTkgYXQgMDU6NTc6MjRQTSArMDAwMCwgSmFtZXMgTW9yc2Ugd3Jv dGU6Cj4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZWRhYy9jb3J0ZXhfYTE1X2wyX2FzeW5jX2Vk YWMuYyBiL2RyaXZlcnMvZWRhYy9jb3J0ZXhfYTE1X2wyX2FzeW5jX2VkYWMuYwo+ID4+IG5ldyBm aWxlIG1vZGUgMTAwNjQ0Cj4gPj4gaW5kZXggMDAwMDAwMDAwMDAwLi4yNjI1MjU2OGU5NjEKPiA+ PiAtLS0gL2Rldi9udWxsCj4gPj4gKysrIGIvZHJpdmVycy9lZGFjL2NvcnRleF9hMTVfbDJfYXN5 bmNfZWRhYy5jCj4gPj4gQEAgLTAsMCArMSwxMzQgQEAKPiA+PiArLy8gU1BEWC1MaWNlbnNlLUlk ZW50aWZpZXI6IEdQTC0yLjAKPiA+PiArLyoKPiA+PiArICogQ29weXJpZ2h0IChDKSAyMDE4IE5v a2lhIENvcnBvcmF0aW9uCj4gCj4gKGJvaWxlciBwbGF0ZSBub3QgbmVlZGVkIHdpdGggdGhlIFNQ RFggaGVhZGVyKQoKTm90IHRydWUgYXQgYWxsLiAgQ29weXJpZ2h0IGlzIG5vdCB0aGUgc2FtZSB0 aGluZyBhcyBhbiBTUERYIGxpY2Vuc2UKaWRlbnRpZmllciBpbiBhbnkgd2F5LCBzaGFwZSwgb3Ig Zm9ybS4gIEFzLWlzLCB0aGlzIGlzIGp1c3QgZmluZS4KCk5vdyBJIHdpbGwgbm90IGdvIGludG8g dGhlIGlzc3VlcyB3aGVyZSBhICJDb3B5cmlnaHQuLi4iIGxpbmUgcmVhbGx5Cm1lYW5zIG5vdGhp bmcgYXQgYWxsIGFueW1vcmUsIGFzIGxhd3llcnMgbGlrZSB0byBjYXJnby1jdWx0IHdvcnNlIHRo YW4KcHJvZ3JhbW1lcnMgZG8sIHNvIGl0J3MgZ29vZCB0byBoYXZlIHRob3NlIGxpbmVzIHRoZXJl IGp1c3QgdG8gbWFrZSB0aGVtCmhhcHB5IDopCgp0aGFua3MsCgpncmVnIGstaAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A4BEC43387 for ; Tue, 8 Jan 2019 18:12:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41D22206C0 for ; Tue, 8 Jan 2019 18:12:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RdRqIw/g"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="eLxsFTEE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41D22206C0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Cb2oMPgEtkGFkkcuT8nZPNoBNjTAr+mBEvaEd1VRD+U=; b=RdRqIw/gHW2aHv X7KfliCOCViOBaze8WWgbKE+SAGlmP7BL4hR3jjnomg8ubw8K4P1miB8UPkzFmoSso9gLRfOSz+4j jLR/ksZ1IkDemNXG9gY6oGDPL+hCDahIbCQohV0srC1XAgSee8z1cIGNhlrwZ+AoDL/ZGgNS/WLSM JXHI8zXG5jeqtPq1/0g7Q1IKMfoGAMOcAsrTqPYTetQk7P0kj3VkJLyBpoC/5133TEpnTfB2Lyag5 TWx4a5TYx05Kp9hscgKX21SAIebeqowLXFOOzQygoYG6LTjPkNQ7TrbTr4Cno24EG7rOTNidpQBEm ZVktMOPjkb6VhPRXBBCw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ggvrP-00007o-98; Tue, 08 Jan 2019 18:12:19 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ggvrE-0008P9-VP for linux-arm-kernel@lists.infradead.org; Tue, 08 Jan 2019 18:12:11 +0000 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ACBC12070B; Tue, 8 Jan 2019 18:12:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546971128; bh=ycyEbDy7tDUV+zF8jQhABMpd4RbKVUFLuSCweXzfHaw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eLxsFTEEJO9uZtKk+KgSyZzUu20ijjxL/7tVvCbm2Sw3RYPugjdQosgCJFyv6HLUA H01J49FkWLqZUHIFcEkAWM+iS79TtZekj6iBn0uGk+p8bLKZCEbtsBdVJsvQg9/JbU fPjm2jRfH2aumEnuhyJgIWC1Bn+eeym9KWwdcbI8= Date: Tue, 8 Jan 2019 19:12:06 +0100 From: "gregkh@linuxfoundation.org" To: James Morse Subject: Re: [PATCH 2/2] EDAC: add ARM Cortex A15 L2 internal asynchronous error detection driver Message-ID: <20190108181206.GA3848@kroah.com> References: <20190108104204.GA14243@zn.tnic> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.2 (2019-01-07) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190108_101209_438331_9BFD1B0A X-CRM114-Status: GOOD ( 11.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "arnd@arndb.de" , "Sverdlin, Alexander \(Nokia - DE/Ulm\)" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , Borislav Petkov , "mchehab+samsung@kernel.org" , "Wiebe, Wladislav \(Nokia - DE/Ulm\)" , "akpm@linux-foundation.org" , "mchehab@kernel.org" , "davem@davemloft.net" , "linux-arm-kernel@lists.infradead.org" , "linux-edac@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 08, 2019 at 05:57:24PM +0000, James Morse wrote: > >> diff --git a/drivers/edac/cortex_a15_l2_async_edac.c b/drivers/edac/cortex_a15_l2_async_edac.c > >> new file mode 100644 > >> index 000000000000..26252568e961 > >> --- /dev/null > >> +++ b/drivers/edac/cortex_a15_l2_async_edac.c > >> @@ -0,0 +1,134 @@ > >> +// SPDX-License-Identifier: GPL-2.0 > >> +/* > >> + * Copyright (C) 2018 Nokia Corporation > > (boiler plate not needed with the SPDX header) Not true at all. Copyright is not the same thing as an SPDX license identifier in any way, shape, or form. As-is, this is just fine. Now I will not go into the issues where a "Copyright..." line really means nothing at all anymore, as lawyers like to cargo-cult worse than programmers do, so it's good to have those lines there just to make them happy :) thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: "gregkh@linuxfoundation.org" Subject: Re: [PATCH 2/2] EDAC: add ARM Cortex A15 L2 internal asynchronous error detection driver Date: Tue, 8 Jan 2019 19:12:06 +0100 Message-ID: <20190108181206.GA3848@kroah.com> References: <20190108104204.GA14243@zn.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: James Morse Cc: Borislav Petkov , "Wiebe, Wladislav (Nokia - DE/Ulm)" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "mchehab+samsung@kernel.org" , "davem@davemloft.net" , "akpm@linux-foundation.org" , "nicolas.ferre@microchip.com" , "arnd@arndb.de" , "linux-edac@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "mchehab@kernel.org" , "Sverdlin, Alexander (Nokia - DE/Ulm)" , "devicetree@vger.kernel.org" , linux-kernel@vger.ker List-Id: devicetree@vger.kernel.org On Tue, Jan 08, 2019 at 05:57:24PM +0000, James Morse wrote: > >> diff --git a/drivers/edac/cortex_a15_l2_async_edac.c b/drivers/edac/cortex_a15_l2_async_edac.c > >> new file mode 100644 > >> index 000000000000..26252568e961 > >> --- /dev/null > >> +++ b/drivers/edac/cortex_a15_l2_async_edac.c > >> @@ -0,0 +1,134 @@ > >> +// SPDX-License-Identifier: GPL-2.0 > >> +/* > >> + * Copyright (C) 2018 Nokia Corporation > > (boiler plate not needed with the SPDX header) Not true at all. Copyright is not the same thing as an SPDX license identifier in any way, shape, or form. As-is, this is just fine. Now I will not go into the issues where a "Copyright..." line really means nothing at all anymore, as lawyers like to cargo-cult worse than programmers do, so it's good to have those lines there just to make them happy :) thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54293C43387 for ; Tue, 8 Jan 2019 18:12:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 28CA9206C0 for ; Tue, 8 Jan 2019 18:12:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546971131; bh=ycyEbDy7tDUV+zF8jQhABMpd4RbKVUFLuSCweXzfHaw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=vOmFFox0wBckjw0at0dVu3QmmwRLTPc/TI3dkk+LPUGT1MyMsG1or0roUYFgUdEyG ej+ERpSTbbi0hPTt4FILHVdl6h1uFC34xXTlZNoz+P2sXJOmexcyrNKpsVXyeGzjoH rmyNGcIwwKBwYrCz0LzYOicf3NAq2gQHdfFdnvYI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729327AbfAHSMK (ORCPT ); Tue, 8 Jan 2019 13:12:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:50898 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728587AbfAHSMI (ORCPT ); Tue, 8 Jan 2019 13:12:08 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ACBC12070B; Tue, 8 Jan 2019 18:12:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546971128; bh=ycyEbDy7tDUV+zF8jQhABMpd4RbKVUFLuSCweXzfHaw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eLxsFTEEJO9uZtKk+KgSyZzUu20ijjxL/7tVvCbm2Sw3RYPugjdQosgCJFyv6HLUA H01J49FkWLqZUHIFcEkAWM+iS79TtZekj6iBn0uGk+p8bLKZCEbtsBdVJsvQg9/JbU fPjm2jRfH2aumEnuhyJgIWC1Bn+eeym9KWwdcbI8= Date: Tue, 8 Jan 2019 19:12:06 +0100 From: "gregkh@linuxfoundation.org" To: James Morse Cc: Borislav Petkov , "Wiebe, Wladislav (Nokia - DE/Ulm)" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "mchehab+samsung@kernel.org" , "davem@davemloft.net" , "akpm@linux-foundation.org" , "nicolas.ferre@microchip.com" , "arnd@arndb.de" , "linux-edac@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "mchehab@kernel.org" , "Sverdlin, Alexander (Nokia - DE/Ulm)" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/2] EDAC: add ARM Cortex A15 L2 internal asynchronous error detection driver Message-ID: <20190108181206.GA3848@kroah.com> References: <20190108104204.GA14243@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.2 (2019-01-07) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 08, 2019 at 05:57:24PM +0000, James Morse wrote: > >> diff --git a/drivers/edac/cortex_a15_l2_async_edac.c b/drivers/edac/cortex_a15_l2_async_edac.c > >> new file mode 100644 > >> index 000000000000..26252568e961 > >> --- /dev/null > >> +++ b/drivers/edac/cortex_a15_l2_async_edac.c > >> @@ -0,0 +1,134 @@ > >> +// SPDX-License-Identifier: GPL-2.0 > >> +/* > >> + * Copyright (C) 2018 Nokia Corporation > > (boiler plate not needed with the SPDX header) Not true at all. Copyright is not the same thing as an SPDX license identifier in any way, shape, or form. As-is, this is just fine. Now I will not go into the issues where a "Copyright..." line really means nothing at all anymore, as lawyers like to cargo-cult worse than programmers do, so it's good to have those lines there just to make them happy :) thanks, greg k-h