From: Stephen Hemminger <stephen@networkplumber.org>
To: Jiayu Hu <jiayu.hu@intel.com>
Cc: dev@dpdk.org, konstantin.ananyev@intel.com,
mb@smartsharesystems.com, thomas@monjalon.net,
vipin.varghese@intel.com, stable@dpdk.org
Subject: Re: [PATCH v5] doc: add GRO API limitations in prog_guide
Date: Wed, 9 Jan 2019 10:20:14 -0800 [thread overview]
Message-ID: <20190109102014.41c685b5@hermes.lan> (raw)
In-Reply-To: <1547021995-14231-1-git-send-email-jiayu.hu@intel.com>
O be merged.
> +
> +GRO Library Limitations
> +-----------------------
> +
> +- GRO library uses the values of MBUF->l2_len/l3_len/l4_len/
> + outer_l2_len/outer_l3_len to get protocol headers for the
> + input packet, rather than parsing the packet header. Therefore,
> + before call GRO APIs to merge packets, user applications
> + must set MBUF->l2_len/l3_len/l4_len/outer_l2_len/outer_l3_len
> + to the same values as the protocol headers of the packet.
> +
Since these length values are critical to other functionality
why not require all poll mode drivers to set them.
Many poll mode drivers call rte_net_get_ptype() on the received
mbuf and it already handles setting this.
One could argue that GRO should just log and die if it
gets malformed data.
next prev parent reply other threads:[~2019-01-09 18:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 4:25 [PATCH] doc: add GRO API requirement in prog_guide Jiayu Hu
2018-12-26 4:04 ` [PATCH v2] doc: add GRO API limitations " Jiayu Hu
2019-01-04 7:16 ` [PATCH v3] " Jiayu Hu
2019-01-09 3:00 ` [PATCH V4] " Jiayu Hu
2019-01-09 4:25 ` Varghese, Vipin
2019-01-09 4:27 ` Varghese, Vipin
2019-01-09 5:18 ` Hu, Jiayu
2019-01-09 8:19 ` [PATCH v5] " Jiayu Hu
2019-01-09 18:20 ` Stephen Hemminger [this message]
2019-01-09 18:40 ` Ananyev, Konstantin
2019-01-09 21:31 ` Morten Brørup
2019-01-10 8:06 ` Hu, Jiayu
2019-01-10 8:28 ` Morten Brørup
2019-01-16 2:13 ` [PATCH v6] doc: add GRO " Jiayu Hu
2019-01-16 9:50 ` Ananyev, Konstantin
2019-01-17 22:08 ` Thomas Monjalon
2019-01-17 13:55 ` Kovacevic, Marko
2019-01-17 22:08 ` [dpdk-stable] " Thomas Monjalon
2019-01-04 19:35 ` [PATCH] doc: add GRO API requirement " Stephen Hemminger
2019-01-08 2:35 ` Hu, Jiayu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190109102014.41c685b5@hermes.lan \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=mb@smartsharesystems.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=vipin.varghese@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.