From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme-multipath: drop optimization for static ANA group IDs
Date: Wed, 9 Jan 2019 19:43:00 +0100 [thread overview]
Message-ID: <20190109184300.GC22070@lst.de> (raw)
In-Reply-To: <20190109084515.82076-1-hare@suse.de>
On Wed, Jan 09, 2019@09:45:15AM +0100, Hannes Reinecke wrote:
> Bit 6 in the ANACAP field is used to indicate that the ANA group ID
> doesn't change while the namespace is attached to the controller.
> There is an optimisation in the code to only allocate space
> for the ANA group header, as the namespace list won't change and
> hence would not need to be refreshed.
> However, this optimisation was never carried over to the actual
> workflow, which always assumes that the buffer is large enough
> to hold the ANA header _and_ the namespace list.
> So drop this optimisation and always allocate enough space.
Isn't the real bug that we always clear groups_only in nvme_ana_work,
and we could simply make the conditional instead?
next prev parent reply other threads:[~2019-01-09 18:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 8:45 [PATCH] nvme-multipath: drop optimization for static ANA group IDs Hannes Reinecke
2019-01-09 18:43 ` Christoph Hellwig [this message]
2019-01-15 5:51 ` Christoph Hellwig
2019-01-19 13:19 ` Christoph Hellwig
2019-01-21 9:23 ` Sagi Grimberg
2019-01-21 13:50 ` Christoph Hellwig
2019-01-21 17:50 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190109184300.GC22070@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.