From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/4] drm/gem-fb-helper: Add drm_gem_fb_create_with_dirty() Date: Wed, 9 Jan 2019 21:46:42 +0100 Message-ID: <20190109204642.GW21184@phenom.ffwll.local> References: <20190109174956.43052-1-noralf@tronnes.org> <20190109174956.43052-2-noralf@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9AE1C6F1BD for ; Wed, 9 Jan 2019 20:46:46 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id p6so8481058eds.0 for ; Wed, 09 Jan 2019 12:46:46 -0800 (PST) Content-Disposition: inline In-Reply-To: <20190109174956.43052-2-noralf@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: drawat@vmware.com, david@lechnology.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBKYW4gMDksIDIwMTkgYXQgMDY6NDk6NTNQTSArMDEwMCwgTm9yYWxmIFRyw7hubmVz IHdyb3RlOgo+IFRoaXMgYWRkcyBhIC5mYl9jcmVhdGUgaGVscGVyIHRoYXQgc2V0cyB0aGUgLmRp cnR5IGNhbGxiYWNrIHRvCj4gZHJtX2F0b21pY19oZWxwZXJfZGlydHlmYigpLgo+IAo+IFNpZ25l ZC1vZmYtYnk6IE5vcmFsZiBUcsO4bm5lcyA8bm9yYWxmQHRyb25uZXMub3JnPgo+IC0tLQo+ICBk cml2ZXJzL2dwdS9kcm0vZHJtX2dlbV9mcmFtZWJ1ZmZlcl9oZWxwZXIuYyB8IDQ3ICsrKysrKysr KysrKysrKysrLS0tCj4gIGluY2x1ZGUvZHJtL2RybV9nZW1fZnJhbWVidWZmZXJfaGVscGVyLmgg ICAgIHwgIDMgKysKPiAgMiBmaWxlcyBjaGFuZ2VkLCA0NCBpbnNlcnRpb25zKCspLCA2IGRlbGV0 aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2dlbV9mcmFtZWJ1 ZmZlcl9oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtX2ZyYW1lYnVmZmVyX2hlbHBl ci5jCj4gaW5kZXggYWNiNDY2ZDI1YWZjLi40ZWRkMDI2MWU1MDcgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2RybV9nZW1fZnJhbWVidWZmZXJfaGVscGVyLmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vZHJtX2dlbV9mcmFtZWJ1ZmZlcl9oZWxwZXIuYwo+IEBAIC0xNyw2ICsxNyw3IEBA Cj4gICNpbmNsdWRlIDxkcm0vZHJtUC5oPgo+ICAjaW5jbHVkZSA8ZHJtL2RybV9hdG9taWMuaD4K PiAgI2luY2x1ZGUgPGRybS9kcm1fYXRvbWljX3VhcGkuaD4KPiArI2luY2x1ZGUgPGRybS9kcm1f ZGFtYWdlX2hlbHBlci5oPgo+ICAjaW5jbHVkZSA8ZHJtL2RybV9mYl9oZWxwZXIuaD4KPiAgI2lu Y2x1ZGUgPGRybS9kcm1fZm91cmNjLmg+Cj4gICNpbmNsdWRlIDxkcm0vZHJtX2ZyYW1lYnVmZmVy Lmg+Cj4gQEAgLTEzNiwxMCArMTM3LDkgQEAgRVhQT1JUX1NZTUJPTChkcm1fZ2VtX2ZiX2NyZWF0 ZV9oYW5kbGUpOwo+ICAgKiBAbW9kZV9jbWQ6IE1ldGFkYXRhIGZyb20gdGhlIHVzZXJzcGFjZSBm cmFtZWJ1ZmZlciBjcmVhdGlvbiByZXF1ZXN0Cj4gICAqIEBmdW5jczogdnRhYmxlIHRvIGJlIHVz ZWQgZm9yIHRoZSBuZXcgZnJhbWVidWZmZXIgb2JqZWN0Cj4gICAqCj4gLSAqIFRoaXMgY2FuIGJl IHVzZWQgdG8gc2V0ICZkcm1fZnJhbWVidWZmZXJfZnVuY3MgZm9yIGRyaXZlcnMgdGhhdCBuZWVk IHRoZQo+IC0gKiAmZHJtX2ZyYW1lYnVmZmVyX2Z1bmNzLmRpcnR5IGNhbGxiYWNrLiBVc2UgZHJt X2dlbV9mYl9jcmVhdGUoKSBpZiB5b3UgZG9uJ3QKPiAtICogbmVlZCB0byBjaGFuZ2UgJmRybV9m cmFtZWJ1ZmZlcl9mdW5jcy4KPiAtICogVGhlIGZ1bmN0aW9uIGRvZXMgYnVmZmVyIHNpemUgdmFs aWRhdGlvbi4KPiArICogVGhpcyBmdW5jdGlvbiBjYW4gYmUgdXNlZCB0byBzZXQgJmRybV9mcmFt ZWJ1ZmZlcl9mdW5jcyBmb3IgZHJpdmVycyB0aGF0IG5lZWQKPiArICogY3VzdG9tIGZyYW1lYnVm ZmVyIGNhbGxiYWNrcy4gVXNlIGRybV9nZW1fZmJfY3JlYXRlKCkgaWYgeW91IGRvbid0IG5lZWQg dG8KPiArICogY2hhbmdlICZkcm1fZnJhbWVidWZmZXJfZnVuY3MuIFRoZSBmdW5jdGlvbiBkb2Vz IGJ1ZmZlciBzaXplIHZhbGlkYXRpb24uCj4gICAqCj4gICAqIFJldHVybnM6Cj4gICAqIFBvaW50 ZXIgdG8gYSAmZHJtX2ZyYW1lYnVmZmVyIG9uIHN1Y2Nlc3Mgb3IgYW4gZXJyb3IgcG9pbnRlciBv biBmYWlsdXJlLgo+IEBAIC0yMTUsOCArMjE1LDggQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1f ZnJhbWVidWZmZXJfZnVuY3MgZHJtX2dlbV9mYl9mdW5jcyA9IHsKPiAgICoKPiAgICogSWYgeW91 ciBoYXJkd2FyZSBoYXMgc3BlY2lhbCBhbGlnbm1lbnQgb3IgcGl0Y2ggcmVxdWlyZW1lbnRzIHRo ZXNlIHNob3VsZCBiZQo+ICAgKiBjaGVja2VkIGJlZm9yZSBjYWxsaW5nIHRoaXMgZnVuY3Rpb24u IFRoZSBmdW5jdGlvbiBkb2VzIGJ1ZmZlciBzaXplCj4gLSAqIHZhbGlkYXRpb24uIFVzZSBkcm1f Z2VtX2ZiX2NyZWF0ZV93aXRoX2Z1bmNzKCkgaWYgeW91IG5lZWQgdG8gc2V0Cj4gLSAqICZkcm1f ZnJhbWVidWZmZXJfZnVuY3MuZGlydHkuCj4gKyAqIHZhbGlkYXRpb24uIFVzZSBkcm1fZ2VtX2Zi X2NyZWF0ZV93aXRoX2RpcnR5KCkgaWYgeW91IG5lZWQgZnJhbWVidWZmZXIKPiArICogZmx1c2hp bmcuCj4gICAqCj4gICAqIERyaXZlcnMgY2FuIHVzZSB0aGlzIGFzIHRoZWlyICZkcm1fbW9kZV9j b25maWdfZnVuY3MuZmJfY3JlYXRlIGNhbGxiYWNrLgo+ICAgKiBUaGUgQURERkIyIElPQ1RMIGNh bGxzIGludG8gdGhpcyBjYWxsYmFjay4KPiBAQCAtMjMzLDYgKzIzMyw0MSBAQCBkcm1fZ2VtX2Zi X2NyZWF0ZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGUsCj4g IH0KPiAgRVhQT1JUX1NZTUJPTF9HUEwoZHJtX2dlbV9mYl9jcmVhdGUpOwo+ICAKPiArc3RhdGlj IGNvbnN0IHN0cnVjdCBkcm1fZnJhbWVidWZmZXJfZnVuY3MgZHJtX2dlbV9mYl9mdW5jc19kaXJ0 eWZiID0gewo+ICsJLmRlc3Ryb3kJPSBkcm1fZ2VtX2ZiX2Rlc3Ryb3ksCj4gKwkuY3JlYXRlX2hh bmRsZQk9IGRybV9nZW1fZmJfY3JlYXRlX2hhbmRsZSwKPiArCS5kaXJ0eQkJPSBkcm1fYXRvbWlj X2hlbHBlcl9kaXJ0eWZiLAo+ICt9Owo+ICsKPiArLyoqCj4gKyAqIGRybV9nZW1fZmJfY3JlYXRl X3dpdGhfZGlydHkoKSAtIEhlbHBlciBmdW5jdGlvbiBmb3IgdGhlCj4gKyAqICAgICAgICAgICAg ICAgICAgICAgICAmZHJtX21vZGVfY29uZmlnX2Z1bmNzLmZiX2NyZWF0ZSBjYWxsYmFjawo+ICsg KiBAZGV2OiBEUk0gZGV2aWNlCj4gKyAqIEBmaWxlOiBEUk0gZmlsZSB0aGF0IGhvbGRzIHRoZSBH RU0gaGFuZGxlKHMpIGJhY2tpbmcgdGhlIGZyYW1lYnVmZmVyCj4gKyAqIEBtb2RlX2NtZDogTWV0 YWRhdGEgZnJvbSB0aGUgdXNlcnNwYWNlIGZyYW1lYnVmZmVyIGNyZWF0aW9uIHJlcXVlc3QKPiAr ICoKPiArICogVGhpcyBmdW5jdGlvbiBjcmVhdGVzIGEgbmV3IGZyYW1lYnVmZmVyIG9iamVjdCBk ZXNjcmliZWQgYnkKPiArICogJmRybV9tb2RlX2ZiX2NtZDIuIFRoaXMgZGVzY3JpcHRpb24gaW5j bHVkZXMgaGFuZGxlcyBmb3IgdGhlIGJ1ZmZlcihzKQo+ICsgKiBiYWNraW5nIHRoZSBmcmFtZWJ1 ZmZlci4gZHJtX2F0b21pY19oZWxwZXJfZGlydHlmYigpIGlzIHVzZWQgZm9yIHRoZSBkaXJ0eQo+ ICsgKiBjYWxsYmFjayBnaXZpbmcgZnJhbWVidWZmZXIgZmx1c2hpbmcgdGhyb3VnaCB0aGUgYXRv bWljIG1hY2hpbmVyeS4gVXNlCj4gKyAqIGRybV9nZW1fZmJfY3JlYXRlKCkgaWYgeW91IGRvbid0 IG5lZWQgdGhlIGRpcnR5IGNhbGxiYWNrLgo+ICsgKiBUaGUgZnVuY3Rpb24gZG9lcyBidWZmZXIg c2l6ZSB2YWxpZGF0aW9uLgo+ICsgKgo+ICsgKiBEcml2ZXJzIGNhbiB1c2UgdGhpcyBhcyB0aGVp ciAmZHJtX21vZGVfY29uZmlnX2Z1bmNzLmZiX2NyZWF0ZSBjYWxsYmFjay4KPiArICogVGhlIEFE REZCMiBJT0NUTCBjYWxscyBpbnRvIHRoaXMgY2FsbGJhY2suCgpJIHRoaW5rIHdvdWxkIGJlIGdv b2QgdG8gYWRkOgoKIkRyaXZlcnMgc2hvdWxkIGFsc28gY2FsbCBkcm1fcGxhbmVfZW5hYmxlX2Zi X2RhbWFnZV9jbGlwcygpIG9uIGFsbCBwbGFuZXMKdG8gZW5hYmxlIHVzZXJzcGFjZSB0byB1c2Ug ZGFtYWdlIGNsaXBzIGFsc28gd2l0aCB0aGUgQVRPTUlDIElPQ1RMLiIKCkl0J3MgYSBiaXQgYW5u b3lpbmcgdGhhdCBkcml2ZXJzIGhhdmUgdG8gbWFrZSB0aGF0IHNlcGFyYXRlIGNhbGwgdG9vIChz bwpzb21lIHJpc2sgZm9yIGFjY2lkZW50cyksIGJ1dCBJIGRpZG4ndCBzZWUgYSBnb29kIHdheSB0 byBhdm9pZCB0aGF0LgoKV2l0aCB0aGUgZG9jdW1lbnRhdGlvbiBuaXQsIG9uIHRoZSBlbnRpcmUg c2VyaWVzOgoKQWNrZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+ Cj4gKyAqCj4gKyAqIFJldHVybnM6Cj4gKyAqIFBvaW50ZXIgdG8gYSAmZHJtX2ZyYW1lYnVmZmVy IG9uIHN1Y2Nlc3Mgb3IgYW4gZXJyb3IgcG9pbnRlciBvbiBmYWlsdXJlLgo+ICsgKi8KPiArc3Ry dWN0IGRybV9mcmFtZWJ1ZmZlciAqCj4gK2RybV9nZW1fZmJfY3JlYXRlX3dpdGhfZGlydHkoc3Ry dWN0IGRybV9kZXZpY2UgKmRldiwgc3RydWN0IGRybV9maWxlICpmaWxlLAo+ICsJCQkgICAgIGNv bnN0IHN0cnVjdCBkcm1fbW9kZV9mYl9jbWQyICptb2RlX2NtZCkKPiArewo+ICsJcmV0dXJuIGRy bV9nZW1fZmJfY3JlYXRlX3dpdGhfZnVuY3MoZGV2LCBmaWxlLCBtb2RlX2NtZCwKPiArCQkJCQkg ICAgJmRybV9nZW1fZmJfZnVuY3NfZGlydHlmYik7Cj4gK30KPiArRVhQT1JUX1NZTUJPTF9HUEwo ZHJtX2dlbV9mYl9jcmVhdGVfd2l0aF9kaXJ0eSk7Cj4gKwo+ICAvKioKPiAgICogZHJtX2dlbV9m Yl9wcmVwYXJlX2ZiKCkgLSBQcmVwYXJlIGEgR0VNIGJhY2tlZCBmcmFtZWJ1ZmZlcgo+ICAgKiBA cGxhbmU6IFBsYW5lCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJtL2RybV9nZW1fZnJhbWVidWZm ZXJfaGVscGVyLmggYi9pbmNsdWRlL2RybS9kcm1fZ2VtX2ZyYW1lYnVmZmVyX2hlbHBlci5oCj4g aW5kZXggYTM4ZGU3ZWI1NWI0Li43ZjMwN2U4MzRlZWYgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9k cm0vZHJtX2dlbV9mcmFtZWJ1ZmZlcl9oZWxwZXIuaAo+ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9n ZW1fZnJhbWVidWZmZXJfaGVscGVyLmgKPiBAQCAtMjUsNiArMjUsOSBAQCBkcm1fZ2VtX2ZiX2Ny ZWF0ZV93aXRoX2Z1bmNzKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0cnVjdCBkcm1fZmlsZSAq ZmlsZSwKPiAgc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqCj4gIGRybV9nZW1fZmJfY3JlYXRlKHN0 cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0cnVjdCBkcm1fZmlsZSAqZmlsZSwKPiAgCQkgIGNvbnN0 IHN0cnVjdCBkcm1fbW9kZV9mYl9jbWQyICptb2RlX2NtZCk7Cj4gK3N0cnVjdCBkcm1fZnJhbWVi dWZmZXIgKgo+ICtkcm1fZ2VtX2ZiX2NyZWF0ZV93aXRoX2RpcnR5KHN0cnVjdCBkcm1fZGV2aWNl ICpkZXYsIHN0cnVjdCBkcm1fZmlsZSAqZmlsZSwKPiArCQkJICAgICBjb25zdCBzdHJ1Y3QgZHJt X21vZGVfZmJfY21kMiAqbW9kZV9jbWQpOwo+ICAKPiAgaW50IGRybV9nZW1fZmJfcHJlcGFyZV9m YihzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiAgCQkJICBzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRl ICpzdGF0ZSk7Cj4gLS0gCj4gMi4yMC4xCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdp bmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlz dApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==