From: Tony Lindgren <tony@atomide.com>
To: Vignesh R <vigneshr@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>, Jiri Slaby <jslaby@suse.com>,
Lokesh Vutla <lokeshvutla@ti.com>,
linux-serial@vger.kernel.org, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] serial: 8250_omap: Drop check for of_node
Date: Wed, 9 Jan 2019 13:44:03 -0800 [thread overview]
Message-ID: <20190109214403.GW5544@atomide.com> (raw)
In-Reply-To: <20190109091206.25759-2-vigneshr@ti.com>
* Vignesh R <vigneshr@ti.com> [190109 09:11]:
> 8250_omap is DT only driver so dev->of_node always exists. Drop check
> for existence of valid dev->of_node to simplify omap8250_probe().
That part seems safe to me now.
> --- a/drivers/tty/serial/8250/8250_omap.c
> +++ b/drivers/tty/serial/8250/8250_omap.c
...
> - const struct of_device_id *id;
> -
> - ret = of_alias_get_id(pdev->dev.of_node, "serial");
> -
> - of_property_read_u32(pdev->dev.of_node, "clock-frequency",
> - &up.port.uartclk);
> - priv->wakeirq = irq_of_parse_and_map(pdev->dev.of_node, 1);
> -
> - id = of_match_device(of_match_ptr(omap8250_dt_ids), &pdev->dev);
> - if (id && id->data)
> - priv->habit |= *(u8 *)id->data;
But this part it seems we still need to keep around
as we still have lots of clock-frequency references
in the *.dtsi files. Or am I missing something?
Regards
Tony
next prev parent reply other threads:[~2019-01-09 21:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 9:12 [PATCH 0/3] 8250_omap: use clk APIs to get fclk freqeuncy Vignesh R
2019-01-09 9:12 ` Vignesh R
2019-01-09 9:12 ` [PATCH 1/3] serial: 8250_omap: Drop check for of_node Vignesh R
2019-01-09 9:12 ` Vignesh R
2019-01-09 21:44 ` Tony Lindgren [this message]
2019-01-10 12:07 ` Sebastian Reichel
2019-01-10 13:24 ` Vignesh R
2019-01-10 13:24 ` Vignesh R
2019-01-10 15:27 ` Tony Lindgren
2019-01-09 9:12 ` [PATCH 2/3] dt-bindings: serial: omap_serial: add clocks entry Vignesh R
2019-01-09 9:12 ` Vignesh R
2019-01-21 21:08 ` Rob Herring
2019-01-21 21:08 ` Rob Herring
2019-01-09 9:12 ` [PATCH 3/3] serial: 8250_omap: Use clk_get_rate() to obtain fclk frequency Vignesh R
2019-01-09 9:12 ` Vignesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190109214403.GW5544@atomide.com \
--to=tony@atomide.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.