From: Boris Brezillon <bbrezillon@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Boris Brezillon <boris.brezillon@bootlin.com>,
Maxim Levitsky <maximlevitsky@gmail.com>,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Richard Weinberger <richard@nod.at>,
Marc Gonzalez <marc.w.gonzalez@free.fr>,
Janusz Krzysztofik <jmkrzyszt@gmail.com>,
Stefan Agner <stefan@agner.ch>,
Marek Vasut <marek.vasut@gmail.com>,
Harvey Hunt <harveyhuntnexus@gmail.com>,
linux-mtd@lists.infradead.org,
Miquel Raynal <miquel.raynal@bootlin.com>,
Han Xu <han.xu@nxp.com>, Xiaolei Li <xiaolei.li@mediatek.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v3 15/22] mtd: rawnand: fsmc: Stop implementing ->select_chip()
Date: Wed, 9 Jan 2019 22:52:08 +0100 [thread overview]
Message-ID: <20190109225208.47d95771@bbrezillon> (raw)
In-Reply-To: <CACRpkdbijrpG_r1X+-cNQmyusVC_879az5V2Hiv_Aa-yAz0iow@mail.gmail.com>
On Wed, 9 Jan 2019 22:30:18 +0100
Linus Walleij <linus.walleij@linaro.org> wrote:
> On Wed, Jan 9, 2019 at 9:54 PM Boris Brezillon <bbrezillon@kernel.org> wrote:
> > [Me]
> > > I guess that is normal for FSMC: only one CS. It seems a bit
> > > aggressive to toggle CS on/off between every command like this,
> > > I suspect the FSMC isn't really built for that but shakes apart
> > > or something.
> >
> > Hm, that would be weird. There's indeed timing constraints on the NAND
> > chip side, but none infringing those constraints should not trigger an
> > external abort exception.
>
> The manual contains this (the same bit, just another name than
> in the driver):
>
> PBKEN PC-card/NAND-Flash chip-select enable.
> Enables the corresponding chip-select.
> If a disabled chip-select is accessed, an HRESP = ERROR is generated
> on the AHB bus.
> 0: disabled (default after reset)
> 1: enabled
It's still not clear what this bit does. Do you have access to the CS
pin on the board?
>
> > Can you check which phys range is remapped at
> > 0xcc960000?
>
> No idea how to do that but I'll see if I can figure it out...
print the __iomem values returned by devm_ioremap_resource() and find
the one that matches this address.
next prev parent reply other threads:[~2019-01-09 21:52 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-11 7:55 [PATCH v3 00/22] mtd: rawnand: 3rd batch of cleanup Boris Brezillon
2018-11-11 7:55 ` [PATCH v3 01/22] mtd: rawnand: Stop passing mtd_info objects to internal functions Boris Brezillon
2018-11-11 7:55 ` [PATCH v3 02/22] mtd: rawnand: Reorganize code to avoid forward declarations Boris Brezillon
2018-11-11 7:55 ` [PATCH v3 03/22] mtd: rawnand: legacy: Drop useless test in nand_legacy_set_defaults() Boris Brezillon
2018-11-11 7:55 ` [PATCH v3 04/22] mtd: rawnand: Move nand_exec_op() to internal.h Boris Brezillon
2018-11-11 7:55 ` [PATCH v3 05/22] mtd: rawnand: Remove unused NAND_CONTROLLER_ALLOC flag Boris Brezillon
2018-11-11 7:55 ` [PATCH v3 06/22] mtd: rawnand: ams-delta: Allow this driver to be compiled when COMPILE_TEST=y Boris Brezillon
2018-11-11 7:55 ` [PATCH v3 07/22] mtd: rawnand: ams-delta: Add an SPDX tag to replace the license text Boris Brezillon
2018-11-11 7:55 ` [PATCH v3 08/22] mtd: rawnand: ams-delta: Fix various coding style issues Boris Brezillon
2018-11-11 7:55 ` [PATCH v3 09/22] mtd: rawnand: ams-delta: cleanup ams_delta_init() error path Boris Brezillon
2018-11-11 7:55 ` [PATCH v3 10/22] mtd: rawnand: ams-delta: Check mtd_device_register() return code Boris Brezillon
2018-11-11 7:55 ` [PATCH v3 11/22] mtd: rawnand: ams-delta: Explicitly inherit from nand_controller Boris Brezillon
2018-11-11 7:55 ` [PATCH v3 12/22] mtd: rawnand: Add nand_[de]select_target() helpers Boris Brezillon
2018-11-11 7:55 ` [PATCH v3 13/22] mtd: rawnand: Pass the CS line to be selected in struct nand_operation Boris Brezillon
2018-11-11 7:55 ` [PATCH v3 14/22] mtd: rawnand: Make ->select_chip() optional when ->exec_op() is implemented Boris Brezillon
2018-11-11 7:55 ` [PATCH v3 15/22] mtd: rawnand: fsmc: Stop implementing ->select_chip() Boris Brezillon
2019-01-09 18:18 ` Linus Walleij
2019-01-09 19:44 ` Boris Brezillon
2019-01-09 20:41 ` Linus Walleij
2019-01-09 20:54 ` Boris Brezillon
2019-01-09 21:30 ` Linus Walleij
2019-01-09 21:52 ` Boris Brezillon [this message]
2019-01-09 22:00 ` Linus Walleij
2019-01-09 22:20 ` Marc Gonzalez
2019-01-10 8:32 ` Boris Brezillon
2018-11-11 7:55 ` [PATCH v3 16/22] mtd: rawnand: marvell: " Boris Brezillon
2018-11-11 7:55 ` [PATCH v3 17/22] mtd: rawnand: tegra: " Boris Brezillon
2018-11-11 7:55 ` [PATCH v3 18/22] mtd: rawnand: vf610: " Boris Brezillon
2018-11-11 7:55 ` [PATCH v3 19/22] mtd: rawnand: ams-delta: " Boris Brezillon
2018-11-11 7:55 ` [PATCH v3 20/22] mtd: rawnand: Deprecate the ->select_chip() hook Boris Brezillon
2018-11-11 7:55 ` [PATCH v3 21/22] mtd: rawnand: Move the ->exec_op() method to nand_controller_ops Boris Brezillon
2018-11-11 7:55 ` [PATCH v3 22/22] mtd: rawnand: Move ->setup_data_interface() " Boris Brezillon
2018-11-18 20:47 ` [PATCH v3 00/22] mtd: rawnand: 3rd batch of cleanup Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190109225208.47d95771@bbrezillon \
--to=bbrezillon@kernel.org \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=han.xu@nxp.com \
--cc=harveyhuntnexus@gmail.com \
--cc=jmkrzyszt@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marc.w.gonzalez@free.fr \
--cc=marek.vasut@gmail.com \
--cc=maximlevitsky@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=stefan@agner.ch \
--cc=tudor.ambarus@microchip.com \
--cc=xiaolei.li@mediatek.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.