From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,5/5] usb:cdns3 Add Cadence USB3 DRD Driver From: Greg Kroah-Hartman Message-Id: <20190110065738.GA28817@kroah.com> Date: Thu, 10 Jan 2019 07:57:38 +0100 To: Peter Chen Cc: Pawel Laszczak , devicetree@vger.kernel.org, mark.rutland@arm.com, linux-usb@vger.kernel.org, hdegoede@redhat.com, Heikki Krogerus , andy.shevchenko@gmail.com, robh+dt@kernel.org, rogerq@ti.com, lkml , adouglas@cadence.com, jbergsagel@ti.com, nsekhar@ti.com, nm@ti.com, sureshp@cadence.com, peter.chen@nxp.com, pjez@cadence.com, kurahul@cadence.com List-ID: T24gVGh1LCBKYW4gMTAsIDIwMTkgYXQgMDk6MzA6NDFBTSArMDgwMCwgUGV0ZXIgQ2hlbiB3cm90 ZToKPiBPbiBNb24sIERlYyAyNCwgMjAxOCBhdCAxMjo0NCBBTSBQYXdlbCBMYXN6Y3phayA8cGF3 ZWxsQGNhZGVuY2UuY29tPiB3cm90ZToKPiAtIGRlYnVnZnMgaXMgbmljZSB0byBoYXZlIGZlYXR1 cmUsIEkgc3VnZ2VzdCByZW1vdmluZyBpdCBhdCB0aGlzCj4gaW5pdGlhbCB2ZXJzaW9uLiBCZXNp ZGVzLCByb2xlIHN3aXRjaAo+IHRocm91Z2ggL3N5cyBpcyBub3JtYWwgZmVhdHVyZSwgdGhlIGVu ZCB1c2VyIG1heSB1c2UgaXQgYXQgcmVhbAo+IHByb2R1Y3QsIHNvLCBpdCBpcyBiZXR0ZXIgYXQg ZGV2aWNlJ3MKPiAvc3lzIGVudHJ5IGluc3RlYWQgb2YgZGVidWdmcy4KPiAKPiAtIEkgZG9uJ3Qg a25vdyB3aHkgeW91IGFkZCAiZGlzYWJsZSIgYXQgZGVidWdmcywgcGxlYXNlIGNvbW1lbnQuCgpB cyB5b3UgaW1wbHkgaGVyZSwgbm8gcmVhbC13b3JsZCBmdW5jdGlvbmFsaXR5IHNob3VsZCBldmVy IGJlIGluCmRlYnVnZnMgYXMgaXQgaXMgYW4gb3B0aW9uYWwgc3lzdGVtIGNvbXBvbmVudCBhbmQg a2VybmVsIGNvZGUgc2hvdWxkCndvcmsganVzdCBmaW5lIHdpdGhvdXQgaXQgYmVpbmcgZW5hYmxl ZCAoYXMgbW9yZSBhbmQgbW9yZSBzeXN0ZW1zIGFyZQpkaXNhYmxpbmcgaXQgZHVlIHRvIHRoZSBv YnZpb3VzIHNlY3VyaXR5IHByb2JsZW1zIGl0IGhhcy4pCgp0aGFua3MsCgpncmVnIGstaAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH v2 5/5] usb:cdns3 Add Cadence USB3 DRD Driver Date: Thu, 10 Jan 2019 07:57:38 +0100 Message-ID: <20190110065738.GA28817@kroah.com> References: <1545577992-4013-1-git-send-email-pawell@cadence.com> <1545577992-4013-6-git-send-email-pawell@cadence.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Peter Chen Cc: Pawel Laszczak , devicetree@vger.kernel.org, mark.rutland@arm.com, linux-usb@vger.kernel.org, hdegoede@redhat.com, Heikki Krogerus , andy.shevchenko@gmail.com, robh+dt@kernel.org, rogerq@ti.com, lkml , adouglas@cadence.com, jbergsagel@ti.com, nsekhar@ti.com, nm@ti.com, sureshp@cadence.com, peter.chen@nxp.com, pjez@cadence.com, kurahul@cadence.com List-Id: devicetree@vger.kernel.org On Thu, Jan 10, 2019 at 09:30:41AM +0800, Peter Chen wrote: > On Mon, Dec 24, 2018 at 12:44 AM Pawel Laszczak wrote: > - debugfs is nice to have feature, I suggest removing it at this > initial version. Besides, role switch > through /sys is normal feature, the end user may use it at real > product, so, it is better at device's > /sys entry instead of debugfs. > > - I don't know why you add "disable" at debugfs, please comment. As you imply here, no real-world functionality should ever be in debugfs as it is an optional system component and kernel code should work just fine without it being enabled (as more and more systems are disabling it due to the obvious security problems it has.) thanks, greg k-h