From: Thierry Reding <thierry.reding@gmail.com>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: jassisinghbrar@gmail.com, jonathanh@nvidia.com,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] mailbox: tegra-hsp: mark PM functions as __maybe_unused
Date: Thu, 10 Jan 2019 09:16:15 +0100 [thread overview]
Message-ID: <20190110081615.GD5213@ulmo> (raw)
In-Reply-To: <20190108143713.15120-1-anders.roxell@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 755 bytes --]
On Tue, Jan 08, 2019 at 03:37:13PM +0100, Anders Roxell wrote:
> Without CONFIG_PM_SLEEP, we get annoying warnings about unused
> functions:
>
> drivers/mailbox/tegra-hsp.c:782:12: warning: ‘tegra_hsp_resume’ defined but not used [-Wunused-function]
> static int tegra_hsp_resume(struct device *dev)
> ^~~~~~~~~~~~~~~~
>
> Mark them as __maybe_unused to shut up the warning and silently drop the
> functions without having to add ugly #ifdefs.
>
> Fixes: 9a63f0f40599 ("mailbox: tegra-hsp: Add suspend/resume support")
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
> drivers/mailbox/tegra-hsp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-01-10 8:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 14:37 [PATCH] mailbox: tegra-hsp: mark PM functions as __maybe_unused Anders Roxell
2019-01-10 8:16 ` Thierry Reding [this message]
2019-06-19 7:56 ` Anders Roxell
2019-06-19 7:57 ` Anders Roxell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190110081615.GD5213@ulmo \
--to=thierry.reding@gmail.com \
--cc=anders.roxell@linaro.org \
--cc=jassisinghbrar@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.