From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1] tools: logos: crop Toradex logo slightly
Date: Thu, 10 Jan 2019 10:29:18 +0100 [thread overview]
Message-ID: <20190110102918.52383ba9@jawa> (raw)
In-Reply-To: <65e073a5-0508-a05d-efe4-765805322abd@denx.de>
Hi Stefano,
> On 09/01/19 22:38, Lukasz Majewski wrote:
> > On Wed, 9 Jan 2019 16:41:40 +0100
> > Stefano Babic <sbabic@denx.de> wrote:
> >
> >> Hi Stefan, Lukasz,
> >>
> >> On 04/01/19 16:05, Stefan Agner wrote:
> >>> Hi Stefano,
> >>>
> >>> On 14.12.2018 14:40, Stefano Babic wrote:
> >>>> On 14/12/18 14:30, Tom Rini wrote:
> >>>>> On Fri, Dec 14, 2018 at 02:26:22PM +0100, Stefan Agner
> >>>>> wrote:
> >>>>>> On 14.12.2018 14:20, Tom Rini wrote:
> >>>>>>> On Fri, Dec 14, 2018 at 02:13:46PM +0100, Stefan Agner
> >>>>>>> wrote:
> >>>>>>>> Hi Tom,
> >>>>>>>>
> >>>>>>>> On 08.12.2018 17:48, Lukasz Majewski wrote:
> >>>>>>>>> Hi Stefan,
> >>>>>>>>>
> >>>>>>>>>> From: Stefan Agner <stefan.agner@toradex.com>
> >>>>>>>>>>
> >>>>>>>>>> The current bitmap is a bit larger than necessary, it has a
> >>>>>>>>>> black border around the Toradex logo. Crop the logo
> >>>>>>>>>> slightly which safes some space, useful especially on
> >>>>>>>>>> Colibri VFxx.
> >>>>>>>>>
> >>>>>>>>> I can confirm that those changes, as well as
> >>>>>>>>>
> >>>>>>>>> [PATCH v1] board: toradex: colibri_vf: unset NFS and
> >>>>>>>>> LOADS/B
> >>
> >> You're right, this was slipped away, I pick it now.
> >>
> >>>>>>>>> [PATCH v1] mtd: nand: raw: allow to disable unneeded ECC
> >>>>>>>>> layouts [PATCH v1] fs: fat: dynamically allocate memory for
> >>>>>>>>> temporary buffer
> >>
> >> Both of them are outside u-boot-imx, so they will be merged by
> >> Scott / Tom.
> >>
> >>>>>>>>
> >>>>>>>> I think all of those go directly into your tree?
> >>>>>>>
> >>>>>>> I had filed vybird stuff off to Stefano for some, hopefully
> >>>>>>> correct reason. The FAT change and logo change are me,
> >>>>>>> yes.
> >>>>>>
> >>>>>> I guess the mtd change is rather global...
> >>>>>
> >>>>> Ah right. Maybe I gave it to myself? I know I assigned it in
> >>>>> patchwork.
> >>>>>
> >>>>>> Currently board/toradex is not specifically marked to be
> >>>>>> maintained by Stefano (we also have Tegra boards). But yeah for
> >>>>>> Vybrid it probably makes sense.
> >>>>>
> >>>>
> >>>> Yes, I saw your patches, I will picked them up after current PR
> >>>> (sent now) will be merged.
> >>>
> >>> This still did not make it. Can it still be considered for the
> >>> next release?
> >>>
> >>> There is also:
> >>> - board: toradex: colibri_vf: unset NFS and LOADS/B
> >>> - ARM: vf610: ddrmc: program Dummy DDRBYTE1/2
> >>
> >> Applied to u-boot-imx.
> >>
> >>> - ddr: vybrid: various fixes (patchset)
> >>
> >> There is a (slight) conflict with Lukasz's patches regarding DDR
> >> calibration. I won't pick Lukasz's for 2019.01,
> >
> > Ok. No problem.
> > ( The DDR patch series itself:
> > http://patchwork.ozlabs.org/cover/1008330/)
> >
>
> There is a topic I would like to check. Stefan introduces with his
> patches a DDRMC_CR80_MC_INIT_COMPLETE that is still missing in your
> patches. I solved the conflict (not yet pushed to -next) as :
>
> while (!(readl(&ddrmr->cr[80]) & DDRMC_CR80_MC_INIT_COMPLETE))
> udelay(10);
> writel(DDRMC_CR80_MC_INIT_COMPLETE, &ddrmr->cr[81]);
>
> #ifdef CONFIG_DDRMC_VF610_CALIBRATION
> ddrmc_calibration(ddrmr);
> #endif
>
> But I have no idea if DDRMC_CR80_MC_INIT_COMPLETE should be done
> before the calibration of maybe after. Could you help me ?
I've already rebased (DDR calibration code) on top of Stefan's patches:
http://git.denx.de/?p=u-boot/u-boot-dfu.git;a=shortlog;h=refs/heads/testing
The code in question looks like in below link:
http://git.denx.de/?p=u-boot/u-boot-dfu.git;a=blob;f=arch/arm/mach-imx/ddrmc-vf610.c;h=9a8e2f6aad10adc45fa791d24ffad52c42c5c492;hb=refs/heads/testing#l231
>
> >> and I could solve the
> >> conflict in -next branch. IMHO I have no concerns (open points)
> >> regarding usage of bit shifting instead of BIT() macro. So I pushed
> >> this patchset and I delay Lukasz's to next release.
> >
> > Ok. Thanks for the update.
> >
>
> Best regards,
> Stefano
>
>
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190110/55e8ebee/attachment.sig>
next prev parent reply other threads:[~2019-01-10 9:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 13:53 [U-Boot] [PATCH v1] tools: logos: crop Toradex logo slightly Stefan Agner
2018-12-06 14:41 ` Lukasz Majewski
2018-12-08 16:48 ` Lukasz Majewski
2018-12-14 13:13 ` Stefan Agner
2018-12-14 13:20 ` Tom Rini
2018-12-14 13:26 ` Stefan Agner
2018-12-14 13:30 ` Tom Rini
2018-12-14 13:40 ` Stefano Babic
2019-01-04 15:05 ` Stefan Agner
2019-01-09 15:41 ` Stefano Babic
2019-01-09 21:38 ` Lukasz Majewski
2019-01-10 8:15 ` Stefano Babic
2019-01-10 9:29 ` Lukasz Majewski [this message]
2019-01-10 9:34 ` Stefano Babic
2019-01-10 9:47 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190110102918.52383ba9@jawa \
--to=lukma@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.